* [PATCH] mtd: spi-nor: Remove unneeded driver.bus assignment
@ 2018-02-14 12:46 Boris Brezillon
2018-02-14 16:09 ` Han Xu
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2018-02-14 12:46 UTC (permalink / raw)
To: Han Xu
Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-mtd
platform_driver_register() takes care of assigning driver->bus
to &platform_bus_type, no need to explicitly assign it in the driver.
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
drivers/mtd/spi-nor/fsl-quadspi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 2901c7bd9e30..dc9914fce296 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -1174,7 +1174,6 @@ static int fsl_qspi_resume(struct platform_device *pdev)
static struct platform_driver fsl_qspi_driver = {
.driver = {
.name = "fsl-quadspi",
- .bus = &platform_bus_type,
.of_match_table = fsl_qspi_dt_ids,
},
.probe = fsl_qspi_probe,
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: Remove unneeded driver.bus assignment
2018-02-14 12:46 [PATCH] mtd: spi-nor: Remove unneeded driver.bus assignment Boris Brezillon
@ 2018-02-14 16:09 ` Han Xu
2018-03-04 16:55 ` Cyrille Pitchen
0 siblings, 1 reply; 3+ messages in thread
From: Han Xu @ 2018-02-14 16:09 UTC (permalink / raw)
To: Boris Brezillon
Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
Cyrille Pitchen, linux-mtd
On 02/14/2018 06:46 AM, Boris Brezillon wrote:
> platform_driver_register() takes care of assigning driver->bus
> to &platform_bus_type, no need to explicitly assign it in the driver.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/mtd/spi-nor/fsl-quadspi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 2901c7bd9e30..dc9914fce296 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -1174,7 +1174,6 @@ static int fsl_qspi_resume(struct platform_device *pdev)
> static struct platform_driver fsl_qspi_driver = {
> .driver = {
> .name = "fsl-quadspi",
> - .bus = &platform_bus_type,
> .of_match_table = fsl_qspi_dt_ids,
> },
> .probe = fsl_qspi_probe,
Acked-by: Han Xu <han.xu@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: Remove unneeded driver.bus assignment
2018-02-14 16:09 ` Han Xu
@ 2018-03-04 16:55 ` Cyrille Pitchen
0 siblings, 0 replies; 3+ messages in thread
From: Cyrille Pitchen @ 2018-03-04 16:55 UTC (permalink / raw)
To: Han Xu, Boris Brezillon
Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
linux-mtd
Le 14/02/2018 à 17:09, Han Xu a écrit :
>
>
> On 02/14/2018 06:46 AM, Boris Brezillon wrote:
>> platform_driver_register() takes care of assigning driver->bus
>> to &platform_bus_type, no need to explicitly assign it in the driver.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Applied to the spi-nor/next branch of linux-mtd
Thanks!
>> ---
>> drivers/mtd/spi-nor/fsl-quadspi.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
>> index 2901c7bd9e30..dc9914fce296 100644
>> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
>> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
>> @@ -1174,7 +1174,6 @@ static int fsl_qspi_resume(struct platform_device *pdev)
>> static struct platform_driver fsl_qspi_driver = {
>> .driver = {
>> .name = "fsl-quadspi",
>> - .bus = &platform_bus_type,
>> .of_match_table = fsl_qspi_dt_ids,
>> },
>> .probe = fsl_qspi_probe,
> Acked-by: Han Xu <han.xu@nxp.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-04 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 12:46 [PATCH] mtd: spi-nor: Remove unneeded driver.bus assignment Boris Brezillon
2018-02-14 16:09 ` Han Xu
2018-03-04 16:55 ` Cyrille Pitchen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.