* [PATCH v2 5/7] drm/probe-helper: use drm_kms_helper_connector_hotplug_event
@ 2021-06-09 21:23 ` Simon Ser
0 siblings, 0 replies; 3+ messages in thread
From: Simon Ser @ 2021-06-09 21:23 UTC (permalink / raw)
To: dri-devel, amd-gfx; +Cc: pekka.paalanen, michel, alexander.deucher, intel-gfx
If an hotplug event only updates a single connector, use
drm_kms_helper_connector_hotplug_event instead of
drm_kms_helper_hotplug_event.
Signed-off-by: Simon Ser <contact@emersion.fr>
---
drivers/gpu/drm/drm_probe_helper.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 8cc673267cba..f4130c1a90e2 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -843,7 +843,7 @@ EXPORT_SYMBOL(drm_kms_helper_poll_fini);
*/
bool drm_helper_hpd_irq_event(struct drm_device *dev)
{
- struct drm_connector *connector;
+ struct drm_connector *connector, *changed_connector = NULL;
struct drm_connector_list_iter conn_iter;
enum drm_connector_status old_status;
bool changed = false;
@@ -883,16 +883,27 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
* Check if epoch counter had changed, meaning that we need
* to send a uevent.
*/
- if (old_epoch_counter != connector->epoch_counter)
+ if (old_epoch_counter != connector->epoch_counter) {
+ if (changed) {
+ if (changed_connector)
+ drm_connector_put(changed_connector);
+ changed_connector = NULL;
+ } else {
+ drm_connector_get(connector);
+ changed_connector = connector;
+ }
changed = true;
+ }
}
drm_connector_list_iter_end(&conn_iter);
mutex_unlock(&dev->mode_config.mutex);
- if (changed) {
+ if (changed_connector) {
+ drm_kms_helper_connector_hotplug_event(changed_connector);
+ drm_connector_put(changed_connector);
+ } else if (changed) {
drm_kms_helper_hotplug_event(dev);
- DRM_DEBUG_KMS("Sent hotplug event\n");
}
return changed;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] [PATCH v2 5/7] drm/probe-helper: use drm_kms_helper_connector_hotplug_event
@ 2021-06-09 21:23 ` Simon Ser
0 siblings, 0 replies; 3+ messages in thread
From: Simon Ser @ 2021-06-09 21:23 UTC (permalink / raw)
To: dri-devel, amd-gfx
Cc: pekka.paalanen, michel, alexander.deucher, harry.wentland, intel-gfx
If an hotplug event only updates a single connector, use
drm_kms_helper_connector_hotplug_event instead of
drm_kms_helper_hotplug_event.
Signed-off-by: Simon Ser <contact@emersion.fr>
---
drivers/gpu/drm/drm_probe_helper.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 8cc673267cba..f4130c1a90e2 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -843,7 +843,7 @@ EXPORT_SYMBOL(drm_kms_helper_poll_fini);
*/
bool drm_helper_hpd_irq_event(struct drm_device *dev)
{
- struct drm_connector *connector;
+ struct drm_connector *connector, *changed_connector = NULL;
struct drm_connector_list_iter conn_iter;
enum drm_connector_status old_status;
bool changed = false;
@@ -883,16 +883,27 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
* Check if epoch counter had changed, meaning that we need
* to send a uevent.
*/
- if (old_epoch_counter != connector->epoch_counter)
+ if (old_epoch_counter != connector->epoch_counter) {
+ if (changed) {
+ if (changed_connector)
+ drm_connector_put(changed_connector);
+ changed_connector = NULL;
+ } else {
+ drm_connector_get(connector);
+ changed_connector = connector;
+ }
changed = true;
+ }
}
drm_connector_list_iter_end(&conn_iter);
mutex_unlock(&dev->mode_config.mutex);
- if (changed) {
+ if (changed_connector) {
+ drm_kms_helper_connector_hotplug_event(changed_connector);
+ drm_connector_put(changed_connector);
+ } else if (changed) {
drm_kms_helper_hotplug_event(dev);
- DRM_DEBUG_KMS("Sent hotplug event\n");
}
return changed;
--
2.31.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 5/7] drm/probe-helper: use drm_kms_helper_connector_hotplug_event
@ 2021-06-09 21:23 ` Simon Ser
0 siblings, 0 replies; 3+ messages in thread
From: Simon Ser @ 2021-06-09 21:23 UTC (permalink / raw)
To: dri-devel, amd-gfx
Cc: pekka.paalanen, michel, daniel, daniel, alexander.deucher,
harry.wentland, intel-gfx
If an hotplug event only updates a single connector, use
drm_kms_helper_connector_hotplug_event instead of
drm_kms_helper_hotplug_event.
Signed-off-by: Simon Ser <contact@emersion.fr>
---
drivers/gpu/drm/drm_probe_helper.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 8cc673267cba..f4130c1a90e2 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -843,7 +843,7 @@ EXPORT_SYMBOL(drm_kms_helper_poll_fini);
*/
bool drm_helper_hpd_irq_event(struct drm_device *dev)
{
- struct drm_connector *connector;
+ struct drm_connector *connector, *changed_connector = NULL;
struct drm_connector_list_iter conn_iter;
enum drm_connector_status old_status;
bool changed = false;
@@ -883,16 +883,27 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
* Check if epoch counter had changed, meaning that we need
* to send a uevent.
*/
- if (old_epoch_counter != connector->epoch_counter)
+ if (old_epoch_counter != connector->epoch_counter) {
+ if (changed) {
+ if (changed_connector)
+ drm_connector_put(changed_connector);
+ changed_connector = NULL;
+ } else {
+ drm_connector_get(connector);
+ changed_connector = connector;
+ }
changed = true;
+ }
}
drm_connector_list_iter_end(&conn_iter);
mutex_unlock(&dev->mode_config.mutex);
- if (changed) {
+ if (changed_connector) {
+ drm_kms_helper_connector_hotplug_event(changed_connector);
+ drm_connector_put(changed_connector);
+ } else if (changed) {
drm_kms_helper_hotplug_event(dev);
- DRM_DEBUG_KMS("Sent hotplug event\n");
}
return changed;
--
2.31.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 21:23 [PATCH v2 5/7] drm/probe-helper: use drm_kms_helper_connector_hotplug_event Simon Ser
2021-06-09 21:23 ` Simon Ser
2021-06-09 21:23 ` [Intel-gfx] " Simon Ser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.