All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 6/7] native: Stop clearing PACKAGES
Date: Thu, 04 Feb 2021 20:34:17 +0000	[thread overview]
Message-ID: <ca17a635c2003515d48cb229a351e69d2d85525c.camel@linuxfoundation.org> (raw)
In-Reply-To: <19078ab047664bb995906baf0a36a54c@XBOX03.axis.com>

On Thu, 2021-02-04 at 19:43 +0000, Peter Kjellerstedt wrote:
> 
> 
> > diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> > b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> > index 16708fd581d..226e1c7b89f 100644
> > --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> > +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb
> > @@ -13,6 +13,7 @@ LIC_FILES_CHKSUM = "
> > file://COPYING;md5=4fbd65380cdd255951079008b364516c \
> >  SECTION = "libs"
> > 
> >  DEPENDS = "glib-2.0 gdk-pixbuf-native shared-mime-info"
> > +DEPENDS_remove_class-native = "gdk-pixbuf-native"
> 
> Given that I know you want to avoid using _remove in OE-Core, is
> there 
> any reason to not write this as:
> 
> DEPENDS = "glib-2.0 shared-mime-info"
> DEPENDS_append_class-target = " gdk-pixbuf-native"
> DEPENDS_append_class-nativesdk = " gdk-pixbuf-native"

That would be better, yes. I'll admit with this series I was dealing
with a lot of weird issues so the end result still could use some
improvement. There are probably a few places in the metadata we could
improve now.

> (I'm not sure the append for nativesdk should be there, but I added
> it to match the original code.)

I'd suspect the nativesdk is needed.

Cheers,

Richard


  reply	other threads:[~2021-02-04 20:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 17:27 [PATCH 1/7] ncurses: Don't put terminfo into the sysroot Richard Purdie
2021-01-27 17:27 ` [PATCH 2/7] python3: Avoid installing test data into recipe-sysroot Richard Purdie
2021-01-27 17:27 ` [PATCH 3/7] staging: Clean up files installed into the sysroot Richard Purdie
2021-01-27 17:27 ` [PATCH 4/7] gobject-introspection: Fix variable override order Richard Purdie
2021-01-27 17:27 ` [PATCH 5/7] bitbake.conf/python: Drop setting RDEPENDS/RPROVIDES default Richard Purdie
2021-01-27 17:27 ` [PATCH 6/7] native: Stop clearing PACKAGES Richard Purdie
2021-01-30 16:15   ` [OE-core] " Martin Jansa
2021-01-31  9:07     ` Richard Purdie
2021-01-31  9:55       ` Martin Jansa
2021-01-31 10:34         ` Richard Purdie
2021-01-31 13:10           ` Martin Jansa
2021-02-01 14:26             ` Anibal Limon
2021-02-01 20:21             ` Richard Purdie
2021-02-01 20:44               ` Martin Jansa
2021-02-04 19:43   ` Peter Kjellerstedt
2021-02-04 20:34     ` Richard Purdie [this message]
2021-01-27 17:27 ` [PATCH 7/7] meta: Clean up various class-native* RDEPENDS overrides Richard Purdie
2021-01-28  8:45 ` [OE-core] [PATCH 1/7] ncurses: Don't put terminfo into the sysroot Mikko Rapeli
2021-01-28  9:02   ` Richard Purdie
2021-01-28 10:35     ` Mikko Rapeli
2021-01-28 10:52       ` Richard Purdie
2021-01-28 16:38   ` Richard Purdie
2021-01-29  8:28     ` Mikko Rapeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca17a635c2003515d48cb229a351e69d2d85525c.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.