Re: [OE-core] [PATCH 6/7] native: Stop clearing PACKAGES

From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 6/7] native: Stop clearing PACKAGES
Date: Sun, 31 Jan 2021 09:07:50 +0000	[thread overview]
Message-ID: <d29734c79a8d5712f4c2cc720e11071dedb68383.camel@linuxfoundation.org> (raw)
In-Reply-To: <CA+chaQdc7P6NsTno6oCcB4HmoseMziAXA57f646=YWWDPyEH8w@mail.gmail.com>

On Sat, 2021-01-30 at 17:15 +0100, Martin Jansa wrote:
> 
> 
> On Wed, Jan 27, 2021 at 6:28 PM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > Some now unneeded code in python3-setuptools is dropped, there are
> > further
> > changes like this which can follow.
> > 
> > This change was verified with OE-Core by comparing task-depends.dot
> > generated
> > by "bitbake world -g" before and after the change, the files were
> > identical.
> > 
> > diff --git a/meta/recipes-
> > devtools/python/python3-setuptools_51.0.0.bb b/meta/recipes-
> > devtools/python/python3-setuptools_51.0.0.bb
> > index 6ee935f8f79..db336bfa13b 100644
> > --- a/meta/recipes-devtools/python/python3-setuptools_51.0.0.bb
> > +++ b/meta/recipes-devtools/python/python3-setuptools_51.0.0.bb
> > @@ -58,8 +58,3 @@ RDEPENDS_${PYTHON_PN}-pkg-resources = "\
> >    ${PYTHON_PN}-plistlib \
> >    ${PYTHON_PN}-pprint \
> >  "
> > -# Due to the way OE-Core implemented native recipes, the native
> > class cannot
> > -# have a dependency on something that is not a recipe name. Work
> > around that by
> > -# manually setting RPROVIDES.
> > -RDEPENDS_${PN}_append = " ${PYTHON_PN}-pkg-resources"
> > -RPROVIDES_append_class-native = " ${PYTHON_PN}-pkg-resources-
> > native"
> > 
>  
> The runtime dependency on ${PYTHON_PN}-pkg-resources isn't needed
> anymore? I don't see how it would get still included as you said that
> bitbake -g files were the same.

I think you're right and I shouldn't have removed the RDEPENDS, only
the RPROVIDES. bitbake -g are task dependencies and the task
dependencies still showed up so this didn't highlight any issue.

I'll test a patch to fix that and add it back, probably in the main
RDEPENDS list.

> I'm asking because meta-python2 has the same issue in:
> https://git.openembedded.org/meta-python2/tree/recipes-devtools/python/python-setuptools.inc#n49
> 
> and my fix I was planing to send was to replace it with:
> RDEPENDS_${PN}_append_class-target = " ${PYTHON_PN}-pkg-resources"
> and drop the RPROVIDES, because it unfortunately causes bitbake to
> get stuck after reporting parsing error as:
> 
> ERROR: meta-python2/recipes-devtools/python/python-
> setuptools_42.0.2.bb: QA Issue: meta-python2/recipes-
> devtools/python/python-setuptools_42.0.2.bb: Variable RPROVIDES is
> set as not being package specific, please fix this. [pkgvarcheck]
> ERROR: meta-python2/recipes-devtools/python/python-
> setuptools_42.0.2.bb: Fatal QA errors found, failing task.
> ERROR: Failed to parse recipe: meta-python2/recipes-
> devtools/python/python-setuptools_42.0.2.bb

Are you saying that it does that with the RPROVIDES removed? That seems
odd :/

Cheers,

Richard