* [mkp-scsi:for-next 276/292] drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
@ 2021-08-24 9:58 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-08-24 9:42 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4792 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Adrian Hunter <adrian.hunter@intel.com>
CC: "Martin K. Petersen" <martin.petersen@oracle.com>
CC: Bart Van Assche <bvanassche@acm.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head: d09224115cf67bdce4eef2ca3533f86ab1ea1942
commit: c6b2e1373c89c4ecf2b379720b3eb24cf99844f4 [276/292] scsi: ufs: Fix ufshcd_request_sense_async() for Samsung KLUFG8RHDA-B2D1
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: i386-randconfig-m021-20210824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
Old smatch warnings:
drivers/scsi/ufs/ufshcd.c:5254 ufshcd_uic_cmd_compl() error: we previously assumed 'hba->active_uic_cmd' could be null (see line 5242)
vim +/buffer +7965 drivers/scsi/ufs/ufshcd.c
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7944
4f3e900b628226 Jaegeuk Kim 2020-11-17 7945 static int
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7946 ufshcd_request_sense_async(struct ufs_hba *hba, struct scsi_device *sdev)
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7947 {
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7948 /*
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7949 * Some UFS devices clear unit attention condition only if the sense
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7950 * size used (UFS_SENSE_SIZE in this case) is non-zero.
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7951 */
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7952 static const u8 cmd[6] = {REQUEST_SENSE, 0, 0, 0, UFS_SENSE_SIZE, 0};
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7953 struct scsi_request *rq;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7954 struct request *req;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7955 char *buffer;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7956 int ret;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7957
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7958 buffer = kzalloc(UFS_SENSE_SIZE, GFP_KERNEL);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7959 if (!buffer)
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7960 return -ENOMEM;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7961
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7962 req = blk_get_request(sdev->request_queue, REQ_OP_DRV_IN,
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7963 /*flags=*/BLK_MQ_REQ_PM);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7964 if (IS_ERR(req))
ac1bc2ba060f96 Bart Van Assche 2021-07-21 @7965 return PTR_ERR(req);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7966
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7967 ret = blk_rq_map_kern(sdev->request_queue, req,
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7968 buffer, UFS_SENSE_SIZE, GFP_NOIO);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7969 if (ret) {
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7970 blk_put_request(req);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7971 kfree(buffer);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7972 return ret;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7973 }
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7974
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7975 rq = scsi_req(req);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7976 rq->cmd_len = ARRAY_SIZE(cmd);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7977 memcpy(rq->cmd, cmd, rq->cmd_len);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7978 rq->retries = 3;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7979 req->timeout = 1 * HZ;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7980 req->rq_flags |= RQF_PM | RQF_QUIET;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7981 req->end_io_data = buffer;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7982
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7983 blk_execute_rq_nowait(/*bd_disk=*/NULL, req, /*at_head=*/true,
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7984 ufshcd_request_sense_done);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7985 return 0;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7986 }
4f3e900b628226 Jaegeuk Kim 2020-11-17 7987
:::::: The code at line 7965 was first introduced by commit
:::::: ac1bc2ba060f9609972fb486073ebd9eab1ef3b6 scsi: ufs: Request sense data asynchronously
:::::: TO: Bart Van Assche <bvanassche@acm.org>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40531 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [mkp-scsi:for-next 276/292] drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
@ 2021-08-24 9:58 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-08-24 9:58 UTC (permalink / raw)
To: kbuild, Adrian Hunter
Cc: lkp, kbuild-all, linux-kernel, Martin K. Petersen, Bart Van Assche
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head: d09224115cf67bdce4eef2ca3533f86ab1ea1942
commit: c6b2e1373c89c4ecf2b379720b3eb24cf99844f4 [276/292] scsi: ufs: Fix ufshcd_request_sense_async() for Samsung KLUFG8RHDA-B2D1
config: i386-randconfig-m021-20210824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
Old smatch warnings:
drivers/scsi/ufs/ufshcd.c:5254 ufshcd_uic_cmd_compl() error: we previously assumed 'hba->active_uic_cmd' could be null (see line 5242)
vim +/buffer +7965 drivers/scsi/ufs/ufshcd.c
4f3e900b628226 Jaegeuk Kim 2020-11-17 7945 static int
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7946 ufshcd_request_sense_async(struct ufs_hba *hba, struct scsi_device *sdev)
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7947 {
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7948 /*
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7949 * Some UFS devices clear unit attention condition only if the sense
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7950 * size used (UFS_SENSE_SIZE in this case) is non-zero.
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7951 */
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7952 static const u8 cmd[6] = {REQUEST_SENSE, 0, 0, 0, UFS_SENSE_SIZE, 0};
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7953 struct scsi_request *rq;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7954 struct request *req;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7955 char *buffer;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7956 int ret;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7957
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7958 buffer = kzalloc(UFS_SENSE_SIZE, GFP_KERNEL);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7959 if (!buffer)
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7960 return -ENOMEM;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7961
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7962 req = blk_get_request(sdev->request_queue, REQ_OP_DRV_IN,
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7963 /*flags=*/BLK_MQ_REQ_PM);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7964 if (IS_ERR(req))
ac1bc2ba060f96 Bart Van Assche 2021-07-21 @7965 return PTR_ERR(req);
kfree(buffer);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7966
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7967 ret = blk_rq_map_kern(sdev->request_queue, req,
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7968 buffer, UFS_SENSE_SIZE, GFP_NOIO);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7969 if (ret) {
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7970 blk_put_request(req);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7971 kfree(buffer);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7972 return ret;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7973 }
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7974
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7975 rq = scsi_req(req);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7976 rq->cmd_len = ARRAY_SIZE(cmd);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7977 memcpy(rq->cmd, cmd, rq->cmd_len);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7978 rq->retries = 3;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7979 req->timeout = 1 * HZ;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7980 req->rq_flags |= RQF_PM | RQF_QUIET;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7981 req->end_io_data = buffer;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7982
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7983 blk_execute_rq_nowait(/*bd_disk=*/NULL, req, /*at_head=*/true,
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7984 ufshcd_request_sense_done);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7985 return 0;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7986 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* [mkp-scsi:for-next 276/292] drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
@ 2021-08-24 9:58 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-08-24 9:58 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4165 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head: d09224115cf67bdce4eef2ca3533f86ab1ea1942
commit: c6b2e1373c89c4ecf2b379720b3eb24cf99844f4 [276/292] scsi: ufs: Fix ufshcd_request_sense_async() for Samsung KLUFG8RHDA-B2D1
config: i386-randconfig-m021-20210824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
Old smatch warnings:
drivers/scsi/ufs/ufshcd.c:5254 ufshcd_uic_cmd_compl() error: we previously assumed 'hba->active_uic_cmd' could be null (see line 5242)
vim +/buffer +7965 drivers/scsi/ufs/ufshcd.c
4f3e900b628226 Jaegeuk Kim 2020-11-17 7945 static int
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7946 ufshcd_request_sense_async(struct ufs_hba *hba, struct scsi_device *sdev)
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7947 {
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7948 /*
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7949 * Some UFS devices clear unit attention condition only if the sense
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7950 * size used (UFS_SENSE_SIZE in this case) is non-zero.
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7951 */
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7952 static const u8 cmd[6] = {REQUEST_SENSE, 0, 0, 0, UFS_SENSE_SIZE, 0};
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7953 struct scsi_request *rq;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7954 struct request *req;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7955 char *buffer;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7956 int ret;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7957
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7958 buffer = kzalloc(UFS_SENSE_SIZE, GFP_KERNEL);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7959 if (!buffer)
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7960 return -ENOMEM;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7961
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7962 req = blk_get_request(sdev->request_queue, REQ_OP_DRV_IN,
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7963 /*flags=*/BLK_MQ_REQ_PM);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7964 if (IS_ERR(req))
ac1bc2ba060f96 Bart Van Assche 2021-07-21 @7965 return PTR_ERR(req);
kfree(buffer);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7966
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7967 ret = blk_rq_map_kern(sdev->request_queue, req,
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7968 buffer, UFS_SENSE_SIZE, GFP_NOIO);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7969 if (ret) {
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7970 blk_put_request(req);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7971 kfree(buffer);
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7972 return ret;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7973 }
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7974
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7975 rq = scsi_req(req);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7976 rq->cmd_len = ARRAY_SIZE(cmd);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7977 memcpy(rq->cmd, cmd, rq->cmd_len);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7978 rq->retries = 3;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7979 req->timeout = 1 * HZ;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7980 req->rq_flags |= RQF_PM | RQF_QUIET;
c6b2e1373c89c4 Adrian Hunter 2021-08-23 7981 req->end_io_data = buffer;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7982
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7983 blk_execute_rq_nowait(/*bd_disk=*/NULL, req, /*at_head=*/true,
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7984 ufshcd_request_sense_done);
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7985 return 0;
ac1bc2ba060f96 Bart Van Assche 2021-07-21 7986 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [mkp-scsi:for-next 276/292] drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
2021-08-24 9:58 ` Dan Carpenter
@ 2021-08-24 23:29 ` Bart Van Assche
-1 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2021-08-24 23:29 UTC (permalink / raw)
To: Dan Carpenter, kbuild, Adrian Hunter
Cc: lkp, kbuild-all, linux-kernel, Martin K. Petersen
On 8/24/21 2:58 AM, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
> head: d09224115cf67bdce4eef2ca3533f86ab1ea1942
> commit: c6b2e1373c89c4ecf2b379720b3eb24cf99844f4 [276/292] scsi: ufs: Fix ufshcd_request_sense_async() for Samsung KLUFG8RHDA-B2D1
> config: i386-randconfig-m021-20210824 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
Hi Adrian,
Since this patch has been queued on Martin's for-next branch, do you plan to post a fix?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [mkp-scsi:for-next 276/292] drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
@ 2021-08-24 23:29 ` Bart Van Assche
0 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2021-08-24 23:29 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On 8/24/21 2:58 AM, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
> head: d09224115cf67bdce4eef2ca3533f86ab1ea1942
> commit: c6b2e1373c89c4ecf2b379720b3eb24cf99844f4 [276/292] scsi: ufs: Fix ufshcd_request_sense_async() for Samsung KLUFG8RHDA-B2D1
> config: i386-randconfig-m021-20210824 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer'
Hi Adrian,
Since this patch has been queued on Martin's for-next branch, do you plan to post a fix?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-24 23:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 9:42 [mkp-scsi:for-next 276/292] drivers/scsi/ufs/ufshcd.c:7965 ufshcd_request_sense_async() warn: possible memory leak of 'buffer' kernel test robot
2021-08-24 9:58 ` Dan Carpenter
2021-08-24 9:58 ` Dan Carpenter
2021-08-24 23:29 ` Bart Van Assche
2021-08-24 23:29 ` Bart Van Assche
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.