All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Paul Elder <paul.elder@ideasonboard.com>, linux-media@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dafna Hirschfeld <dafna@fastmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Helen Koike <helen.koike@collabora.com>,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example
Date: Fri, 18 Nov 2022 14:06:14 +0100	[thread overview]
Message-ID: <ca8a6070-3888-8d42-5974-d7c2adc62417@linaro.org> (raw)
In-Reply-To: <20221118093931.1284465-3-paul.elder@ideasonboard.com>

On 18/11/2022 10:39, Paul Elder wrote:
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Add an example to the rockchip-isp1 DT binding that showcases usage of
> the parallel input of the ISP, connected to the CSI-2 receiver internal
> to the i.MX8MP.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Missing SoB.

> ---
>  .../bindings/media/rockchip-isp1.yaml         | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
> 

I don't know what do you demonstrate there... usage of endpoints? That's
the only difference. Such usage is the same everywhere, nothing specific
to this example. You already have two examples, so I don't think this
brings anything more.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Paul Elder <paul.elder@ideasonboard.com>, linux-media@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dafna Hirschfeld <dafna@fastmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Helen Koike <helen.koike@collabora.com>,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example
Date: Fri, 18 Nov 2022 14:06:14 +0100	[thread overview]
Message-ID: <ca8a6070-3888-8d42-5974-d7c2adc62417@linaro.org> (raw)
In-Reply-To: <20221118093931.1284465-3-paul.elder@ideasonboard.com>

On 18/11/2022 10:39, Paul Elder wrote:
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Add an example to the rockchip-isp1 DT binding that showcases usage of
> the parallel input of the ISP, connected to the CSI-2 receiver internal
> to the i.MX8MP.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Missing SoB.

> ---
>  .../bindings/media/rockchip-isp1.yaml         | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
> 

I don't know what do you demonstrate there... usage of endpoints? That's
the only difference. Such usage is the same everywhere, nothing specific
to this example. You already have two examples, so I don't think this
brings anything more.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Paul Elder <paul.elder@ideasonboard.com>, linux-media@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dafna Hirschfeld <dafna@fastmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Helen Koike <helen.koike@collabora.com>,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example
Date: Fri, 18 Nov 2022 14:06:14 +0100	[thread overview]
Message-ID: <ca8a6070-3888-8d42-5974-d7c2adc62417@linaro.org> (raw)
In-Reply-To: <20221118093931.1284465-3-paul.elder@ideasonboard.com>

On 18/11/2022 10:39, Paul Elder wrote:
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Add an example to the rockchip-isp1 DT binding that showcases usage of
> the parallel input of the ISP, connected to the CSI-2 receiver internal
> to the i.MX8MP.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Missing SoB.

> ---
>  .../bindings/media/rockchip-isp1.yaml         | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
> 

I don't know what do you demonstrate there... usage of endpoints? That's
the only difference. Such usage is the same everywhere, nothing specific
to this example. You already have two examples, so I don't think this
brings anything more.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-18 13:06 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18  9:39 [PATCH v3 00/14] media: rkisp1: Add support for i.MX8MP Paul Elder
2022-11-18  9:39 ` Paul Elder
2022-11-18  9:39 ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 01/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18 13:02   ` Krzysztof Kozlowski
2022-11-18 13:02     ` Krzysztof Kozlowski
2022-11-18 13:02     ` Krzysztof Kozlowski
2022-11-19  6:31     ` Paul Elder
2022-11-19  6:31       ` Paul Elder
2022-11-19  6:31       ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18 13:06   ` Krzysztof Kozlowski [this message]
2022-11-18 13:06     ` Krzysztof Kozlowski
2022-11-18 13:06     ` Krzysztof Kozlowski
2022-11-19  6:55     ` Paul Elder
2022-11-19  6:55       ` Paul Elder
2022-11-19  6:55       ` Paul Elder
2022-11-20 10:36       ` Krzysztof Kozlowski
2022-11-20 10:36         ` Krzysztof Kozlowski
2022-11-20 10:36         ` Krzysztof Kozlowski
2022-11-21  5:09         ` Paul Elder
2022-11-21  5:09           ` Paul Elder
2022-11-21  5:09           ` Paul Elder
2022-11-21  8:04           ` Krzysztof Kozlowski
2022-11-21  8:04             ` Krzysztof Kozlowski
2022-11-21  8:04             ` Krzysztof Kozlowski
2022-11-21 10:38             ` Laurent Pinchart
2022-11-21 10:38               ` Laurent Pinchart
2022-11-21 10:38               ` Laurent Pinchart
2022-11-21 11:16               ` Krzysztof Kozlowski
2022-11-21 11:16                 ` Krzysztof Kozlowski
2022-11-21 11:16                 ` Krzysztof Kozlowski
2022-11-21 13:50                 ` Laurent Pinchart
2022-11-21 13:50                   ` Laurent Pinchart
2022-11-21 13:50                   ` Laurent Pinchart
2022-11-21 16:37                   ` Krzysztof Kozlowski
2022-11-21 16:37                     ` Krzysztof Kozlowski
2022-11-21 16:37                     ` Krzysztof Kozlowski
2022-11-21 16:39                     ` Krzysztof Kozlowski
2022-11-21 16:39                       ` Krzysztof Kozlowski
2022-11-21 16:39                       ` Krzysztof Kozlowski
2022-11-21 16:48                     ` Laurent Pinchart
2022-11-21 16:48                       ` Laurent Pinchart
2022-11-21 16:48                       ` Laurent Pinchart
2022-11-19 16:59     ` Laurent Pinchart
2022-11-19 16:59       ` Laurent Pinchart
2022-11-19 16:59       ` Laurent Pinchart
2022-11-20 10:34       ` Krzysztof Kozlowski
2022-11-20 10:34         ` Krzysztof Kozlowski
2022-11-20 10:34         ` Krzysztof Kozlowski
2022-11-18 13:31   ` Rob Herring
2022-11-18 13:31     ` Rob Herring
2022-11-18 13:31     ` Rob Herring
2022-11-19  6:33     ` Paul Elder
2022-11-19  6:33       ` Paul Elder
2022-11-19  6:33       ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 03/14] media: rkisp1: Add and use rkisp1_has_feature() macro Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-19 11:03   ` Dafna Hirschfeld
2022-11-19 11:03     ` Dafna Hirschfeld
2022-11-19 11:03     ` Dafna Hirschfeld
2022-11-19 17:18     ` Laurent Pinchart
2022-11-19 17:18       ` Laurent Pinchart
2022-11-19 17:18       ` Laurent Pinchart
2022-11-18  9:39 ` [PATCH v3 04/14] media: rkisp1: Add match data for i.MX8MP ISP Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2023-10-18 17:41   ` Adam Ford
2023-10-18 17:41     ` Adam Ford
2023-10-18 17:41     ` Adam Ford
2022-11-18  9:39 ` [PATCH v3 05/14] media: rkisp1: Configure gasket on i.MX8MP Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 06/14] media: rkisp1: Add and set registers for crop for i.MX8MP Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 07/14] media: rkisp1: Add and set registers for output size config on i.MX8MP Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 08/14] media: rkisp1: Add i.MX8MP-specific registers for MI and resizer Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 09/14] media: rkisp1: Shift DMA buffer addresses on i.MX8MP Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 10/14] media: rkisp1: Add register definitions for the test pattern generator Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 11/14] media: rkisp1: Fix RSZ_CTRL bits for i.MX8MP Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 12/14] media: rkisp1: Support devices without self path Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 13/14] media: rkisp1: Add YC swap capability Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39 ` [PATCH v3 14/14] media: rkisp1: Add UYVY as an output format Paul Elder
2022-11-18  9:39   ` Paul Elder
2022-11-18  9:39   ` Paul Elder
     [not found] ` <CAHCN7x+9E8qcBVOQZKTKagDkvkKVnqDtjvpNX-iNFYwCLRoYug@mail.gmail.com>
2023-02-15 23:55   ` [PATCH v3 00/14] media: rkisp1: Add support for i.MX8MP Laurent Pinchart
2023-02-15 23:55     ` Laurent Pinchart
2023-02-15 23:55     ` Laurent Pinchart
2023-02-18 16:14     ` Adam Ford
2023-02-18 16:14       ` Adam Ford
2023-02-18 16:14       ` Adam Ford
2023-02-23 10:58       ` Jacopo Mondi
2023-02-23 10:58         ` Jacopo Mondi
2023-02-23 10:58         ` Jacopo Mondi
2023-02-22 23:39 ` Adam Ford
2023-02-22 23:39   ` Adam Ford
2023-02-22 23:39   ` Adam Ford
2023-02-23 13:57   ` Jacopo Mondi
2023-02-23 13:57     ` Jacopo Mondi
2023-02-23 13:57     ` Jacopo Mondi
2023-02-23 14:26   ` Laurent Pinchart
2023-02-23 14:26     ` Laurent Pinchart
2023-02-23 14:26     ` Laurent Pinchart
2023-02-23 16:10     ` Adam Ford
2023-02-23 16:10       ` Adam Ford
2023-02-23 16:10       ` Adam Ford
2023-02-23 16:25       ` Laurent Pinchart
2023-02-23 16:25         ` Laurent Pinchart
2023-02-23 16:25         ` Laurent Pinchart
2023-02-24 18:24       ` Nicolas Dufresne
2023-02-24 18:24         ` Nicolas Dufresne
2023-02-24 18:24         ` Nicolas Dufresne
2023-02-24 18:46         ` Adam Ford
2023-02-24 18:46           ` Adam Ford
2023-02-24 18:46           ` Adam Ford
2023-03-21 14:43 ` Tommaso Merciai
2023-03-21 14:43   ` Tommaso Merciai
2023-03-21 14:43   ` Tommaso Merciai
2023-07-18  8:31 ` Hans Verkuil
2023-07-18  8:31   ` Hans Verkuil
2023-07-18  8:31   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca8a6070-3888-8d42-5974-d7c2adc62417@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=dafna@fastmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=helen.koike@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=paul.elder@ideasonboard.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.