From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
tom@herbertland.com
Subject: Re: [PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow functions
Date: Fri, 2 Mar 2018 08:33:22 -0700 [thread overview]
Message-ID: <ca9e63c9-73d8-d8be-35e3-48c25eba60d4@gmail.com> (raw)
In-Reply-To: <20180302140900.GA27478@splinter>
On 3/2/18 7:09 AM, Ido Schimmel wrote:
>> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
>> index 559db9ea8d86..d29f09bc5ff9 100644
>> --- a/net/core/flow_dissector.c
>> +++ b/net/core/flow_dissector.c
>> @@ -1341,22 +1341,6 @@ __u32 __get_hash_from_flowi6(const struct flowi6 *fl6, struct flow_keys *keys)
>> }
>> EXPORT_SYMBOL(__get_hash_from_flowi6);
>>
>> -__u32 __get_hash_from_flowi4(const struct flowi4 *fl4, struct flow_keys *keys)
>
> Need to remove the declaration from include/net/flow.h
good catch. I'll add to v3.
next prev parent reply other threads:[~2018-03-02 15:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 3:29 [PATCH v2 net-next 00/10] net/ipv6: Add support for path selection using hash of 5-tuple David Ahern
2018-03-02 3:29 ` [PATCH v2 net-next 01/10] net/ipv4: Pass net to fib_multipath_hash instead of fib_info David Ahern
2018-03-02 13:12 ` Ido Schimmel
2018-03-02 15:28 ` David Ahern
2018-03-02 3:29 ` [PATCH v2 net-next 02/10] net: Align ip_multipath_l3_keys and ip6_multipath_l3_keys David Ahern
2018-03-02 13:22 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 03/10] net/ipv4: Simplify fib_multipath_hash with optional flow keys David Ahern
2018-03-02 13:26 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 04/10] net/ipv6: Make rt6_multipath_hash similar to fib_multipath_hash David Ahern
2018-03-02 13:35 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 05/10] net: Rename NETEVENT_MULTIPATH_HASH_UPDATE David Ahern
2018-03-02 13:36 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 06/10] net/ipv6: Pass skb to route lookup David Ahern
2018-03-02 13:49 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 07/10] net/ipv6: Add support for path selection using hash of 5-tuple David Ahern
2018-03-02 13:52 ` Ido Schimmel
2018-03-02 3:29 ` [PATCH v2 net-next 08/10] mlxsw: spectrum_router: Add support for ipv6 hash policy update David Ahern
2018-03-02 14:02 ` Ido Schimmel
2018-03-02 15:33 ` David Ahern
2018-03-02 3:29 ` [PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow functions David Ahern
2018-03-02 14:09 ` Ido Schimmel
2018-03-02 15:33 ` David Ahern [this message]
2018-03-02 3:29 ` [PATCH v2 net-next 10/10] selftests: forwarding: Add multipath test for L4 hashing David Ahern
2018-03-02 14:10 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca9e63c9-73d8-d8be-35e3-48c25eba60d4@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.