All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Nicolin Chen
	<nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
	ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2 0/2] Add memcpy support for tegra210-adma
Date: Tue, 6 Sep 2016 14:46:01 +0100	[thread overview]
Message-ID: <cad2c99c-3eee-3fa1-4559-e60f7f4a22c7@nvidia.com> (raw)
In-Reply-To: <6f45ff6e-5fa7-7aca-154c-85cf235aa62f-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>


On 06/09/16 14:04, Jon Hunter wrote:
> 
> On 06/09/16 13:03, Dmitry Osipenko wrote:
>> On 06.09.2016 14:33, Jon Hunter wrote:
>>>
>>> On 03/09/16 01:32, Nicolin Chen wrote:
>>>> This series of patches add memcpy support for tegra210 ADMA engine.
>>>
>>> Thanks. Any reason you choose this DMA and not the APB DMA? The APB DMA
>>> is more of a generic DMA and so for memcpy it would seem to be a good
>>> choice and it is available on all Tegras not just Tegra210.
>>>
>>
>> Just a small clarification:
>>
>> If I'm not mistaken, APB DMA is mem-to-device, while AHB DMA is mem-to-mem. So,
>> you probably meant AHB and not the APB.
> 
> Description from the Tegra TRM:
> 
> "The APB DMA Controller is placed between the AHB Bus and the APB Bus
> and is a master on both buses.
> 
> The APB DMA Controller is used for block data transfers from a source
> location to the destination location. The source may be
> DRAM or IRAM, and the destination location could be devices placed on
> APB Bus; or vice versa."

Sorry this appears to be a completely worthless response :-(

I had made the assumption that if the DMA can transfer from APB-to-AHB
and AHB-to-APB, it could also do AHB to AHB. However, now I look closely
at the registers I see that it cannot and therefore, cannot support
memcpy at all! Ok, so ignore my comment here, as it appears only the
ADMA can support memcpy. Weird.

Jon

-- 
nvpublic

WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>, <vinod.koul@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<dmaengine@vger.kernel.org>, <gnurou@gmail.com>,
	<thierry.reding@gmail.com>, <swarren@wwwdotorg.org>,
	<ldewangan@nvidia.com>
Subject: Re: [PATCH v2 0/2] Add memcpy support for tegra210-adma
Date: Tue, 6 Sep 2016 14:46:01 +0100	[thread overview]
Message-ID: <cad2c99c-3eee-3fa1-4559-e60f7f4a22c7@nvidia.com> (raw)
In-Reply-To: <6f45ff6e-5fa7-7aca-154c-85cf235aa62f@nvidia.com>


On 06/09/16 14:04, Jon Hunter wrote:
> 
> On 06/09/16 13:03, Dmitry Osipenko wrote:
>> On 06.09.2016 14:33, Jon Hunter wrote:
>>>
>>> On 03/09/16 01:32, Nicolin Chen wrote:
>>>> This series of patches add memcpy support for tegra210 ADMA engine.
>>>
>>> Thanks. Any reason you choose this DMA and not the APB DMA? The APB DMA
>>> is more of a generic DMA and so for memcpy it would seem to be a good
>>> choice and it is available on all Tegras not just Tegra210.
>>>
>>
>> Just a small clarification:
>>
>> If I'm not mistaken, APB DMA is mem-to-device, while AHB DMA is mem-to-mem. So,
>> you probably meant AHB and not the APB.
> 
> Description from the Tegra TRM:
> 
> "The APB DMA Controller is placed between the AHB Bus and the APB Bus
> and is a master on both buses.
> 
> The APB DMA Controller is used for block data transfers from a source
> location to the destination location. The source may be
> DRAM or IRAM, and the destination location could be devices placed on
> APB Bus; or vice versa."

Sorry this appears to be a completely worthless response :-(

I had made the assumption that if the DMA can transfer from APB-to-AHB
and AHB-to-APB, it could also do AHB to AHB. However, now I look closely
at the registers I see that it cannot and therefore, cannot support
memcpy at all! Ok, so ignore my comment here, as it appears only the
ADMA can support memcpy. Weird.

Jon

-- 
nvpublic

  parent reply	other threads:[~2016-09-06 13:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-03  0:32 [PATCH v2 0/2] Add memcpy support for tegra210-adma Nicolin Chen
2016-09-03  0:32 ` [PATCH v2 1/2] dmaengine: tegra210-adma: Add pre-check for cyclic callback Nicolin Chen
     [not found] ` <cover.1472857934.git.nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-03  0:32   ` [PATCH v2 2/2] dmaengine: tegra210-adma: Add memcpy support Nicolin Chen
2016-09-03  0:32     ` Nicolin Chen
     [not found]     ` <738e0f1560436d613d9a7dab2fd540abea9503d3.1472857934.git.nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-06 11:52       ` Jon Hunter
2016-09-06 11:52         ` Jon Hunter
     [not found]         ` <f9850c0c-a4a9-4d5f-eaa9-c1fd39b72870-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-06 17:21           ` Nicolin Chen
2016-09-06 17:21             ` Nicolin Chen
2016-09-06 11:33   ` [PATCH v2 0/2] Add memcpy support for tegra210-adma Jon Hunter
2016-09-06 11:33     ` Jon Hunter
     [not found]     ` <319ca097-4b10-83b9-841c-52adccbb48ad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-06 12:03       ` Dmitry Osipenko
2016-09-06 12:03         ` Dmitry Osipenko
2016-09-06 13:04         ` Jon Hunter
2016-09-06 13:04           ` Jon Hunter
     [not found]           ` <6f45ff6e-5fa7-7aca-154c-85cf235aa62f-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-06 13:46             ` Jon Hunter [this message]
2016-09-06 13:46               ` Jon Hunter
2016-09-06 14:27               ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cad2c99c-3eee-3fa1-4559-e60f7f4a22c7@nvidia.com \
    --to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.