All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][RESEND] block: copy ioprio in __bio_clone_fast()
@ 2018-02-26 13:29 Hannes Reinecke
  2018-02-26 16:06 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2018-02-26 13:29 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-block, Mike Christie, Hannes Reinecke, Hannes Reinecke

We need to copy the io priority, too; otherwise the clone will run
with a different priority than the original one.

Fixes: 43b62ce3ff0a ("block: move bio io prio to a new field")
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
 block/bio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/bio.c b/block/bio.c
index e1708db48258..e079911c640f 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -605,6 +605,7 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
 	bio->bi_write_hint = bio_src->bi_write_hint;
 	bio->bi_iter = bio_src->bi_iter;
 	bio->bi_io_vec = bio_src->bi_io_vec;
+	bio->bi_ioprio = bio_src->bi_ioprio;
 
 	bio_clone_blkcg_association(bio, bio_src);
 }
-- 
2.12.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][RESEND] block: copy ioprio in __bio_clone_fast()
  2018-02-26 13:29 [PATCH][RESEND] block: copy ioprio in __bio_clone_fast() Hannes Reinecke
@ 2018-02-26 16:06 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-02-26 16:06 UTC (permalink / raw)
  To: Hannes Reinecke; +Cc: linux-block, Mike Christie, Hannes Reinecke

On 2/26/18 6:29 AM, Hannes Reinecke wrote:
> We need to copy the io priority, too; otherwise the clone will run
> with a different priority than the original one.

What about bio_clone_bioset()?

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-26 16:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 13:29 [PATCH][RESEND] block: copy ioprio in __bio_clone_fast() Hannes Reinecke
2018-02-26 16:06 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.