All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/1] tests/kms_rotation_crc: multiplane-rotation* faster
@ 2019-04-03 19:11 Caz Yokoyama
  2019-04-03 20:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
  2019-04-26 17:26 ` [igt-dev] [PATCH i-g-t 1/1] " Caz Yokoyama
  0 siblings, 2 replies; 4+ messages in thread
From: Caz Yokoyama @ 2019-04-03 19:11 UTC (permalink / raw)
  To: igt-dev

by rotating 1/4 of data.

The test rotated 20% horizontally, 40% vertically of 1920x1200 display
plane. This patch makes them 10% and 20% respectively.

paint_squares(), igt_display_try_commit2() and igt_pipe_crc_current()
consume 99% of whole test. By this patch, paint_squares() and
igt_display_try_commit2() run 42% faster. Remaining igt_pipe_crc_current()
runs same because it is synchronized with vsync.
multiplane-rotation-cropping-bottom sub test runs 22% faster.

Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/kms_rotation_crc.c | 48 ++++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index fc995d07..e0ba83da 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -534,18 +534,18 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
 		float_t height;
 		uint64_t tiling;
 	} planeconfigs[] = {
-	{IGT_ROTATION_0, .2f, .4f, LOCAL_DRM_FORMAT_MOD_NONE },
-	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_X_TILED },
-	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
-	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
-	{IGT_ROTATION_90, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
-	{IGT_ROTATION_90, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
-	{IGT_ROTATION_180, .2f, .4f, LOCAL_DRM_FORMAT_MOD_NONE },
-	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_X_TILED },
-	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
-	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
-	{IGT_ROTATION_270, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
-	{IGT_ROTATION_270, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
+	{IGT_ROTATION_0, .1f, .2f, LOCAL_DRM_FORMAT_MOD_NONE },
+	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_X_TILED },
+	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
+	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
+	{IGT_ROTATION_90, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
+	{IGT_ROTATION_90, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
+	{IGT_ROTATION_180, .1f, .2f, LOCAL_DRM_FORMAT_MOD_NONE },
+	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_X_TILED },
+	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
+	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
+	{IGT_ROTATION_270, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
+	{IGT_ROTATION_270, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
 	};
 
 	/*
@@ -842,11 +842,11 @@ igt_main
 		igt_require(gen >= 9);
 		cleanup_crtc(&data);
 		data.planepos[0].origo = p_top | p_left;
-		data.planepos[0].x = .2f;
-		data.planepos[0].y = .1f;
+		data.planepos[0].x = .1f;
+		data.planepos[0].y = .05f;
 		data.planepos[1].origo = p_top | p_right;
-		data.planepos[1].x = -.4f;
-		data.planepos[1].y = .1f;
+		data.planepos[1].x = -.2f;
+		data.planepos[1].y = .05f;
 		test_multi_plane_rotation(&data, 0);
 	}
 
@@ -854,11 +854,11 @@ igt_main
 		igt_require(gen >= 9);
 		cleanup_crtc(&data);
 		data.planepos[0].origo = p_top | p_left;
-		data.planepos[0].x = -.05f;
-		data.planepos[0].y = -.15f;
+		data.planepos[0].x = -.025f;
+		data.planepos[0].y = -.075f;
 		data.planepos[1].origo = p_top | p_right;
-		data.planepos[1].x = -.15f;
-		data.planepos[1].y = -.15f;
+		data.planepos[1].x = -.075f;
+		data.planepos[1].y = -.075f;
 		test_multi_plane_rotation(&data, 0);
 	}
 
@@ -866,11 +866,11 @@ igt_main
 		igt_require(gen >= 9);
 		cleanup_crtc(&data);
 		data.planepos[0].origo = p_bottom | p_left;
-		data.planepos[0].x = -.05f;
-		data.planepos[0].y = -.20f;
+		data.planepos[0].x = -.025f;
+		data.planepos[0].y = -.10f;
 		data.planepos[1].origo = p_bottom | p_right;
-		data.planepos[1].x = -.15f;
-		data.planepos[1].y = -.20f;
+		data.planepos[1].x = -.075f;
+		data.planepos[1].y = -.10f;
 		test_multi_plane_rotation(&data, 0);
 	}
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] tests/kms_rotation_crc: multiplane-rotation* faster
  2019-04-03 19:11 [igt-dev] [PATCH i-g-t 1/1] tests/kms_rotation_crc: multiplane-rotation* faster Caz Yokoyama
@ 2019-04-03 20:25 ` Patchwork
  2019-04-26 17:26 ` [igt-dev] [PATCH i-g-t 1/1] " Caz Yokoyama
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-03 20:25 UTC (permalink / raw)
  To: Caz Yokoyama; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/1] tests/kms_rotation_crc: multiplane-rotation* faster
URL   : https://patchwork.freedesktop.org/series/58964/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5866 -> IGTPW_2780
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_2780 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2780, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58964/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2780:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_hangcheck:
    - fi-ilk-650:         PASS -> INCOMPLETE

  
Known issues
------------

  Here are the changes found in IGTPW_2780 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-compute:
    - fi-kbl-8809g:       NOTRUN -> FAIL [fdo#108094]

  * igt@amdgpu/amd_basic@semaphore:
    - fi-kbl-7500u:       NOTRUN -> SKIP [fdo#109271] +28

  * igt@amdgpu/amd_cs_nop@fork-compute0:
    - fi-icl-y:           NOTRUN -> SKIP [fdo#109315] +17

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-u2:          PASS -> INCOMPLETE [fdo#107713]
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      PASS -> FAIL [fdo#108511]

  * igt@i915_selftest@live_contexts:
    - fi-icl-y:           NOTRUN -> DMESG-FAIL [fdo#108569]

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7500u:       NOTRUN -> DMESG-WARN [fdo#102505] / [fdo#103558] / [fdo#105079] / [fdo#105602]

  * igt@kms_chamelium@dp-crc-fast:
    - fi-icl-y:           NOTRUN -> SKIP [fdo#109284] +8

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-icl-y:           NOTRUN -> SKIP [fdo#109285] +3

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362] +1

  * igt@kms_psr@primary_mmap_gtt:
    - fi-icl-y:           NOTRUN -> SKIP [fdo#110189] +3

  * igt@prime_vgem@basic-fence-flip:
    - fi-icl-y:           NOTRUN -> SKIP [fdo#109294]

  
#### Possible fixes ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       DMESG-WARN [fdo#108965] -> PASS

  * igt@gem_render_linear_blits@basic:
    - fi-icl-y:           INCOMPLETE -> PASS

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      DMESG-FAIL [fdo#110235 ] -> PASS

  * igt@i915_selftest@live_uncore:
    - fi-skl-gvtdvm:      DMESG-FAIL [fdo#110210] -> PASS

  * igt@kms_addfb_basic@bad-pitch-256:
    - {fi-icl-u3}:        DMESG-WARN [fdo#107724] -> PASS

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       DMESG-WARN [fdo#103841] -> PASS

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
  [fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
  [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 


Participating hosts (50 -> 43)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-dsi fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4925 -> IGTPW_2780

  CI_DRM_5866: a671a33f4de8d94da08654201b383b761caed7d5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2780: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2780/
  IGT_4925: ca623acb8b2b6f0a4cdb01946dc9002e11d62574 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2780/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/1] tests/kms_rotation_crc: multiplane-rotation* faster
  2019-04-03 19:11 [igt-dev] [PATCH i-g-t 1/1] tests/kms_rotation_crc: multiplane-rotation* faster Caz Yokoyama
  2019-04-03 20:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
@ 2019-04-26 17:26 ` Caz Yokoyama
  2019-04-29  9:33   ` Jani Nikula
  1 sibling, 1 reply; 4+ messages in thread
From: Caz Yokoyama @ 2019-04-26 17:26 UTC (permalink / raw)
  To: igt-dev

Drop because nobody respond. Maybe because of one of
- 42% faster has no value
- the patch breaks purpose of the test.
-caz

On Wed, 2019-04-03 at 12:11 -0700, Caz Yokoyama wrote:
> by rotating 1/4 of data.
> 
> The test rotated 20% horizontally, 40% vertically of 1920x1200
> display
> plane. This patch makes them 10% and 20% respectively.
> 
> paint_squares(), igt_display_try_commit2() and igt_pipe_crc_current()
> consume 99% of whole test. By this patch, paint_squares() and
> igt_display_try_commit2() run 42% faster. Remaining
> igt_pipe_crc_current()
> runs same because it is synchronized with vsync.
> multiplane-rotation-cropping-bottom sub test runs 22% faster.
> 
> Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/kms_rotation_crc.c | 48 ++++++++++++++++++++----------------
> ----
>  1 file changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index fc995d07..e0ba83da 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -534,18 +534,18 @@ static void test_multi_plane_rotation(data_t
> *data, enum pipe pipe)
>  		float_t height;
>  		uint64_t tiling;
>  	} planeconfigs[] = {
> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_DRM_FORMAT_MOD_NONE },
> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_X_TILED },
> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
> -	{IGT_ROTATION_90, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> -	{IGT_ROTATION_90, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_DRM_FORMAT_MOD_NONE },
> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_X_TILED },
> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
> -	{IGT_ROTATION_270, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> -	{IGT_ROTATION_270, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_DRM_FORMAT_MOD_NONE },
> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_X_TILED },
> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
> +	{IGT_ROTATION_90, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> +	{IGT_ROTATION_90, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_DRM_FORMAT_MOD_NONE },
> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_X_TILED },
> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
> +	{IGT_ROTATION_270, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
> +	{IGT_ROTATION_270, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>  	};
>  
>  	/*
> @@ -842,11 +842,11 @@ igt_main
>  		igt_require(gen >= 9);
>  		cleanup_crtc(&data);
>  		data.planepos[0].origo = p_top | p_left;
> -		data.planepos[0].x = .2f;
> -		data.planepos[0].y = .1f;
> +		data.planepos[0].x = .1f;
> +		data.planepos[0].y = .05f;
>  		data.planepos[1].origo = p_top | p_right;
> -		data.planepos[1].x = -.4f;
> -		data.planepos[1].y = .1f;
> +		data.planepos[1].x = -.2f;
> +		data.planepos[1].y = .05f;
>  		test_multi_plane_rotation(&data, 0);
>  	}
>  
> @@ -854,11 +854,11 @@ igt_main
>  		igt_require(gen >= 9);
>  		cleanup_crtc(&data);
>  		data.planepos[0].origo = p_top | p_left;
> -		data.planepos[0].x = -.05f;
> -		data.planepos[0].y = -.15f;
> +		data.planepos[0].x = -.025f;
> +		data.planepos[0].y = -.075f;
>  		data.planepos[1].origo = p_top | p_right;
> -		data.planepos[1].x = -.15f;
> -		data.planepos[1].y = -.15f;
> +		data.planepos[1].x = -.075f;
> +		data.planepos[1].y = -.075f;
>  		test_multi_plane_rotation(&data, 0);
>  	}
>  
> @@ -866,11 +866,11 @@ igt_main
>  		igt_require(gen >= 9);
>  		cleanup_crtc(&data);
>  		data.planepos[0].origo = p_bottom | p_left;
> -		data.planepos[0].x = -.05f;
> -		data.planepos[0].y = -.20f;
> +		data.planepos[0].x = -.025f;
> +		data.planepos[0].y = -.10f;
>  		data.planepos[1].origo = p_bottom | p_right;
> -		data.planepos[1].x = -.15f;
> -		data.planepos[1].y = -.20f;
> +		data.planepos[1].x = -.075f;
> +		data.planepos[1].y = -.10f;
>  		test_multi_plane_rotation(&data, 0);
>  	}
>  

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/1] tests/kms_rotation_crc: multiplane-rotation* faster
  2019-04-26 17:26 ` [igt-dev] [PATCH i-g-t 1/1] " Caz Yokoyama
@ 2019-04-29  9:33   ` Jani Nikula
  0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2019-04-29  9:33 UTC (permalink / raw)
  To: Caz Yokoyama, igt-dev

On Fri, 26 Apr 2019, Caz Yokoyama <Caz.Yokoyama@intel.com> wrote:
> Drop because nobody respond. Maybe because of one of
> - 42% faster has no value
> - the patch breaks purpose of the test.
> -caz

Or just maybe because there are 1000+ posts on the list per month,
everyone is busy, and the commit message could be clearer about what the
tradeoff is to make the test faster?

If nobody responds within a week or two, please ping for reviews either
on the list or on freenode #intel-gfx IRC channel. Or both. Please don't
just silently wait and build up frustration/anger when it could simply
be that the patch slipped through the cracks.


BR,
Jani.


>
> On Wed, 2019-04-03 at 12:11 -0700, Caz Yokoyama wrote:
>> by rotating 1/4 of data.
>> 
>> The test rotated 20% horizontally, 40% vertically of 1920x1200
>> display
>> plane. This patch makes them 10% and 20% respectively.
>> 
>> paint_squares(), igt_display_try_commit2() and igt_pipe_crc_current()
>> consume 99% of whole test. By this patch, paint_squares() and
>> igt_display_try_commit2() run 42% faster. Remaining
>> igt_pipe_crc_current()
>> runs same because it is synchronized with vsync.
>> multiplane-rotation-cropping-bottom sub test runs 22% faster.
>> 
>> Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>>  tests/kms_rotation_crc.c | 48 ++++++++++++++++++++----------------
>> ----
>>  1 file changed, 24 insertions(+), 24 deletions(-)
>> 
>> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
>> index fc995d07..e0ba83da 100644
>> --- a/tests/kms_rotation_crc.c
>> +++ b/tests/kms_rotation_crc.c
>> @@ -534,18 +534,18 @@ static void test_multi_plane_rotation(data_t
>> *data, enum pipe pipe)
>>  		float_t height;
>>  		uint64_t tiling;
>>  	} planeconfigs[] = {
>> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_DRM_FORMAT_MOD_NONE },
>> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_X_TILED },
>> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> -	{IGT_ROTATION_0, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>> -	{IGT_ROTATION_90, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> -	{IGT_ROTATION_90, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_DRM_FORMAT_MOD_NONE },
>> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_X_TILED },
>> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> -	{IGT_ROTATION_180, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>> -	{IGT_ROTATION_270, .2f, .4f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> -	{IGT_ROTATION_270, .2f, .4f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_DRM_FORMAT_MOD_NONE },
>> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_X_TILED },
>> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> +	{IGT_ROTATION_0, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>> +	{IGT_ROTATION_90, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> +	{IGT_ROTATION_90, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_DRM_FORMAT_MOD_NONE },
>> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_X_TILED },
>> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> +	{IGT_ROTATION_180, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>> +	{IGT_ROTATION_270, .1f, .2f, LOCAL_I915_FORMAT_MOD_Y_TILED },
>> +	{IGT_ROTATION_270, .1f, .2f, LOCAL_I915_FORMAT_MOD_Yf_TILED },
>>  	};
>>  
>>  	/*
>> @@ -842,11 +842,11 @@ igt_main
>>  		igt_require(gen >= 9);
>>  		cleanup_crtc(&data);
>>  		data.planepos[0].origo = p_top | p_left;
>> -		data.planepos[0].x = .2f;
>> -		data.planepos[0].y = .1f;
>> +		data.planepos[0].x = .1f;
>> +		data.planepos[0].y = .05f;
>>  		data.planepos[1].origo = p_top | p_right;
>> -		data.planepos[1].x = -.4f;
>> -		data.planepos[1].y = .1f;
>> +		data.planepos[1].x = -.2f;
>> +		data.planepos[1].y = .05f;
>>  		test_multi_plane_rotation(&data, 0);
>>  	}
>>  
>> @@ -854,11 +854,11 @@ igt_main
>>  		igt_require(gen >= 9);
>>  		cleanup_crtc(&data);
>>  		data.planepos[0].origo = p_top | p_left;
>> -		data.planepos[0].x = -.05f;
>> -		data.planepos[0].y = -.15f;
>> +		data.planepos[0].x = -.025f;
>> +		data.planepos[0].y = -.075f;
>>  		data.planepos[1].origo = p_top | p_right;
>> -		data.planepos[1].x = -.15f;
>> -		data.planepos[1].y = -.15f;
>> +		data.planepos[1].x = -.075f;
>> +		data.planepos[1].y = -.075f;
>>  		test_multi_plane_rotation(&data, 0);
>>  	}
>>  
>> @@ -866,11 +866,11 @@ igt_main
>>  		igt_require(gen >= 9);
>>  		cleanup_crtc(&data);
>>  		data.planepos[0].origo = p_bottom | p_left;
>> -		data.planepos[0].x = -.05f;
>> -		data.planepos[0].y = -.20f;
>> +		data.planepos[0].x = -.025f;
>> +		data.planepos[0].y = -.10f;
>>  		data.planepos[1].origo = p_bottom | p_right;
>> -		data.planepos[1].x = -.15f;
>> -		data.planepos[1].y = -.20f;
>> +		data.planepos[1].x = -.075f;
>> +		data.planepos[1].y = -.10f;
>>  		test_multi_plane_rotation(&data, 0);
>>  	}
>>  
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-29  9:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03 19:11 [igt-dev] [PATCH i-g-t 1/1] tests/kms_rotation_crc: multiplane-rotation* faster Caz Yokoyama
2019-04-03 20:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
2019-04-26 17:26 ` [igt-dev] [PATCH i-g-t 1/1] " Caz Yokoyama
2019-04-29  9:33   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.