All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gong <wgong@codeaurora.org>
To: vnaralas@codeaurora.org
Cc: johannes@sipsolutions.net, ath11k@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	wgong=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v5] cfg80211: save power spectral density(psd) of regulatory rule
Date: Wed, 29 Sep 2021 11:37:17 +0800	[thread overview]
Message-ID: <cb20427eae96c4551084e4c899618b94@codeaurora.org> (raw)
In-Reply-To: <bd649a3d2cf2ea9064d427d633055891@codeaurora.org>

On 2021-09-28 21:12, vnaralas@codeaurora.org wrote:
> On 2021-09-28 14:22, Wen Gong wrote:
>> 6 GHz regulatory domains introduces power spectral density(psd).
>> The power spectral density(psd) of regulatory rule should be take
>> effect to the channels. Save the values to the channel which has
>> psd value and add nl80211 attributes for it.
>> 
>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>> ---
...
>> 
>> @@ -2540,6 +2554,9 @@ static void handle_channel_custom(struct wiphy 
>> *wiphy,
>>  			chan->dfs_cac_ms = IEEE80211_DFS_MIN_CAC_TIME_MS;
>>  	}
>> 
>> +	if (chan->flags & IEEE80211_CHAN_PSD)
>> +		chan->psd = reg_rule->psd;
>> +
>>  	chan->max_power = chan->max_reg_power;
> 
> What about the case AP + STA concurrency? are we going to overwrite
> the PSD power and channel flags?
> 

Hi Venkateswara,

This patch is not relation with AP + STA concurrency.
For example, it also has other power intersection in 
handle_channel_adjacent_rules().

		chan->max_reg_power =
			min_t(int, MBM_TO_DBM(power_rule1->max_eirp),
			      MBM_TO_DBM(power_rule2->max_eirp));

For AP + STA concurrency, it should to maintain 2 group of reg rules, 
one is for AP, another is for STA.
This patch is to handle PSD info in the same reg rules.
It is to process only one reg rule in the reg rules.
AP + STA concurrency is a higher level things than this patch.
>>  }

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: vnaralas@codeaurora.org
Cc: johannes@sipsolutions.net, ath11k@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	wgong=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v5] cfg80211: save power spectral density(psd) of regulatory rule
Date: Wed, 29 Sep 2021 11:37:17 +0800	[thread overview]
Message-ID: <cb20427eae96c4551084e4c899618b94@codeaurora.org> (raw)
In-Reply-To: <bd649a3d2cf2ea9064d427d633055891@codeaurora.org>

On 2021-09-28 21:12, vnaralas@codeaurora.org wrote:
> On 2021-09-28 14:22, Wen Gong wrote:
>> 6 GHz regulatory domains introduces power spectral density(psd).
>> The power spectral density(psd) of regulatory rule should be take
>> effect to the channels. Save the values to the channel which has
>> psd value and add nl80211 attributes for it.
>> 
>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>> ---
...
>> 
>> @@ -2540,6 +2554,9 @@ static void handle_channel_custom(struct wiphy 
>> *wiphy,
>>  			chan->dfs_cac_ms = IEEE80211_DFS_MIN_CAC_TIME_MS;
>>  	}
>> 
>> +	if (chan->flags & IEEE80211_CHAN_PSD)
>> +		chan->psd = reg_rule->psd;
>> +
>>  	chan->max_power = chan->max_reg_power;
> 
> What about the case AP + STA concurrency? are we going to overwrite
> the PSD power and channel flags?
> 

Hi Venkateswara,

This patch is not relation with AP + STA concurrency.
For example, it also has other power intersection in 
handle_channel_adjacent_rules().

		chan->max_reg_power =
			min_t(int, MBM_TO_DBM(power_rule1->max_eirp),
			      MBM_TO_DBM(power_rule2->max_eirp));

For AP + STA concurrency, it should to maintain 2 group of reg rules, 
one is for AP, another is for STA.
This patch is to handle PSD info in the same reg rules.
It is to process only one reg rule in the reg rules.
AP + STA concurrency is a higher level things than this patch.
>>  }

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2021-09-29  3:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  8:52 [PATCH v5] cfg80211: save power spectral density(psd) of regulatory rule Wen Gong
2021-09-28  8:52 ` Wen Gong
2021-09-28 13:12 ` vnaralas
2021-09-28 13:12   ` vnaralas
2021-09-29  3:37   ` Wen Gong [this message]
2021-09-29  3:37     ` Wen Gong
2021-09-29 16:46     ` Venkateswara Naralasetty
2021-09-29 16:46       ` Venkateswara Naralasetty
2021-09-30  2:53       ` Wen Gong
2021-09-30  2:53         ` Wen Gong
2021-09-30 12:50         ` Johannes Berg
2021-09-30 12:50           ` Johannes Berg
2021-10-11  4:06           ` Wen Gong
2021-10-11  4:06             ` Wen Gong
2021-10-11  6:43             ` Venkateswara Naralasetty
2021-10-11  6:43               ` Venkateswara Naralasetty
2021-10-11  7:48               ` Wen Gong
2021-10-11  7:48                 ` Wen Gong
2021-10-13  3:33                 ` Wen Gong
2021-10-13  3:33                   ` Wen Gong
2021-10-25 20:09                 ` Johannes Berg
2021-10-25 20:09                   ` Johannes Berg
2021-10-26 11:26                   ` Wen Gong
2021-10-26 11:26                     ` Wen Gong
2021-11-09  9:57                     ` Wen Gong
2021-11-09  9:57                       ` Wen Gong
2021-12-06  8:48                       ` Wen Gong
2021-12-06  8:48                         ` Wen Gong
2022-03-03  2:13                         ` Wen Gong
2022-03-03  2:13                           ` Wen Gong
2022-04-15  2:27                           ` Wen Gong
2022-04-15  2:27                             ` Wen Gong
2022-05-04 12:00                             ` Johannes Berg
2022-05-04 12:00                               ` Johannes Berg
2022-05-06 10:50                               ` Wen Gong
2022-05-06 10:50                                 ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb20427eae96c4551084e4c899618b94@codeaurora.org \
    --to=wgong@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vnaralas@codeaurora.org \
    --cc=wgong=codeaurora.org@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.