All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Vladimir Neyelov
	<vladimirn-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-next] IB/iser: Fix connection teardown race condition
Date: Sat, 22 Jul 2017 13:17:01 -0400	[thread overview]
Message-ID: <cb84b7c0-7347-74cc-db23-0cff4504cb1a@redhat.com> (raw)
In-Reply-To: <fa976fe5-be25-1c6a-5997-8fa7524e89d8-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 737 bytes --]

On 5/30/2017 7:50 AM, Sagi Grimberg wrote:
> 
>> Hi Sagi,
>>
>> what do you think on this approach ?
>> we must somehow defend on the NULL deref in case dd_data in iscsi_conn
>> (the iser_conn) already NULL due to conn_stop call.
> 
> Sounds like we get conn_stop duing lun scanning. Generally speaking I
> don't like a global lock for this, but given the non trivial iscsi state
> machine
> we can do with that.
> 
> Reviewed-by: Sagi Grimberg <sagi-egDjqUIXVlxBDLzU/O5InQ@public.gmane.org>

This patch was accepted into 4.13-rc, thanks.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Doug Ledford <dledford@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>,
	Max Gurtovoy <maxg@mellanox.com>,
	Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org,
	Vladimir Neyelov <vladimirn@mellanox.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH rdma-next] IB/iser: Fix connection teardown race condition
Date: Sat, 22 Jul 2017 13:17:01 -0400	[thread overview]
Message-ID: <cb84b7c0-7347-74cc-db23-0cff4504cb1a@redhat.com> (raw)
In-Reply-To: <fa976fe5-be25-1c6a-5997-8fa7524e89d8@grimberg.me>


[-- Attachment #1.1: Type: text/plain, Size: 679 bytes --]

On 5/30/2017 7:50 AM, Sagi Grimberg wrote:
> 
>> Hi Sagi,
>>
>> what do you think on this approach ?
>> we must somehow defend on the NULL deref in case dd_data in iscsi_conn
>> (the iser_conn) already NULL due to conn_stop call.
> 
> Sounds like we get conn_stop duing lun scanning. Generally speaking I
> don't like a global lock for this, but given the non trivial iscsi state
> machine
> we can do with that.
> 
> Reviewed-by: Sagi Grimberg <sagi@grimbeg.me>

This patch was accepted into 4.13-rc, thanks.

-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  parent reply	other threads:[~2017-07-22 17:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-21 16:17 [PATCH rdma-next] IB/iser: Fix connection teardown race condition Leon Romanovsky
2017-05-21 16:17 ` Leon Romanovsky
2017-05-25 15:24 ` Max Gurtovoy
2017-05-25 15:24   ` Max Gurtovoy
2017-05-30 11:50   ` Sagi Grimberg
     [not found]     ` <fa976fe5-be25-1c6a-5997-8fa7524e89d8-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-22 17:17       ` Doug Ledford [this message]
2017-07-22 17:17         ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb84b7c0-7347-74cc-db23-0cff4504cb1a@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    --cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vladimirn-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.