From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai3@huawei.com>, tj@kernel.org, bo.liu@linux.alibaba.com
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH] blk-iolatency: error out if blk_get_queue() failed in iolatency_set_limit()
Date: Thu, 5 Aug 2021 11:18:29 -0600 [thread overview]
Message-ID: <cb9833b1-be92-1b52-86cb-a45a85b18c00@kernel.dk> (raw)
In-Reply-To: <20210805124645.543797-1-yukuai3@huawei.com>
On 8/5/21 6:46 AM, Yu Kuai wrote:
> If queue is dying while iolatency_set_limit() is in progress,
> blk_get_queue() won't increment the refcount of the queue. However,
> blk_put_queue() will still decrement the refcount later, which will
> cause the refcout to be unbalanced.
>
> Thus error out in such case to fix the problem.
Applied, thanks.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
To: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
bo.liu-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] blk-iolatency: error out if blk_get_queue() failed in iolatency_set_limit()
Date: Thu, 5 Aug 2021 11:18:29 -0600 [thread overview]
Message-ID: <cb9833b1-be92-1b52-86cb-a45a85b18c00@kernel.dk> (raw)
In-Reply-To: <20210805124645.543797-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On 8/5/21 6:46 AM, Yu Kuai wrote:
> If queue is dying while iolatency_set_limit() is in progress,
> blk_get_queue() won't increment the refcount of the queue. However,
> blk_put_queue() will still decrement the refcount later, which will
> cause the refcout to be unbalanced.
>
> Thus error out in such case to fix the problem.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-08-05 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 12:46 [PATCH] blk-iolatency: error out if blk_get_queue() failed in iolatency_set_limit() Yu Kuai
2021-08-05 12:46 ` Yu Kuai
2021-08-05 17:17 ` Tejun Heo
2021-08-05 17:17 ` Tejun Heo
2021-08-05 17:18 ` Jens Axboe [this message]
2021-08-05 17:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb9833b1-be92-1b52-86cb-a45a85b18c00@kernel.dk \
--to=axboe@kernel.dk \
--cc=bo.liu@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.