[PATCH] tcg/tci: Fix MemOpIdx operand index for 3-operand memops

[PATCH] tcg/tci: Fix MemOpIdx operand index for 3-operand memops

[Richard Henderson]

Cut and paste error from the 4-operand memops.

Fixes: ab64da797740 ("tcg/tci: Adjust passing of MemOpIdx")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/tci/tcg-target.c.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 0037f904f1..253f27f174 100644
--- a/tcg/tci/tcg-target.c.inc
+++ b/tcg/tci/tcg-target.c.inc
@@ -847,7 +847,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
         if (TCG_TARGET_REG_BITS == 64) {
             tcg_out_op_rrm(s, opc, args[0], args[1], args[2]);
         } else {
-            tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_TMP, args[4]);
+            tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_TMP, args[3]);
             tcg_out_op_rrrr(s, opc, args[0], args[1], args[2], TCG_REG_TMP);
         }
         break;
-- 
2.34.1

Re: [PATCH] tcg/tci: Fix MemOpIdx operand index for 3-operand memops

[Philippe Mathieu-Daudé]

On 8/6/23 18:29, Richard Henderson wrote:
> Cut and paste error from the 4-operand memops.
> 
> Fixes: ab64da797740 ("tcg/tci: Adjust passing of MemOpIdx")

I had this patch tagged for review but you were quicker
(not sure I'd have caught the issue although)

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/tci/tcg-target.c.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] tcg/tci: Fix MemOpIdx operand index for 3-operand memops

[Richard Henderson]

On 6/8/23 09:58, Philippe Mathieu-Daudé wrote:
> On 8/6/23 18:29, Richard Henderson wrote:
>> Cut and paste error from the 4-operand memops.
>>
>> Fixes: ab64da797740 ("tcg/tci: Adjust passing of MemOpIdx")
> 
> I had this patch tagged for review but you were quicker
> (not sure I'd have caught the issue although)
> 
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   tcg/tci/tcg-target.c.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> 

Applied to master, though it hasn't completely greened the board.


r~