All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Andreas Kemnade <andreas@kemnade.info>,
	robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] ARM: dts: imx6sll: fixup of operating points
Date: Fri, 24 Sep 2021 10:18:12 +0200	[thread overview]
Message-ID: <cbb414bd-0d6d-7ffe-0cbd-2bf747f7b219@canonical.com> (raw)
In-Reply-To: <20210923201238.2516844-4-andreas@kemnade.info>

On 23/09/2021 22:12, Andreas Kemnade wrote:
> Make operating point definitions comply with binding
> specifications.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/imx6sll.dtsi | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index 04f8d637a501..0f148f498374 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -51,20 +51,18 @@ cpu0: cpu@0 {
>  			device_type = "cpu";
>  			reg = <0>;
>  			next-level-cache = <&L2>;
> -			operating-points = <
> +			operating-points =
>  				/* kHz    uV */
> -				996000  1275000
> -				792000  1175000
> -				396000  1075000
> -				198000	975000
> -			>;
> -			fsl,soc-operating-points = <
> +				<996000  1275000>,
> +				<792000  1175000>,
> +				<396000  1075000>,
> +				<198000	975000>;

Please align this line, so I guess double space.

With the change:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Andreas Kemnade <andreas@kemnade.info>,
	robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] ARM: dts: imx6sll: fixup of operating points
Date: Fri, 24 Sep 2021 10:18:12 +0200	[thread overview]
Message-ID: <cbb414bd-0d6d-7ffe-0cbd-2bf747f7b219@canonical.com> (raw)
In-Reply-To: <20210923201238.2516844-4-andreas@kemnade.info>

On 23/09/2021 22:12, Andreas Kemnade wrote:
> Make operating point definitions comply with binding
> specifications.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/imx6sll.dtsi | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index 04f8d637a501..0f148f498374 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -51,20 +51,18 @@ cpu0: cpu@0 {
>  			device_type = "cpu";
>  			reg = <0>;
>  			next-level-cache = <&L2>;
> -			operating-points = <
> +			operating-points =
>  				/* kHz    uV */
> -				996000  1275000
> -				792000  1175000
> -				396000  1075000
> -				198000	975000
> -			>;
> -			fsl,soc-operating-points = <
> +				<996000  1275000>,
> +				<792000  1175000>,
> +				<396000  1075000>,
> +				<198000	975000>;

Please align this line, so I guess double space.

With the change:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-24  8:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 20:12 [PATCH 0/5] ARM: dts: imx6sl / imx6sll: dtbs_check errors Andreas Kemnade
2021-09-23 20:12 ` Andreas Kemnade
2021-09-23 20:12 ` [PATCH 1/5] ARM: dts: imx: e60k02: correct led node name Andreas Kemnade
2021-09-23 20:12   ` Andreas Kemnade
2021-09-24  8:16   ` Krzysztof Kozlowski
2021-09-24  8:16     ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 2/5] ARM: dts: imx6sl: fixup of operating points Andreas Kemnade
2021-09-23 20:12   ` Andreas Kemnade
2021-09-24  8:17   ` Krzysztof Kozlowski
2021-09-24  8:17     ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 3/5] ARM: dts: imx6sll: " Andreas Kemnade
2021-09-23 20:12   ` Andreas Kemnade
2021-09-24  8:18   ` Krzysztof Kozlowski [this message]
2021-09-24  8:18     ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 4/5] ARM: dts: imx6sl: fix mmc compatibles Andreas Kemnade
2021-09-23 20:12   ` Andreas Kemnade
2021-09-24  8:19   ` Krzysztof Kozlowski
2021-09-24  8:19     ` Krzysztof Kozlowski
2021-09-23 20:12 ` [PATCH 5/5] ARM: dts: imx6sll: " Andreas Kemnade
2021-09-23 20:12   ` Andreas Kemnade
2021-09-24  8:20   ` Krzysztof Kozlowski
2021-09-24  8:20     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbb414bd-0d6d-7ffe-0cbd-2bf747f7b219@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.