Re: [PATCH 05/12] xen: add hypercall interfaces for domain and cpupool parameter setting

From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH 05/12] xen: add hypercall interfaces for domain and cpupool parameter setting
Date: Wed, 26 Sep 2018 19:06:57 +0200	[thread overview]
Message-ID: <cbdeef2e94827f0ffd8a8bfb008cfbb05630f614.camel@suse.com> (raw)
In-Reply-To: <20180918060309.7186-6-jgross@suse.com>

[-- Attachment #1.1: Type: text/plain, Size: 1997 bytes --]

On Tue, 2018-09-18 at 08:03 +0200, Juergen Gross wrote:
> Add a new domctl for setting domain specific parameters similar to
> XEN_SYSCTL_set_parameter for global hypervisor parameters.
> 
> Enhance XEN_SYSCTL_set_parameter to be usable for setting cpupool
> specific parameters, too. For now do only extended parameter
> checking.
> The cpupool parameter setting will be added later.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>

I mean...

> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -1055,12 +1055,18 @@ struct xen_sysctl_livepatch_op {
>   * Parameters are a single string terminated by a NUL byte of max.
> size
>   * characters. Multiple settings can be specified by separating them
>   * with blanks.
> + * Scope can be either global (like boot parameters) or cpupool.
>   */
>  
>  struct xen_sysctl_set_parameter {
>      XEN_GUEST_HANDLE_64(char) params;       /* IN: pointer to
> parameters. */
>      uint16_t size;                          /* IN: size of
> parameters. */
> -    uint16_t pad[3];                        /* IN: MUST be zero. */
> +    uint8_t  scope;                         /* IN: scope of
> parameters. */
> +#define XEN_SYSCTL_SETPAR_SCOPE_GLOBAL   0
> +#define XEN_SYSCTL_SETPAR_SCOPE_CPUPOOL  1
> +    uint8_t  pad;                           /* IN: MUST be zero. */
> +    uint32_t instance;                      /* IN: scope global:
> must be zero */
> +                                            /*     scope cpupool:
> cpupool id */
>
... I don't particularly like the name 'instance', but I've not been
able to come up with anything else which sounds better... :-/

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel