* [PATCH v3 0/1] Mediatek MT6366 Regulator patch @ 2022-08-12 9:29 ` Zhiyong Tao 0 siblings, 0 replies; 23+ messages in thread From: Zhiyong Tao @ 2022-08-12 9:29 UTC (permalink / raw) To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, zhiyong.tao, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek Add mt6366 binding documentation Changes in patch v3: 1)change patch title 2)change "regulator.yaml#" to regulator.yaml# 3)remove regulator-name 4)fix 4 space for DTS example Changes in patch v2: 1)fix patch title description. 2)fix patch maintainer description. 3)won't cc to srv_heupstream@mediatek.com 4)fix patch commit message description. 5)add properties node and compatible 6)put "unevaluatedProperties: false" after $ref 7)remove underscores in node names. 8)change Filename to "mediatek,mt6366-regulator.yaml" Zhiyong Tao (1): regulator: dt-bindings: mediatek: add mt6366 .../regulator/mediatek,mt6366-regulator.yaml | 287 ++++++++++++++++++ 1 file changed, 287 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml -- 2.18.0 ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v3 0/1] Mediatek MT6366 Regulator patch @ 2022-08-12 9:29 ` Zhiyong Tao 0 siblings, 0 replies; 23+ messages in thread From: Zhiyong Tao @ 2022-08-12 9:29 UTC (permalink / raw) To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, zhiyong.tao, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek Add mt6366 binding documentation Changes in patch v3: 1)change patch title 2)change "regulator.yaml#" to regulator.yaml# 3)remove regulator-name 4)fix 4 space for DTS example Changes in patch v2: 1)fix patch title description. 2)fix patch maintainer description. 3)won't cc to srv_heupstream@mediatek.com 4)fix patch commit message description. 5)add properties node and compatible 6)put "unevaluatedProperties: false" after $ref 7)remove underscores in node names. 8)change Filename to "mediatek,mt6366-regulator.yaml" Zhiyong Tao (1): regulator: dt-bindings: mediatek: add mt6366 .../regulator/mediatek,mt6366-regulator.yaml | 287 ++++++++++++++++++ 1 file changed, 287 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-12 9:29 ` Zhiyong Tao @ 2022-08-12 9:29 ` Zhiyong Tao -1 siblings, 0 replies; 23+ messages in thread From: Zhiyong Tao @ 2022-08-12 9:29 UTC (permalink / raw) To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, zhiyong.tao, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek Add mt6366 regulator document Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> --- .../regulator/mediatek,mt6366-regulator.yaml | 287 ++++++++++++++++++ 1 file changed, 287 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml new file mode 100644 index 000000000000..78a224a2cd5a --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml @@ -0,0 +1,287 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MT6366 Regulator from MediaTek Integrated + +maintainers: + - Zhiyong Tao <zhiyong.tao@mediatek.com> + +description: | + List of regulators provided by this controller. It is named + according to its regulator type, buck_<name> and ldo_<name>. + MT6366 regulators node should be sub node of the MT6397 MFD node. + +properties: + compatible: + const: mediatek,mt6366-regulator + + regulators: + type: object + description: List of regulators and its properties + + patternProperties: + "^buck-v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": + type: object + $ref: regulator.yaml# + + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$": + type: object + $ref: regulator.yaml# + + "^buck-(vcore)-sshub$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vcn(28|33)-bt$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vcn(33)-wifi$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vsram-(others)-sshub$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vsram-(proc11|others|gpu|proc12)$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-v(aud|bif|io|ldo)28$": + type: object + $ref: regulator.yaml# + + "^ldo-v(io|aux|rf)18$": + type: object + $ref: regulator.yaml# + + "^ldo-vsim[2]$": + type: object + $ref: regulator.yaml# + +required: + - compatible + - regulators + +additionalProperties: false + +examples: + - | + pmic { + compatible = "mediatek,mt6366-regulator"; + + regulators { + mt6366_vdram1_reg: buck-vdram1 { + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vcore_reg: buck-vcore { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vproc11_reg: buck-vproc11 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vproc12_reg: buck-vproc12 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vgpu_reg: buck-vgpu { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vs2_reg: buck-vs2 { + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + }; + + mt6366_vmodem_reg: buck-vmodem { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <900>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vs1_reg: buck-vs1 { + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + }; + + mt6366_vdram2_reg: ldo-vdram2 { + regulator-enable-ramp-delay = <3300>; + }; + + mt6366_vsim1_reg: ldo-vsim1 { + regulator-enable-ramp-delay = <540>; + }; + + mt6366_vibr_reg: ldo-vibr { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vrf12_reg: ldo-vrf12 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vio18_reg: ldo-vio18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <2700>; + }; + + mt6366_vusb_reg: ldo-vusb { + regulator-name = "vusb"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcamio_reg: ldo-vcamio { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vcamd_reg: ldo-vcamd { + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vcn18_reg: ldo-vcn18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vfe28_reg: ldo-vfe28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_proc11_reg: ldo-vsram-proc11 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vcn28_reg: ldo-vcn28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_others_reg: ldo-vsram-others { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vsram_gpu_reg: ldo-vsram-gpu { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vxo22_reg: ldo-vxo22 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vefuse_reg: ldo-vefuse { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vaux18_reg: ldo-vaux18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vmch_reg: ldo-vmch { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vbif28_reg: ldo-vbif28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_proc12_reg: ldo-vsram-proc12 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vcama1_reg: ldo-vcama1 { + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vemc_reg: ldo-vemc { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vio28_reg: ldo-vio28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_va12_reg: ldo-va12 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vrf18_reg: ldo-vrf18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vcn33_bt_reg: ldo-vcn33-bt { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcn33_wifi_reg: ldo-vcn33-wifi { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcama2_reg: ldo-vcama2 { + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vmc_reg: ldo-vmc { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vldo28_reg: ldo-vldo28 { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vaud28_reg: ldo-vaud28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsim2_reg: ldo-vsim2 { + regulator-enable-ramp-delay = <540>; + }; + + mt6366_vcore_sshub_reg: buck-vcore-sshub { + }; + + mt6366_vsram_others_sshub_reg: ldo-vsram-others-sshub { + }; + }; + }; +... -- 2.18.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-12 9:29 ` Zhiyong Tao 0 siblings, 0 replies; 23+ messages in thread From: Zhiyong Tao @ 2022-08-12 9:29 UTC (permalink / raw) To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, zhiyong.tao, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek Add mt6366 regulator document Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> --- .../regulator/mediatek,mt6366-regulator.yaml | 287 ++++++++++++++++++ 1 file changed, 287 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml new file mode 100644 index 000000000000..78a224a2cd5a --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml @@ -0,0 +1,287 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MT6366 Regulator from MediaTek Integrated + +maintainers: + - Zhiyong Tao <zhiyong.tao@mediatek.com> + +description: | + List of regulators provided by this controller. It is named + according to its regulator type, buck_<name> and ldo_<name>. + MT6366 regulators node should be sub node of the MT6397 MFD node. + +properties: + compatible: + const: mediatek,mt6366-regulator + + regulators: + type: object + description: List of regulators and its properties + + patternProperties: + "^buck-v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": + type: object + $ref: regulator.yaml# + + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$": + type: object + $ref: regulator.yaml# + + "^buck-(vcore)-sshub$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vcn(28|33)-bt$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vcn(33)-wifi$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vsram-(others)-sshub$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-vsram-(proc11|others|gpu|proc12)$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + + "^ldo-v(aud|bif|io|ldo)28$": + type: object + $ref: regulator.yaml# + + "^ldo-v(io|aux|rf)18$": + type: object + $ref: regulator.yaml# + + "^ldo-vsim[2]$": + type: object + $ref: regulator.yaml# + +required: + - compatible + - regulators + +additionalProperties: false + +examples: + - | + pmic { + compatible = "mediatek,mt6366-regulator"; + + regulators { + mt6366_vdram1_reg: buck-vdram1 { + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vcore_reg: buck-vcore { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vproc11_reg: buck-vproc11 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vproc12_reg: buck-vproc12 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vgpu_reg: buck-vgpu { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vs2_reg: buck-vs2 { + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + }; + + mt6366_vmodem_reg: buck-vmodem { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <900>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vs1_reg: buck-vs1 { + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + }; + + mt6366_vdram2_reg: ldo-vdram2 { + regulator-enable-ramp-delay = <3300>; + }; + + mt6366_vsim1_reg: ldo-vsim1 { + regulator-enable-ramp-delay = <540>; + }; + + mt6366_vibr_reg: ldo-vibr { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vrf12_reg: ldo-vrf12 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vio18_reg: ldo-vio18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <2700>; + }; + + mt6366_vusb_reg: ldo-vusb { + regulator-name = "vusb"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcamio_reg: ldo-vcamio { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vcamd_reg: ldo-vcamd { + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vcn18_reg: ldo-vcn18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vfe28_reg: ldo-vfe28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_proc11_reg: ldo-vsram-proc11 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vcn28_reg: ldo-vcn28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_others_reg: ldo-vsram-others { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vsram_gpu_reg: ldo-vsram-gpu { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vxo22_reg: ldo-vxo22 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vefuse_reg: ldo-vefuse { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vaux18_reg: ldo-vaux18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vmch_reg: ldo-vmch { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vbif28_reg: ldo-vbif28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_proc12_reg: ldo-vsram-proc12 { + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vcama1_reg: ldo-vcama1 { + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vemc_reg: ldo-vemc { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vio28_reg: ldo-vio28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_va12_reg: ldo-va12 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vrf18_reg: ldo-vrf18 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vcn33_bt_reg: ldo-vcn33-bt { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcn33_wifi_reg: ldo-vcn33-wifi { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcama2_reg: ldo-vcama2 { + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vmc_reg: ldo-vmc { + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vldo28_reg: ldo-vldo28 { + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vaud28_reg: ldo-vaud28 { + compatible = "regulator-fixed"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsim2_reg: ldo-vsim2 { + regulator-enable-ramp-delay = <540>; + }; + + mt6366_vcore_sshub_reg: buck-vcore-sshub { + }; + + mt6366_vsram_others_sshub_reg: ldo-vsram-others-sshub { + }; + }; + }; +... -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-12 9:29 ` Zhiyong Tao @ 2022-08-12 10:55 ` Krzysztof Kozlowski -1 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 10:55 UTC (permalink / raw) To: Zhiyong Tao, lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On 12/08/2022 12:29, Zhiyong Tao wrote: > Add mt6366 regulator document > > + > +properties: > + compatible: > + const: mediatek,mt6366-regulator > + > + regulators: > + type: object > + description: List of regulators and its properties > + > + patternProperties: > + "^buck-v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > + type: object > + $ref: regulator.yaml# > + unevaluatedProperties: false > + > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > + type: object > + $ref: regulator.yaml# You miss unevaluatedProperties in most of the places. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-12 10:55 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 10:55 UTC (permalink / raw) To: Zhiyong Tao, lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On 12/08/2022 12:29, Zhiyong Tao wrote: > Add mt6366 regulator document > > + > +properties: > + compatible: > + const: mediatek,mt6366-regulator > + > + regulators: > + type: object > + description: List of regulators and its properties > + > + patternProperties: > + "^buck-v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > + type: object > + $ref: regulator.yaml# > + unevaluatedProperties: false > + > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > + type: object > + $ref: regulator.yaml# You miss unevaluatedProperties in most of the places. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-12 10:55 ` Krzysztof Kozlowski @ 2022-08-12 12:52 ` zhiyong.tao -1 siblings, 0 replies; 23+ messages in thread From: zhiyong.tao @ 2022-08-12 12:52 UTC (permalink / raw) To: Krzysztof Kozlowski, lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 12:29, Zhiyong Tao wrote: > > Add mt6366 regulator document > > > > + > > +properties: > > + compatible: > > + const: mediatek,mt6366-regulator > > + > > + regulators: > > + type: object > > + description: List of regulators and its properties > > + > > + patternProperties: > > + "^buck- > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > + type: object > > + $ref: regulator.yaml# > > + unevaluatedProperties: false > > + > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > + type: object > > + $ref: regulator.yaml# > > You miss unevaluatedProperties in most of the places. Hi Krzysztof, Thanks for your suggestion, Do you mean that all places should have the unevaluatedProperties Properties ? Thanks > > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-12 12:52 ` zhiyong.tao 0 siblings, 0 replies; 23+ messages in thread From: zhiyong.tao @ 2022-08-12 12:52 UTC (permalink / raw) To: Krzysztof Kozlowski, lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 12:29, Zhiyong Tao wrote: > > Add mt6366 regulator document > > > > + > > +properties: > > + compatible: > > + const: mediatek,mt6366-regulator > > + > > + regulators: > > + type: object > > + description: List of regulators and its properties > > + > > + patternProperties: > > + "^buck- > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > + type: object > > + $ref: regulator.yaml# > > + unevaluatedProperties: false > > + > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > + type: object > > + $ref: regulator.yaml# > > You miss unevaluatedProperties in most of the places. Hi Krzysztof, Thanks for your suggestion, Do you mean that all places should have the unevaluatedProperties Properties ? Thanks > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-12 12:52 ` zhiyong.tao (?) @ 2022-08-12 12:55 ` Krzysztof Kozlowski -1 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 12:55 UTC (permalink / raw) To: zhiyong.tao Cc: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao, sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> wrote: > > On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > > On 12/08/2022 12:29, Zhiyong Tao wrote: > > > Add mt6366 regulator document > > > > > > + > > > +properties: > > > + compatible: > > > + const: mediatek,mt6366-regulator > > > + > > > + regulators: > > > + type: object > > > + description: List of regulators and its properties > > > + > > > + patternProperties: > > > + "^buck- > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > + type: object > > > + $ref: regulator.yaml# > > > + unevaluatedProperties: false > > > + > > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > + type: object > > > + $ref: regulator.yaml# > > > > You miss unevaluatedProperties in most of the places. > > Hi Krzysztof, > Thanks for your suggestion, > Do you mean that all places should have the unevaluatedProperties > Properties ? Yes. You put it in some of the places which does not really make sense... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-12 12:55 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 12:55 UTC (permalink / raw) To: zhiyong.tao Cc: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao, sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> wrote: > > On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > > On 12/08/2022 12:29, Zhiyong Tao wrote: > > > Add mt6366 regulator document > > > > > > + > > > +properties: > > > + compatible: > > > + const: mediatek,mt6366-regulator > > > + > > > + regulators: > > > + type: object > > > + description: List of regulators and its properties > > > + > > > + patternProperties: > > > + "^buck- > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > + type: object > > > + $ref: regulator.yaml# > > > + unevaluatedProperties: false > > > + > > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > + type: object > > > + $ref: regulator.yaml# > > > > You miss unevaluatedProperties in most of the places. > > Hi Krzysztof, > Thanks for your suggestion, > Do you mean that all places should have the unevaluatedProperties > Properties ? Yes. You put it in some of the places which does not really make sense... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-12 12:55 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 12:55 UTC (permalink / raw) To: zhiyong.tao Cc: alexandre.belloni, allen-kh.cheng, linux-kernel, macpaul.lin, lee.jones, hsin-hsiung.wang, linux-rtc, wen.su, Project_Global_Chrome_Upstream_Group, devicetree, sean.wang, hui.liu, robh+dt, linux-mediatek, matthias.bgg, eddie.huang, linux-arm-kernel, a.zummo, sen.chu, lgirdwood, broonie On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> wrote: > > On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > > On 12/08/2022 12:29, Zhiyong Tao wrote: > > > Add mt6366 regulator document > > > > > > + > > > +properties: > > > + compatible: > > > + const: mediatek,mt6366-regulator > > > + > > > + regulators: > > > + type: object > > > + description: List of regulators and its properties > > > + > > > + patternProperties: > > > + "^buck- > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > + type: object > > > + $ref: regulator.yaml# > > > + unevaluatedProperties: false > > > + > > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > + type: object > > > + $ref: regulator.yaml# > > > > You miss unevaluatedProperties in most of the places. > > Hi Krzysztof, > Thanks for your suggestion, > Do you mean that all places should have the unevaluatedProperties > Properties ? Yes. You put it in some of the places which does not really make sense... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-12 12:55 ` Krzysztof Kozlowski @ 2022-08-16 12:54 ` zhiyong.tao -1 siblings, 0 replies; 23+ messages in thread From: zhiyong.tao @ 2022-08-16 12:54 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: alexandre.belloni, allen-kh.cheng, linux-kernel, macpaul.lin, lee.jones, hsin-hsiung.wang, linux-rtc, wen.su, Project_Global_Chrome_Upstream_Group, devicetree, sean.wang, hui.liu, robh+dt, linux-mediatek, matthias.bgg, eddie.huang, linux-arm-kernel, a.zummo, sen.chu, lgirdwood, broonie On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: > On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> > wrote: > > > > On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > > > On 12/08/2022 12:29, Zhiyong Tao wrote: > > > > Add mt6366 regulator document > > > > > > > > + > > > > +properties: > > > > + compatible: > > > > + const: mediatek,mt6366-regulator > > > > + > > > > + regulators: > > > > + type: object > > > > + description: List of regulators and its properties > > > > + > > > > + patternProperties: > > > > + "^buck- > > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > > + type: object > > > > + $ref: regulator.yaml# > > > > + unevaluatedProperties: false > > > > + > > > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > > + type: object > > > > + $ref: regulator.yaml# > > > > > > You miss unevaluatedProperties in most of the places. > > > > Hi Krzysztof, > > Thanks for your suggestion, > > Do you mean that all places should have the > > unevaluatedProperties > > Properties ? > > Yes. You put it in some of the places which does not really make > sense... Hi Krzysztof, Thanks for your suggestion, We find that if there is a properties "compatible = "regulator- fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. or it will check yaml warning "Unevaluated Properties are not allowed('compatible' was unexpected)". is it right? There is a properties "compatible = "regulator-fixed";"in ldo-vrf12. It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a required property". Can you help to give a suggestion to fix the warning? Add regulator-name for ldo-vrf12 or other suggestion? Thanks > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-16 12:54 ` zhiyong.tao 0 siblings, 0 replies; 23+ messages in thread From: zhiyong.tao @ 2022-08-16 12:54 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao, sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: > On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> > wrote: > > > > On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > > > On 12/08/2022 12:29, Zhiyong Tao wrote: > > > > Add mt6366 regulator document > > > > > > > > + > > > > +properties: > > > > + compatible: > > > > + const: mediatek,mt6366-regulator > > > > + > > > > + regulators: > > > > + type: object > > > > + description: List of regulators and its properties > > > > + > > > > + patternProperties: > > > > + "^buck- > > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > > + type: object > > > > + $ref: regulator.yaml# > > > > + unevaluatedProperties: false > > > > + > > > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > > + type: object > > > > + $ref: regulator.yaml# > > > > > > You miss unevaluatedProperties in most of the places. > > > > Hi Krzysztof, > > Thanks for your suggestion, > > Do you mean that all places should have the > > unevaluatedProperties > > Properties ? > > Yes. You put it in some of the places which does not really make > sense... Hi Krzysztof, Thanks for your suggestion, We find that if there is a properties "compatible = "regulator- fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. or it will check yaml warning "Unevaluated Properties are not allowed('compatible' was unexpected)". is it right? There is a properties "compatible = "regulator-fixed";"in ldo-vrf12. It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a required property". Can you help to give a suggestion to fix the warning? Add regulator-name for ldo-vrf12 or other suggestion? Thanks > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-16 12:54 ` zhiyong.tao (?) @ 2022-08-16 12:57 ` Krzysztof Kozlowski -1 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-16 12:57 UTC (permalink / raw) To: zhiyong.tao Cc: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao, sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On 16/08/2022 15:54, zhiyong.tao wrote: > On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: >> On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> >> wrote: >>> >>> On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: >>>> On 12/08/2022 12:29, Zhiyong Tao wrote: >>>>> Add mt6366 regulator document >>>>> >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + const: mediatek,mt6366-regulator >>>>> + >>>>> + regulators: >>>>> + type: object >>>>> + description: List of regulators and its properties >>>>> + >>>>> + patternProperties: >>>>> + "^buck- >>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>>> + unevaluatedProperties: false >>>>> + >>>>> + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>> >>>> You miss unevaluatedProperties in most of the places. >>> >>> Hi Krzysztof, >>> Thanks for your suggestion, >>> Do you mean that all places should have the >>> unevaluatedProperties >>> Properties ? >> >> Yes. You put it in some of the places which does not really make >> sense... > > Hi Krzysztof, > Thanks for your suggestion, > We find that if there is a properties "compatible = "regulator- > fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. > or it will check yaml warning "Unevaluated Properties are not > allowed('compatible' was unexpected)". is it right? > There is a properties "compatible = "regulator-fixed";"in ldo-vrf12. > It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a > required property". Can you help to give a suggestion to fix the > warning? Add regulator-name for ldo-vrf12 or other suggestion? > And how this regulator is supposed to work? Are you populating DT children in your driver? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-16 12:57 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-16 12:57 UTC (permalink / raw) To: zhiyong.tao Cc: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao, sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On 16/08/2022 15:54, zhiyong.tao wrote: > On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: >> On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> >> wrote: >>> >>> On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: >>>> On 12/08/2022 12:29, Zhiyong Tao wrote: >>>>> Add mt6366 regulator document >>>>> >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + const: mediatek,mt6366-regulator >>>>> + >>>>> + regulators: >>>>> + type: object >>>>> + description: List of regulators and its properties >>>>> + >>>>> + patternProperties: >>>>> + "^buck- >>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>>> + unevaluatedProperties: false >>>>> + >>>>> + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>> >>>> You miss unevaluatedProperties in most of the places. >>> >>> Hi Krzysztof, >>> Thanks for your suggestion, >>> Do you mean that all places should have the >>> unevaluatedProperties >>> Properties ? >> >> Yes. You put it in some of the places which does not really make >> sense... > > Hi Krzysztof, > Thanks for your suggestion, > We find that if there is a properties "compatible = "regulator- > fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. > or it will check yaml warning "Unevaluated Properties are not > allowed('compatible' was unexpected)". is it right? > There is a properties "compatible = "regulator-fixed";"in ldo-vrf12. > It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a > required property". Can you help to give a suggestion to fix the > warning? Add regulator-name for ldo-vrf12 or other suggestion? > And how this regulator is supposed to work? Are you populating DT children in your driver? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-16 12:57 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-16 12:57 UTC (permalink / raw) To: zhiyong.tao Cc: alexandre.belloni, allen-kh.cheng, linux-kernel, macpaul.lin, lee.jones, hsin-hsiung.wang, linux-rtc, wen.su, Project_Global_Chrome_Upstream_Group, devicetree, sean.wang, hui.liu, robh+dt, linux-mediatek, matthias.bgg, eddie.huang, linux-arm-kernel, a.zummo, sen.chu, lgirdwood, broonie On 16/08/2022 15:54, zhiyong.tao wrote: > On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: >> On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com> >> wrote: >>> >>> On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: >>>> On 12/08/2022 12:29, Zhiyong Tao wrote: >>>>> Add mt6366 regulator document >>>>> >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + const: mediatek,mt6366-regulator >>>>> + >>>>> + regulators: >>>>> + type: object >>>>> + description: List of regulators and its properties >>>>> + >>>>> + patternProperties: >>>>> + "^buck- >>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>>> + unevaluatedProperties: false >>>>> + >>>>> + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>> >>>> You miss unevaluatedProperties in most of the places. >>> >>> Hi Krzysztof, >>> Thanks for your suggestion, >>> Do you mean that all places should have the >>> unevaluatedProperties >>> Properties ? >> >> Yes. You put it in some of the places which does not really make >> sense... > > Hi Krzysztof, > Thanks for your suggestion, > We find that if there is a properties "compatible = "regulator- > fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. > or it will check yaml warning "Unevaluated Properties are not > allowed('compatible' was unexpected)". is it right? > There is a properties "compatible = "regulator-fixed";"in ldo-vrf12. > It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a > required property". Can you help to give a suggestion to fix the > warning? Add regulator-name for ldo-vrf12 or other suggestion? > And how this regulator is supposed to work? Are you populating DT children in your driver? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-16 12:57 ` Krzysztof Kozlowski @ 2022-08-23 12:42 ` zhiyong.tao -1 siblings, 0 replies; 23+ messages in thread From: zhiyong.tao @ 2022-08-23 12:42 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: alexandre.belloni, allen-kh.cheng, linux-kernel, macpaul.lin, lee.jones, hsin-hsiung.wang, linux-rtc, wen.su, Project_Global_Chrome_Upstream_Group, devicetree, sean.wang, hui.liu, robh+dt, linux-mediatek, matthias.bgg, eddie.huang, linux-arm-kernel, a.zummo, sen.chu, lgirdwood, broonie On Tue, 2022-08-16 at 15:57 +0300, Krzysztof Kozlowski wrote: > On 16/08/2022 15:54, zhiyong.tao wrote: > > On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: > > > On Fri, 12 Aug 2022 at 15:52, zhiyong.tao < > > > zhiyong.tao@mediatek.com> > > > wrote: > > > > > > > > On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > > > > > On 12/08/2022 12:29, Zhiyong Tao wrote: > > > > > > Add mt6366 regulator document > > > > > > > > > > > > + > > > > > > +properties: > > > > > > + compatible: > > > > > > + const: mediatek,mt6366-regulator > > > > > > + > > > > > > + regulators: > > > > > > + type: object > > > > > > + description: List of regulators and its properties > > > > > > + > > > > > > + patternProperties: > > > > > > + "^buck- > > > > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > > > > + type: object > > > > > > + $ref: regulator.yaml# > > > > > > + unevaluatedProperties: false > > > > > > + > > > > > > + "^ldo- > > > > > > v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > > > > + type: object > > > > > > + $ref: regulator.yaml# > > > > > > > > > > You miss unevaluatedProperties in most of the places. > > > > > > > > Hi Krzysztof, > > > > Thanks for your suggestion, > > > > Do you mean that all places should have the > > > > unevaluatedProperties > > > > Properties ? > > > > > > Yes. You put it in some of the places which does not really make > > > sense... > > > > Hi Krzysztof, > > Thanks for your suggestion, > > We find that if there is a properties "compatible = "regulator- > > fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. > > or it will check yaml warning "Unevaluated Properties are not > > allowed('compatible' was unexpected)". is it right? > > There is a properties "compatible = "regulator-fixed";"in ldo- > > vrf12. > > It will cause the checking yaml error "ldo-vrf12: 'regulator-name' > > is a > > required property". Can you help to give a suggestion to fix the > > warning? Add regulator-name for ldo-vrf12 or other suggestion? > > > > And how this regulator is supposed to work? Are you populating DT > children in your driver? ==> Hi Krzysztof, we will remove the properties "compatible = "regulator- fixed" for some ldo. It won't any check error. Thanks > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-23 12:42 ` zhiyong.tao 0 siblings, 0 replies; 23+ messages in thread From: zhiyong.tao @ 2022-08-23 12:42 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao, sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On Tue, 2022-08-16 at 15:57 +0300, Krzysztof Kozlowski wrote: > On 16/08/2022 15:54, zhiyong.tao wrote: > > On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: > > > On Fri, 12 Aug 2022 at 15:52, zhiyong.tao < > > > zhiyong.tao@mediatek.com> > > > wrote: > > > > > > > > On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: > > > > > On 12/08/2022 12:29, Zhiyong Tao wrote: > > > > > > Add mt6366 regulator document > > > > > > > > > > > > + > > > > > > +properties: > > > > > > + compatible: > > > > > > + const: mediatek,mt6366-regulator > > > > > > + > > > > > > + regulators: > > > > > > + type: object > > > > > > + description: List of regulators and its properties > > > > > > + > > > > > > + patternProperties: > > > > > > + "^buck- > > > > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > > > > + type: object > > > > > > + $ref: regulator.yaml# > > > > > > + unevaluatedProperties: false > > > > > > + > > > > > > + "^ldo- > > > > > > v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > > > > + type: object > > > > > > + $ref: regulator.yaml# > > > > > > > > > > You miss unevaluatedProperties in most of the places. > > > > > > > > Hi Krzysztof, > > > > Thanks for your suggestion, > > > > Do you mean that all places should have the > > > > unevaluatedProperties > > > > Properties ? > > > > > > Yes. You put it in some of the places which does not really make > > > sense... > > > > Hi Krzysztof, > > Thanks for your suggestion, > > We find that if there is a properties "compatible = "regulator- > > fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. > > or it will check yaml warning "Unevaluated Properties are not > > allowed('compatible' was unexpected)". is it right? > > There is a properties "compatible = "regulator-fixed";"in ldo- > > vrf12. > > It will cause the checking yaml error "ldo-vrf12: 'regulator-name' > > is a > > required property". Can you help to give a suggestion to fix the > > warning? Add regulator-name for ldo-vrf12 or other suggestion? > > > > And how this regulator is supposed to work? Are you populating DT > children in your driver? ==> Hi Krzysztof, we will remove the properties "compatible = "regulator- fixed" for some ldo. It won't any check error. Thanks > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 2022-08-12 9:29 ` Zhiyong Tao (?) @ 2022-08-12 15:13 ` Rob Herring -1 siblings, 0 replies; 23+ messages in thread From: Rob Herring @ 2022-08-12 15:13 UTC (permalink / raw) To: Zhiyong Tao Cc: fshao, lee.jones, hsin-hsiung.wang, a.zummo, lgirdwood, robh+dt, broonie, macpaul.lin, wen.su, Project_Global_Chrome_Upstream_Group, sean.wang, linux-arm-kernel, linux-rtc, eddie.huang, devicetree, allen-kh.cheng, linux-kernel, alexandre.belloni, sen.chu, hui.liu, linux-mediatek, matthias.bgg On Fri, 12 Aug 2022 17:29:01 +0800, Zhiyong Tao wrote: > Add mt6366 regulator document > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > --- > .../regulator/mediatek,mt6366-regulator.yaml | 287 ++++++++++++++++++ > 1 file changed, 287 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vrf12: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vio18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcamio: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcn18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vfe28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcn28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vxo22: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vaux18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vbif28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vio28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-va12: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vrf18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vaud28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-12 15:13 ` Rob Herring 0 siblings, 0 replies; 23+ messages in thread From: Rob Herring @ 2022-08-12 15:13 UTC (permalink / raw) To: Zhiyong Tao Cc: fshao, lee.jones, hsin-hsiung.wang, a.zummo, lgirdwood, robh+dt, broonie, macpaul.lin, wen.su, Project_Global_Chrome_Upstream_Group, sean.wang, linux-arm-kernel, linux-rtc, eddie.huang, devicetree, allen-kh.cheng, linux-kernel, alexandre.belloni, sen.chu, hui.liu, linux-mediatek, matthias.bgg On Fri, 12 Aug 2022 17:29:01 +0800, Zhiyong Tao wrote: > Add mt6366 regulator document > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > --- > .../regulator/mediatek,mt6366-regulator.yaml | 287 ++++++++++++++++++ > 1 file changed, 287 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vrf12: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vio18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcamio: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcn18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vfe28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcn28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vxo22: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vaux18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vbif28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vio28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-va12: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vrf18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vaud28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 @ 2022-08-12 15:13 ` Rob Herring 0 siblings, 0 replies; 23+ messages in thread From: Rob Herring @ 2022-08-12 15:13 UTC (permalink / raw) To: Zhiyong Tao Cc: alexandre.belloni, allen-kh.cheng, linux-kernel, macpaul.lin, lee.jones, hsin-hsiung.wang, linux-rtc, wen.su, Project_Global_Chrome_Upstream_Group, devicetree, hui.liu, sean.wang, broonie, linux-mediatek, matthias.bgg, eddie.huang, linux-arm-kernel, a.zummo, sen.chu, lgirdwood, robh+dt On Fri, 12 Aug 2022 17:29:01 +0800, Zhiyong Tao wrote: > Add mt6366 regulator document > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > --- > .../regulator/mediatek,mt6366-regulator.yaml | 287 ++++++++++++++++++ > 1 file changed, 287 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vrf12: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vio18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcamio: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcn18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vfe28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vcn28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vxo22: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vaux18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vbif28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vio28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-va12: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vrf18: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.example.dtb: ldo-vaud28: 'regulator-name' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 0/1] Mediatek MT6366 Regulator patch 2022-08-12 9:29 ` Zhiyong Tao @ 2022-08-12 10:56 ` Krzysztof Kozlowski -1 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 10:56 UTC (permalink / raw) To: Zhiyong Tao, lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On 12/08/2022 12:29, Zhiyong Tao wrote: > Add mt6366 binding documentation > > Changes in patch v3: > 1)change patch title Where is the driver? Don't ignore feedback: https://lore.kernel.org/all/YuJsDI8rqkHuysIT@sirena.org.uk/ Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v3 0/1] Mediatek MT6366 Regulator patch @ 2022-08-12 10:56 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2022-08-12 10:56 UTC (permalink / raw) To: Zhiyong Tao, lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: sen.chu, hui.liu, allen-kh.cheng, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On 12/08/2022 12:29, Zhiyong Tao wrote: > Add mt6366 binding documentation > > Changes in patch v3: > 1)change patch title Where is the driver? Don't ignore feedback: https://lore.kernel.org/all/YuJsDI8rqkHuysIT@sirena.org.uk/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2022-08-23 13:44 UTC | newest] Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-08-12 9:29 [PATCH v3 0/1] Mediatek MT6366 Regulator patch Zhiyong Tao 2022-08-12 9:29 ` Zhiyong Tao 2022-08-12 9:29 ` [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 Zhiyong Tao 2022-08-12 9:29 ` Zhiyong Tao 2022-08-12 10:55 ` Krzysztof Kozlowski 2022-08-12 10:55 ` Krzysztof Kozlowski 2022-08-12 12:52 ` zhiyong.tao 2022-08-12 12:52 ` zhiyong.tao 2022-08-12 12:55 ` Krzysztof Kozlowski 2022-08-12 12:55 ` Krzysztof Kozlowski 2022-08-12 12:55 ` Krzysztof Kozlowski 2022-08-16 12:54 ` zhiyong.tao 2022-08-16 12:54 ` zhiyong.tao 2022-08-16 12:57 ` Krzysztof Kozlowski 2022-08-16 12:57 ` Krzysztof Kozlowski 2022-08-16 12:57 ` Krzysztof Kozlowski 2022-08-23 12:42 ` zhiyong.tao 2022-08-23 12:42 ` zhiyong.tao 2022-08-12 15:13 ` Rob Herring 2022-08-12 15:13 ` Rob Herring 2022-08-12 15:13 ` Rob Herring 2022-08-12 10:56 ` [PATCH v3 0/1] Mediatek MT6366 Regulator patch Krzysztof Kozlowski 2022-08-12 10:56 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.