From: Matt Flax <flatmax@flatmax.org>
To: Mark Brown <broonie@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org,
Brian Austin <brian.austin@cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>
Subject: Re: [PATCH 2/3] ASoC: cs4265: Add native 32bit I2S transport
Date: Wed, 29 Aug 2018 09:31:31 +1000 [thread overview]
Message-ID: <cbf11383-f9f5-22a3-6fa0-e097462716f2@flatmax.org> (raw)
In-Reply-To: <20180828185652.GJ2414@sirena.org.uk>
On 29/08/18 04:56, Mark Brown wrote:
> On Mon, Aug 27, 2018 at 09:28:43AM +0100, Charles Keepax wrote:
>
>> Are you sure this is correct? The datasheet for the part only
>> says it supports up to 24-bit audio and I thought the defines
>> SNDRV_PCM_FMTBIT_S24_LE and U24 are expected to have 32-bits
>> in the slot whilst on the bus.
> No, they're not. They're expected to be 32 bit in memory and 24 bit on
> the bus.
>
If this is the case, then I would assume that 32bit formats are forced
through ALSA plughw.
If operation is forced through plughw, then this patch is necessary to
allow native 32 operation on the bus. The codec drops the 8 LSBs during
operation as it reads/writes the 24 MSBs.
Matt
next prev parent reply other threads:[~2018-08-28 23:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-26 22:58 [PATCH 1/3] ASoC: cs4265: SOC_SINGLE register value error fix Matt Flax
2018-08-26 22:58 ` [PATCH 2/3] ASoC: cs4265: Add native 32bit I2S transport Matt Flax
2018-08-27 8:28 ` Charles Keepax
2018-08-27 9:51 ` Matt Flax
2018-08-28 18:56 ` Mark Brown
2018-08-28 23:31 ` Matt Flax [this message]
2018-08-29 0:26 ` Matt Flax
2018-08-29 8:22 ` Charles Keepax
2018-08-26 22:58 ` [PATCH 3/3] ASoC: cs4265: Add a SPDIF enable actl Matt Flax
2018-08-27 8:24 ` Charles Keepax
2018-08-27 9:52 ` Matt Flax
2018-08-27 8:30 ` [PATCH 1/3] ASoC: cs4265: SOC_SINGLE register value error fix Charles Keepax
2018-08-28 18:57 ` Mark Brown
2018-08-28 23:28 ` Matt Flax
-- strict thread matches above, loose matches on Subject: below --
2018-08-26 22:55 Matt Flax
2018-08-26 22:55 ` [PATCH 2/3] ASoC: cs4265: Add native 32bit I2S transport Matt Flax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbf11383-f9f5-22a3-6fa0-e097462716f2@flatmax.org \
--to=flatmax@flatmax.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.