From: James Smart <jsmart2021@gmail.com>
To: Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 06/17] lpfc: NVME Initiator: Base modifications Part E
Date: Wed, 18 Jan 2017 18:14:35 -0800 [thread overview]
Message-ID: <cc0b019e-19e9-dfaa-314d-98a8545e7542@gmail.com> (raw)
In-Reply-To: <cefa5f07-a3f3-c5dc-2d3a-ddd410d1ffa4@suse.de>
On 1/17/2017 11:34 PM, Hannes Reinecke wrote:
> Is this ever reset?
> I don't see it here ...
the lpfc_sli4_hba_setup(), which resets the function and reinits, clears
the flag.
>
> [ .. ]
>> @@ -4380,9 +4469,12 @@ lpfc_sli_chipset_init(struct lpfc_hba *phba)
>> * configured.
>> **/
>> int
>> -lpfc_sli_hbq_count(void)
>> +lpfc_sli_hbq_count(struct lpfc_hba *phba)
>> {
>> - return ARRAY_SIZE(lpfc_hbq_defs);
>> + int i;
>> +
>> + i = ARRAY_SIZE(lpfc_hbq_defs);
>> + return i;
>> }
>>
>> /**
> The point of this change being ...?
I don't know - will collapse it.
-- james
WARNING: multiple messages have this Message-ID (diff)
From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH 06/17] lpfc: NVME Initiator: Base modifications Part E
Date: Wed, 18 Jan 2017 18:14:35 -0800 [thread overview]
Message-ID: <cc0b019e-19e9-dfaa-314d-98a8545e7542@gmail.com> (raw)
In-Reply-To: <cefa5f07-a3f3-c5dc-2d3a-ddd410d1ffa4@suse.de>
On 1/17/2017 11:34 PM, Hannes Reinecke wrote:
> Is this ever reset?
> I don't see it here ...
the lpfc_sli4_hba_setup(), which resets the function and reinits, clears
the flag.
>
> [ .. ]
>> @@ -4380,9 +4469,12 @@ lpfc_sli_chipset_init(struct lpfc_hba *phba)
>> * configured.
>> **/
>> int
>> -lpfc_sli_hbq_count(void)
>> +lpfc_sli_hbq_count(struct lpfc_hba *phba)
>> {
>> - return ARRAY_SIZE(lpfc_hbq_defs);
>> + int i;
>> +
>> + i = ARRAY_SIZE(lpfc_hbq_defs);
>> + return i;
>> }
>>
>> /**
> The point of this change being ...?
I don't know - will collapse it.
-- james
next prev parent reply other threads:[~2017-01-19 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 1:20 [PATCH 06/17] lpfc: NVME Initiator: Base modifications Part E James Smart
2017-01-18 1:20 ` James Smart
2017-01-18 7:34 ` Hannes Reinecke
2017-01-18 7:34 ` Hannes Reinecke
2017-01-19 2:14 ` James Smart [this message]
2017-01-19 2:14 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0b019e-19e9-dfaa-314d-98a8545e7542@gmail.com \
--to=jsmart2021@gmail.com \
--cc=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.