* [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-04 15:26 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2021-04-04 15:26 UTC (permalink / raw)
To: Sven Peter
Cc: Marc Zyngier, Joerg Roedel, Will Deacon, iommu, linux-kernel,
linux-arm-kernel, kbuild-all
From: kernel test robot <lkp@intel.com>
Function apple_dart_attach_stream called on line 519 inside
lock on line 509 but uses GFP_KERNEL
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver")
CC: Sven Peter <sven@svenpeter.dev>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
Please take the patch only if it's a positive warning. Thanks!
apple-dart-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iommu/apple-dart-iommu.c
+++ b/drivers/iommu/apple-dart-iommu.c
@@ -435,7 +435,7 @@ static int apple_dart_attach_stream(stru
goto error;
}
- stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+ stream = kzalloc(sizeof(*stream), GFP_ATOMIC);
if (!stream) {
ret = -ENOMEM;
goto error;
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-04 15:26 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2021-04-04 15:26 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
From: kernel test robot <lkp@intel.com>
Function apple_dart_attach_stream called on line 519 inside
lock on line 509 but uses GFP_KERNEL
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver")
CC: Sven Peter <sven@svenpeter.dev>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
Please take the patch only if it's a positive warning. Thanks!
apple-dart-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iommu/apple-dart-iommu.c
+++ b/drivers/iommu/apple-dart-iommu.c
@@ -435,7 +435,7 @@ static int apple_dart_attach_stream(stru
goto error;
}
- stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+ stream = kzalloc(sizeof(*stream), GFP_ATOMIC);
if (!stream) {
ret = -ENOMEM;
goto error;
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-04 15:26 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2021-04-04 15:26 UTC (permalink / raw)
To: Sven Peter
Cc: Marc Zyngier, Joerg Roedel, Will Deacon, iommu, linux-kernel,
linux-arm-kernel, kbuild-all
From: kernel test robot <lkp@intel.com>
Function apple_dart_attach_stream called on line 519 inside
lock on line 509 but uses GFP_KERNEL
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver")
CC: Sven Peter <sven@svenpeter.dev>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
Please take the patch only if it's a positive warning. Thanks!
apple-dart-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iommu/apple-dart-iommu.c
+++ b/drivers/iommu/apple-dart-iommu.c
@@ -435,7 +435,7 @@ static int apple_dart_attach_stream(stru
goto error;
}
- stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+ stream = kzalloc(sizeof(*stream), GFP_ATOMIC);
if (!stream) {
ret = -ENOMEM;
goto error;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-04 15:26 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2021-04-04 15:26 UTC (permalink / raw)
To: Sven Peter
Cc: kbuild-all, Marc Zyngier, linux-kernel, iommu, Will Deacon,
linux-arm-kernel
From: kernel test robot <lkp@intel.com>
Function apple_dart_attach_stream called on line 519 inside
lock on line 509 but uses GFP_KERNEL
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver")
CC: Sven Peter <sven@svenpeter.dev>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
Please take the patch only if it's a positive warning. Thanks!
apple-dart-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iommu/apple-dart-iommu.c
+++ b/drivers/iommu/apple-dart-iommu.c
@@ -435,7 +435,7 @@ static int apple_dart_attach_stream(stru
goto error;
}
- stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+ stream = kzalloc(sizeof(*stream), GFP_ATOMIC);
if (!stream) {
ret = -ENOMEM;
goto error;
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] iommu: dart: fix call_kern.cocci warnings
2021-04-04 15:26 ` Julia Lawall
(?)
(?)
@ 2021-04-09 16:49 ` Sven Peter via iommu
-1 siblings, 0 replies; 9+ messages in thread
From: Sven Peter @ 2021-04-09 16:49 UTC (permalink / raw)
To: Julia Lawall
Cc: Marc Zyngier, Joerg Roedel, Will Deacon, Petr Mladek via iommu,
linux-kernel, linux-arm-kernel, kbuild-all
On Sun, Apr 4, 2021, at 17:26, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Function apple_dart_attach_stream called on line 519 inside
> lock on line 509 but uses GFP_KERNEL
Thanks! Fixed for v3.
Best,
Sven
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-09 16:49 ` Sven Peter via iommu
0 siblings, 0 replies; 9+ messages in thread
From: Sven Peter @ 2021-04-09 16:49 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
On Sun, Apr 4, 2021, at 17:26, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Function apple_dart_attach_stream called on line 519 inside
> lock on line 509 but uses GFP_KERNEL
Thanks! Fixed for v3.
Best,
Sven
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-09 16:49 ` Sven Peter via iommu
0 siblings, 0 replies; 9+ messages in thread
From: Sven Peter @ 2021-04-09 16:49 UTC (permalink / raw)
To: Julia Lawall
Cc: Marc Zyngier, Joerg Roedel, Will Deacon, Petr Mladek via iommu,
linux-kernel, linux-arm-kernel, kbuild-all
On Sun, Apr 4, 2021, at 17:26, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Function apple_dart_attach_stream called on line 519 inside
> lock on line 509 but uses GFP_KERNEL
Thanks! Fixed for v3.
Best,
Sven
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-09 16:49 ` Sven Peter via iommu
0 siblings, 0 replies; 9+ messages in thread
From: Sven Peter via iommu @ 2021-04-09 16:49 UTC (permalink / raw)
To: Julia Lawall
Cc: kbuild-all, Marc Zyngier, linux-kernel, Petr Mladek via iommu,
Will Deacon, linux-arm-kernel
On Sun, Apr 4, 2021, at 17:26, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Function apple_dart_attach_stream called on line 519 inside
> lock on line 509 but uses GFP_KERNEL
Thanks! Fixed for v3.
Best,
Sven
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 9+ messages in thread
* [arm-platforms:hack/m1-pcie 14/15] drivers/iommu/apple-dart-iommu.c:438:35-45: ERROR: function apple_dart_attach_stream called on line 519 inside lock on line 509 but uses GFP_KERNEL
@ 2021-04-03 19:18 kernel test robot
2021-04-03 19:18 ` [PATCH] iommu: dart: fix call_kern.cocci warnings kernel test robot
0 siblings, 1 reply; 9+ messages in thread
From: kernel test robot @ 2021-04-03 19:18 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Sven Peter <sven@svenpeter.dev>
CC: Marc Zyngier <maz@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/iommu/apple-dart-iommu.c:438:35-45: ERROR: function apple_dart_attach_stream called on line 519 inside lock on line 509 but uses GFP_KERNEL
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68952 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] iommu: dart: fix call_kern.cocci warnings
2021-04-03 19:18 [arm-platforms:hack/m1-pcie 14/15] drivers/iommu/apple-dart-iommu.c:438:35-45: ERROR: function apple_dart_attach_stream called on line 519 inside lock on line 509 but uses GFP_KERNEL kernel test robot
@ 2021-04-03 19:18 ` kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2021-04-03 19:18 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Sven Peter <sven@svenpeter.dev>
CC: Marc Zyngier <maz@kernel.org>
CC: Joerg Roedel <joro@8bytes.org>
CC: Will Deacon <will@kernel.org>
CC: iommu(a)lists.linux-foundation.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/iommu/apple-dart-iommu.c:438:35-45: ERROR: function apple_dart_attach_stream called on line 519 inside lock on line 509 but uses GFP_KERNEL
Find functions that refer to GFP_KERNEL but are called with locks held.
Semantic patch information:
The proposed change of converting the GFP_KERNEL is not necessarily the
correct one. It may be desired to unlock the lock, or to not call the
function under the lock in the first place.
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver")
CC: Sven Peter <sven@svenpeter.dev>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
Please take the patch only if it's a positive warning. Thanks!
apple-dart-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iommu/apple-dart-iommu.c
+++ b/drivers/iommu/apple-dart-iommu.c
@@ -435,7 +435,7 @@ static int apple_dart_attach_stream(stru
goto error;
}
- stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+ stream = kzalloc(sizeof(*stream), GFP_ATOMIC);
if (!stream) {
ret = -ENOMEM;
goto error;
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-04-09 16:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-04 15:26 [PATCH] iommu: dart: fix call_kern.cocci warnings Julia Lawall
2021-04-04 15:26 ` Julia Lawall
2021-04-04 15:26 ` Julia Lawall
2021-04-04 15:26 ` Julia Lawall
2021-04-09 16:49 ` Sven Peter
2021-04-09 16:49 ` Sven Peter
2021-04-09 16:49 ` Sven Peter
2021-04-09 16:49 ` Sven Peter via iommu
-- strict thread matches above, loose matches on Subject: below --
2021-04-03 19:18 [arm-platforms:hack/m1-pcie 14/15] drivers/iommu/apple-dart-iommu.c:438:35-45: ERROR: function apple_dart_attach_stream called on line 519 inside lock on line 509 but uses GFP_KERNEL kernel test robot
2021-04-03 19:18 ` [PATCH] iommu: dart: fix call_kern.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.