* [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450
@ 2023-02-03 17:04 Mukesh Ojha
2023-02-03 17:04 ` [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
2023-02-03 17:52 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Krzysztof Kozlowski
0 siblings, 2 replies; 9+ messages in thread
From: Mukesh Ojha @ 2023-02-03 17:04 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, linux-kernel, Mukesh Ojha
Add compatible for sm8450 IMEM.
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
index 665c06e..ba694ce 100644
--- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
@@ -26,6 +26,7 @@ properties:
- qcom,sdm845-imem
- qcom,sdx55-imem
- qcom,sdx65-imem
+ - qcom,sm8450-imem
- const: syscon
- const: simple-mfd
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
2023-02-03 17:04 [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Mukesh Ojha
@ 2023-02-03 17:04 ` Mukesh Ojha
2023-02-03 17:51 ` Krzysztof Kozlowski
2023-02-03 21:37 ` Konrad Dybcio
2023-02-03 17:52 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Krzysztof Kozlowski
1 sibling, 2 replies; 9+ messages in thread
From: Mukesh Ojha @ 2023-02-03 17:04 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, linux-kernel, Mukesh Ojha
Add a simple-mfd representing IMEM on SM8450 and define the PIL
relocation info region, so that post mortem tools will be able
to locate the loaded remoteprocs.
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 5704750..474ea1b 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3536,6 +3536,21 @@
};
};
+ sram@146aa000 {
+ compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
+ reg = <0 0x146aa000 0 0x1000>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ ranges = <0 0 0x146aa000 0x1000>;
+
+ pil-reloc@94c {
+ compatible = "qcom,pil-reloc-info";
+ reg = <0x94c 0xc8>;
+ };
+ };
+
apps_rsc: rsc@17a00000 {
label = "apps_rsc";
compatible = "qcom,rpmh-rsc";
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
2023-02-03 17:04 ` [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
@ 2023-02-03 17:51 ` Krzysztof Kozlowski
2023-02-03 21:37 ` Konrad Dybcio
1 sibling, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-03 17:51 UTC (permalink / raw)
To: Mukesh Ojha, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, linux-kernel
On 03/02/2023 18:04, Mukesh Ojha wrote:
> Add a simple-mfd representing IMEM on SM8450 and define the PIL
> relocation info region, so that post mortem tools will be able
> to locate the loaded remoteprocs.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 5704750..474ea1b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3536,6 +3536,21 @@
> };
> };
>
> + sram@146aa000 {
I don't think it's correct location - sorted.
> + compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
> + reg = <0 0x146aa000 0 0x1000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + ranges = <0 0 0x146aa000 0x1000>;
Put ranges after reg.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450
2023-02-03 17:04 [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Mukesh Ojha
2023-02-03 17:04 ` [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
@ 2023-02-03 17:52 ` Krzysztof Kozlowski
1 sibling, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-03 17:52 UTC (permalink / raw)
To: Mukesh Ojha, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, linux-kernel
On 03/02/2023 18:04, Mukesh Ojha wrote:
> Add compatible for sm8450 IMEM.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
2023-02-03 17:04 ` [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
2023-02-03 17:51 ` Krzysztof Kozlowski
@ 2023-02-03 21:37 ` Konrad Dybcio
2023-02-06 14:36 ` Mukesh Ojha
1 sibling, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2023-02-03 21:37 UTC (permalink / raw)
To: Mukesh Ojha, agross, andersson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, linux-kernel
On 3.02.2023 18:04, Mukesh Ojha wrote:
> Add a simple-mfd representing IMEM on SM8450 and define the PIL
> relocation info region, so that post mortem tools will be able
> to locate the loaded remoteprocs.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
From XBL:
0x14680000, 0x0002A000, "IMEM Base"
Is there anything in that wider address range that would interest
us? I recall Alex once dug into that when diving into IPA, but
I can not recall the conclusion..
Konrad
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 5704750..474ea1b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3536,6 +3536,21 @@
> };
> };
>
> + sram@146aa000 {
> + compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
> + reg = <0 0x146aa000 0 0x1000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + ranges = <0 0 0x146aa000 0x1000>;
> +
> + pil-reloc@94c {
> + compatible = "qcom,pil-reloc-info";
> + reg = <0x94c 0xc8>;
> + };
> + };
> +
> apps_rsc: rsc@17a00000 {
> label = "apps_rsc";
> compatible = "qcom,rpmh-rsc";
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
2023-02-03 21:37 ` Konrad Dybcio
@ 2023-02-06 14:36 ` Mukesh Ojha
2023-02-06 21:04 ` Bjorn Andersson
0 siblings, 1 reply; 9+ messages in thread
From: Mukesh Ojha @ 2023-02-06 14:36 UTC (permalink / raw)
To: Konrad Dybcio, agross, andersson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, linux-kernel
On 2/4/2023 3:07 AM, Konrad Dybcio wrote:
>
>
> On 3.02.2023 18:04, Mukesh Ojha wrote:
>> Add a simple-mfd representing IMEM on SM8450 and define the PIL
>> relocation info region, so that post mortem tools will be able
>> to locate the loaded remoteprocs.
>>
>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>> ---
> From XBL:
>
> 0x14680000, 0x0002A000, "IMEM Base"
>
> Is there anything in that wider address range that would interest
> us? I recall Alex once dug into that when diving into IPA, but
> I can not recall the conclusion..
Spec-wise, yes IPA do own these 0x146A8000 - 0x146AA000 .
But, not sure what they use it for.
-Mukesh
>
> Konrad
>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 5704750..474ea1b 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -3536,6 +3536,21 @@
>> };
>> };
>>
>> + sram@146aa000 {
>> + compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
>> + reg = <0 0x146aa000 0 0x1000>;
>> +
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + ranges = <0 0 0x146aa000 0x1000>;
>> +
>> + pil-reloc@94c {
>> + compatible = "qcom,pil-reloc-info";
>> + reg = <0x94c 0xc8>;
>> + };
>> + };
>> +
>> apps_rsc: rsc@17a00000 {
>> label = "apps_rsc";
>> compatible = "qcom,rpmh-rsc";
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
2023-02-06 14:36 ` Mukesh Ojha
@ 2023-02-06 21:04 ` Bjorn Andersson
2023-02-14 12:34 ` Mukesh Ojha
0 siblings, 1 reply; 9+ messages in thread
From: Bjorn Andersson @ 2023-02-06 21:04 UTC (permalink / raw)
To: Mukesh Ojha
Cc: Konrad Dybcio, agross, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel
On Mon, Feb 06, 2023 at 08:06:13PM +0530, Mukesh Ojha wrote:
>
>
> On 2/4/2023 3:07 AM, Konrad Dybcio wrote:
> >
> >
> > On 3.02.2023 18:04, Mukesh Ojha wrote:
> > > Add a simple-mfd representing IMEM on SM8450 and define the PIL
> > > relocation info region, so that post mortem tools will be able
> > > to locate the loaded remoteprocs.
> > >
> > > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> > > ---
> > From XBL:
> >
> > 0x14680000, 0x0002A000, "IMEM Base"
> >
> > Is there anything in that wider address range that would interest
> > us? I recall Alex once dug into that when diving into IPA, but
> > I can not recall the conclusion..
> Spec-wise, yes IPA do own these 0x146A8000 - 0x146AA000 .
> But, not sure what they use it for.
>
The DT should not reflect the organization structure. Let's see if Alex
have any input on this.
Thanks,
Bjorn
> -Mukesh
> >
> > Konrad
> > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
> > > 1 file changed, 15 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > index 5704750..474ea1b 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > @@ -3536,6 +3536,21 @@
> > > };
> > > };
> > > + sram@146aa000 {
> > > + compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
> > > + reg = <0 0x146aa000 0 0x1000>;
> > > +
> > > + #address-cells = <1>;
> > > + #size-cells = <1>;
> > > +
> > > + ranges = <0 0 0x146aa000 0x1000>;
> > > +
> > > + pil-reloc@94c {
> > > + compatible = "qcom,pil-reloc-info";
> > > + reg = <0x94c 0xc8>;
> > > + };
> > > + };
> > > +
> > > apps_rsc: rsc@17a00000 {
> > > label = "apps_rsc";
> > > compatible = "qcom,rpmh-rsc";
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
2023-02-06 21:04 ` Bjorn Andersson
@ 2023-02-14 12:34 ` Mukesh Ojha
2023-02-14 14:28 ` Alex Elder
0 siblings, 1 reply; 9+ messages in thread
From: Mukesh Ojha @ 2023-02-14 12:34 UTC (permalink / raw)
To: Bjorn Andersson, Alex Elder
Cc: Konrad Dybcio, agross, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel
+@alex,
Please comment.
-Mukesh
On 2/7/2023 2:34 AM, Bjorn Andersson wrote:
> On Mon, Feb 06, 2023 at 08:06:13PM +0530, Mukesh Ojha wrote:
>>
>>
>> On 2/4/2023 3:07 AM, Konrad Dybcio wrote:
>>>
>>>
>>> On 3.02.2023 18:04, Mukesh Ojha wrote:
>>>> Add a simple-mfd representing IMEM on SM8450 and define the PIL
>>>> relocation info region, so that post mortem tools will be able
>>>> to locate the loaded remoteprocs.
>>>>
>>>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>>>> ---
>>> From XBL:
>>>
>>> 0x14680000, 0x0002A000, "IMEM Base"
>>>
>>> Is there anything in that wider address range that would interest
>>> us? I recall Alex once dug into that when diving into IPA, but
>>> I can not recall the conclusion..
>> Spec-wise, yes IPA do own these 0x146A8000 - 0x146AA000 .
>> But, not sure what they use it for.
>>
>
> The DT should not reflect the organization structure. Let's see if Alex
> have any input on this.
>
> Thanks,
> Bjorn
>
>> -Mukesh
>>>
>>> Konrad
>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
>>>> 1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> index 5704750..474ea1b 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> @@ -3536,6 +3536,21 @@
>>>> };
>>>> };
>>>> + sram@146aa000 {
>>>> + compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
>>>> + reg = <0 0x146aa000 0 0x1000>;
>>>> +
>>>> + #address-cells = <1>;
>>>> + #size-cells = <1>;
>>>> +
>>>> + ranges = <0 0 0x146aa000 0x1000>;
>>>> +
>>>> + pil-reloc@94c {
>>>> + compatible = "qcom,pil-reloc-info";
>>>> + reg = <0x94c 0xc8>;
>>>> + };
>>>> + };
>>>> +
>>>> apps_rsc: rsc@17a00000 {
>>>> label = "apps_rsc";
>>>> compatible = "qcom,rpmh-rsc";
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
2023-02-14 12:34 ` Mukesh Ojha
@ 2023-02-14 14:28 ` Alex Elder
0 siblings, 0 replies; 9+ messages in thread
From: Alex Elder @ 2023-02-14 14:28 UTC (permalink / raw)
To: Mukesh Ojha, Bjorn Andersson
Cc: Konrad Dybcio, agross, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel
On 2/14/23 6:34 AM, Mukesh Ojha wrote:
> +@alex,
>
> Please comment.
>
> -Mukesh
>
> On 2/7/2023 2:34 AM, Bjorn Andersson wrote:
>> On Mon, Feb 06, 2023 at 08:06:13PM +0530, Mukesh Ojha wrote:
>>>
>>>
>>> On 2/4/2023 3:07 AM, Konrad Dybcio wrote:
>>>>
>>>>
>>>> On 3.02.2023 18:04, Mukesh Ojha wrote:
>>>>> Add a simple-mfd representing IMEM on SM8450 and define the PIL
>>>>> relocation info region, so that post mortem tools will be able
>>>>> to locate the loaded remoteprocs.
>>>>>
>>>>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>>>>> ---
>>>> From XBL:
>>>>
>>>> 0x14680000, 0x0002A000, "IMEM Base"
>>>>
>>>> Is there anything in that wider address range that would interest
>>>> us? I recall Alex once dug into that when diving into IPA, but
>>>> I can not recall the conclusion..
So you're saying a boot loader defines "IMEM Base" as
a range of memory, size 0x2a000.
>>> Spec-wise, yes IPA do own these 0x146A8000 - 0x146AA000 .
>>> But, not sure what they use it for.
And a subset of that range (at offset 0x28000, size 0x2000) is
set aside for use by IPA. IPA *does* use this memory area as
"fast" memory to hold certain frequently-accessed tables.
Details of that are under the modem's control, and I don't
have knowledge of that.
The IPA driver currently maps it's portion of this memory,
but does *not* reflect that use in DT. (This is something
that will be corrected at some point, possibly soon.)
>> The DT should not reflect the organization structure. Let's see if Alex
>> have any input on this.
As I understand it there's an "imem" node in DT defined, but
it just defines the range of memory, and is something referred
to by other drivers (or other nodes in a DTS file). This seems
reasonable, and it kind of matches the view I've seen in
documents. IPA does *not* follow that pattern, and should.
I don't really have any strong input either way. I can help
define the "problem" but I don't claim to know the correct
way to represent this.
It's a contiguous block of special memory. By convention
(design) its range divided up, with portions intended to be
used for different purposes, by different hardware. IPA is
one of the users.
-Alex
>>
>> Thanks,
>> Bjorn
>>
>>> -Mukesh
>>>>
>>>> Konrad
>>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
>>>>> 1 file changed, 15 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> index 5704750..474ea1b 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> @@ -3536,6 +3536,21 @@
>>>>> };
>>>>> };
>>>>> + sram@146aa000 {
>>>>> + compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
>>>>> + reg = <0 0x146aa000 0 0x1000>;
>>>>> +
>>>>> + #address-cells = <1>;
>>>>> + #size-cells = <1>;
>>>>> +
>>>>> + ranges = <0 0 0x146aa000 0x1000>;
>>>>> +
>>>>> + pil-reloc@94c {
>>>>> + compatible = "qcom,pil-reloc-info";
>>>>> + reg = <0x94c 0xc8>;
>>>>> + };
>>>>> + };
>>>>> +
>>>>> apps_rsc: rsc@17a00000 {
>>>>> label = "apps_rsc";
>>>>> compatible = "qcom,rpmh-rsc";
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-14 14:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 17:04 [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Mukesh Ojha
2023-02-03 17:04 ` [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
2023-02-03 17:51 ` Krzysztof Kozlowski
2023-02-03 21:37 ` Konrad Dybcio
2023-02-06 14:36 ` Mukesh Ojha
2023-02-06 21:04 ` Bjorn Andersson
2023-02-14 12:34 ` Mukesh Ojha
2023-02-14 14:28 ` Alex Elder
2023-02-03 17:52 ` [PATCH 1/2] dt-bindings: sram: qcom,imem: document sm8450 Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.