* [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by
@ 2023-09-22 17:52 Kees Cook
2023-09-23 16:34 ` Gustavo A. R. Silva
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kees Cook @ 2023-09-22 17:52 UTC (permalink / raw)
To: Support Opensource
Cc: Kees Cook, Liam Girdwood, Mark Brown, Nathan Chancellor,
Nick Desaulniers, Tom Rix, linux-kernel, llvm, linux-hardening
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct da9063_regulators.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/regulator/da9063-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index a0621665a6d2..82bf321ae06f 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -158,7 +158,7 @@ struct da9063_regulator {
struct da9063_regulators {
unsigned int n_regulators;
/* Array size to be defined during init. Keep at end. */
- struct da9063_regulator regulator[];
+ struct da9063_regulator regulator[] __counted_by(n_regulators);
};
/* BUCK modes for DA9063 */
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by
2023-09-22 17:52 [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by Kees Cook
@ 2023-09-23 16:34 ` Gustavo A. R. Silva
2023-10-06 20:40 ` Kees Cook
2023-10-11 14:50 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2023-09-23 16:34 UTC (permalink / raw)
To: Kees Cook, Support Opensource
Cc: Liam Girdwood, Mark Brown, Nathan Chancellor, Nick Desaulniers,
Tom Rix, linux-kernel, llvm, linux-hardening
On 9/22/23 11:52, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct da9063_regulators.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Support Opensource <support.opensource@diasemi.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> drivers/regulator/da9063-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index a0621665a6d2..82bf321ae06f 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -158,7 +158,7 @@ struct da9063_regulator {
> struct da9063_regulators {
> unsigned int n_regulators;
> /* Array size to be defined during init. Keep at end. */
> - struct da9063_regulator regulator[];
> + struct da9063_regulator regulator[] __counted_by(n_regulators);
> };
>
> /* BUCK modes for DA9063 */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by
2023-09-22 17:52 [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by Kees Cook
2023-09-23 16:34 ` Gustavo A. R. Silva
@ 2023-10-06 20:40 ` Kees Cook
2023-10-06 20:56 ` Mark Brown
2023-10-11 14:50 ` Mark Brown
2 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2023-10-06 20:40 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Support Opensource, Nathan Chancellor,
Nick Desaulniers, Tom Rix, linux-kernel, llvm, linux-hardening
On Fri, Sep 22, 2023 at 10:52:07AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct da9063_regulators.
Friendly ping. Mark can you pick this up?
Thanks!
-Kees
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Support Opensource <support.opensource@diasemi.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/regulator/da9063-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index a0621665a6d2..82bf321ae06f 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -158,7 +158,7 @@ struct da9063_regulator {
> struct da9063_regulators {
> unsigned int n_regulators;
> /* Array size to be defined during init. Keep at end. */
> - struct da9063_regulator regulator[];
> + struct da9063_regulator regulator[] __counted_by(n_regulators);
> };
>
> /* BUCK modes for DA9063 */
> --
> 2.34.1
>
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by
2023-10-06 20:40 ` Kees Cook
@ 2023-10-06 20:56 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2023-10-06 20:56 UTC (permalink / raw)
To: Kees Cook
Cc: Liam Girdwood, Support Opensource, Nathan Chancellor,
Nick Desaulniers, Tom Rix, linux-kernel, llvm, linux-hardening
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
On Fri, Oct 06, 2023 at 01:40:08PM -0700, Kees Cook wrote:
> On Fri, Sep 22, 2023 at 10:52:07AM -0700, Kees Cook wrote:
> > Prepare for the coming implementation by GCC and Clang of the __counted_by
> > attribute. Flexible array members annotated with __counted_by can have
> > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> > functions).
> >
> > As found with Coccinelle[1], add __counted_by for struct da9063_regulators.
> Friendly ping. Mark can you pick this up?
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by
2023-09-22 17:52 [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by Kees Cook
2023-09-23 16:34 ` Gustavo A. R. Silva
2023-10-06 20:40 ` Kees Cook
@ 2023-10-11 14:50 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2023-10-11 14:50 UTC (permalink / raw)
To: Support Opensource, Kees Cook
Cc: Liam Girdwood, Nathan Chancellor, Nick Desaulniers, Tom Rix,
linux-kernel, llvm, linux-hardening
On Fri, 22 Sep 2023 10:52:07 -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct da9063_regulators.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: da9063: Annotate struct da9063_regulators with __counted_by
commit: 1096f9fa2be18a1340d1299b4c4329af211076e7
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-11 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-22 17:52 [PATCH] regulator: da9063: Annotate struct da9063_regulators with __counted_by Kees Cook
2023-09-23 16:34 ` Gustavo A. R. Silva
2023-10-06 20:40 ` Kees Cook
2023-10-06 20:56 ` Mark Brown
2023-10-11 14:50 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.