* sdio_f0_readb()
@ 2017-07-13 16:04 Ian Molton
2017-07-14 9:12 ` sdio_f0_readb() Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Ian Molton @ 2017-07-13 16:04 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc
Hi folks,
What is the function sdio_f0_readb() so special for? it seems to be used
by a tiny handful of drivers and is equivalent to sdio_readb() with the
function parameter set to 0.
Its twin sdio_f0_writeb() does some very minimal checking for register
bounds.
Is it really worth all this abstraction for a few (usually wifi)
drivers? surely the driver knows which registers it should touch anyway?
its not like most bus drivers perform this sort of checking...
Should this be done away with before more drivers start using it? I'm
happy to submit a patch to remove sdio_f0*()
-Ian
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sdio_f0_readb()
2017-07-13 16:04 sdio_f0_readb() Ian Molton
@ 2017-07-14 9:12 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2017-07-14 9:12 UTC (permalink / raw)
To: Ian Molton; +Cc: linux-mmc
On 13 July 2017 at 18:04, Ian Molton <ian@mnementh.co.uk> wrote:
> Hi folks,
>
>
> What is the function sdio_f0_readb() so special for? it seems to be used
> by a tiny handful of drivers and is equivalent to sdio_readb() with the
> function parameter set to 0.
>
> Its twin sdio_f0_writeb() does some very minimal checking for register
> bounds.
>
> Is it really worth all this abstraction for a few (usually wifi)
> drivers? surely the driver knows which registers it should touch anyway?
> its not like most bus drivers perform this sort of checking...
>
> Should this be done away with before more drivers start using it? I'm
> happy to submit a patch to remove sdio_f0*()
Why not just submit the patch - and let people discuss about it? :-)
Kind regards
Uffe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-14 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13 16:04 sdio_f0_readb() Ian Molton
2017-07-14 9:12 ` sdio_f0_readb() Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.