Bluetooth: might sleep error in hidp_session_thread

Bluetooth: might sleep error in hidp_session_thread

[Rohit Vaswani]

Hi Jeffy,

I was looking into the patch from Jeffy Chen from February 14 2017  : 
 [v4,3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread: https://patchwork.kernel.org/patch/9570931/

We faced a similar issue and this patch seems to fix the problem in our preliminary test.
I am trying to check if there was a reason this wasn't merged earlier ?

Thanks,
Rohit

nvpublic

Bluetooth: might sleep error in hidp_session_thread

[Rohit Vaswani]

Hi Jeffy,

I was looking into the patch from Jeffy Chen from February 14 2017  :=20
 [v4,3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_t=
hread: https://patchwork.kernel.org/patch/9570931/

We faced a similar issue and this patch seems to fix the problem in our pre=
liminary test.
I am trying to check if there was a reason this wasn't merged earlier ?

Thanks,
Rohit

nvpublic

Re: Bluetooth: might sleep error in hidp_session_thread

[jeffy]

Hi Rohit,

Thanx for your reply, and sorry to the delay, somehow your mail was 
marked as spam by the mail server :(

On 06/13/2017 02:31 AM, Rohit Vaswani wrote:
> Hi Jeffy,
>
> I was looking into the patch from Jeffy Chen from February 14 2017  :
>   [v4,3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread: https://patchwork.kernel.org/patch/9570931/
>
> We faced a similar issue and this patch seems to fix the problem in our preliminary test.
> I am trying to check if there was a reason this wasn't merged earlier ?

hmm, i'm not sure why, but please feel free to add your test-by~
>
> Thanks,
> Rohit
>
> nvpublic
>
>
>

RE: Bluetooth: might sleep error in hidp_session_thread

[Rohit Vaswani]

I don't have a way to reply back to the older message; but you can use by tested-by for the below patch and re-send:

For patch: [v4,3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread

Tested-by: Rohit Vaswani <rvaswani@nvidia.com>

-Rohit

-----Original Message-----
From: jeffy [mailto:jeffy.chen@rock-chips.com] 
Sent: Friday, June 23, 2017 05:39
To: Rohit Vaswani; linux-bluetooth@vger.kernel.org
Cc: Brian Norris; Douglas Anderson; Johan Hedberg; Peter Hurley; Johan Hedberg; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller; Marcel Holtmann; Gustavo Padovan
Subject: Re: Bluetooth: might sleep error in hidp_session_thread

Hi Rohit,

Thanx for your reply, and sorry to the delay, somehow your mail was marked as spam by the mail server :(

On 06/13/2017 02:31 AM, Rohit Vaswani wrote:
> Hi Jeffy,
>
> I was looking into the patch from Jeffy Chen from February 14 2017  :
>   [v4,3/3] Bluetooth: hidp: fix possible might sleep error in 
> hidp_session_thread: https://patchwork.kernel.org/patch/9570931/
>
> We faced a similar issue and this patch seems to fix the problem in our preliminary test.
> I am trying to check if there was a reason this wasn't merged earlier ?

hmm, i'm not sure why, but please feel free to add your test-by~
>
> Thanks,
> Rohit
>
> nvpublic
>
>
>

RE: Bluetooth: might sleep error in hidp_session_thread

[Rohit Vaswani]

SSBkb24ndCBoYXZlIGEgd2F5IHRvIHJlcGx5IGJhY2sgdG8gdGhlIG9sZGVyIG1lc3NhZ2U7IGJ1
dCB5b3UgY2FuIHVzZSBieSB0ZXN0ZWQtYnkgZm9yIHRoZSBiZWxvdyBwYXRjaCBhbmQgcmUtc2Vu
ZDoNCg0KRm9yIHBhdGNoOiBbdjQsMy8zXSBCbHVldG9vdGg6IGhpZHA6IGZpeCBwb3NzaWJsZSBt
aWdodCBzbGVlcCBlcnJvciBpbiBoaWRwX3Nlc3Npb25fdGhyZWFkDQoNClRlc3RlZC1ieTogUm9o
aXQgVmFzd2FuaSA8cnZhc3dhbmlAbnZpZGlhLmNvbT4NCg0KLVJvaGl0DQoNCi0tLS0tT3JpZ2lu
YWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBqZWZmeSBbbWFpbHRvOmplZmZ5LmNoZW5Acm9jay1jaGlw
cy5jb21dIA0KU2VudDogRnJpZGF5LCBKdW5lIDIzLCAyMDE3IDA1OjM5DQpUbzogUm9oaXQgVmFz
d2FuaTsgbGludXgtYmx1ZXRvb3RoQHZnZXIua2VybmVsLm9yZw0KQ2M6IEJyaWFuIE5vcnJpczsg
RG91Z2xhcyBBbmRlcnNvbjsgSm9oYW4gSGVkYmVyZzsgUGV0ZXIgSHVybGV5OyBKb2hhbiBIZWRi
ZXJnOyBuZXRkZXZAdmdlci5rZXJuZWwub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3Jn
OyBEYXZpZCBTLiBNaWxsZXI7IE1hcmNlbCBIb2x0bWFubjsgR3VzdGF2byBQYWRvdmFuDQpTdWJq
ZWN0OiBSZTogQmx1ZXRvb3RoOiBtaWdodCBzbGVlcCBlcnJvciBpbiBoaWRwX3Nlc3Npb25fdGhy
ZWFkDQoNCkhpIFJvaGl0LA0KDQpUaGFueCBmb3IgeW91ciByZXBseSwgYW5kIHNvcnJ5IHRvIHRo
ZSBkZWxheSwgc29tZWhvdyB5b3VyIG1haWwgd2FzIG1hcmtlZCBhcyBzcGFtIGJ5IHRoZSBtYWls
IHNlcnZlciA6KA0KDQpPbiAwNi8xMy8yMDE3IDAyOjMxIEFNLCBSb2hpdCBWYXN3YW5pIHdyb3Rl
Og0KPiBIaSBKZWZmeSwNCj4NCj4gSSB3YXMgbG9va2luZyBpbnRvIHRoZSBwYXRjaCBmcm9tIEpl
ZmZ5IENoZW4gZnJvbSBGZWJydWFyeSAxNCAyMDE3ICA6DQo+ICAgW3Y0LDMvM10gQmx1ZXRvb3Ro
OiBoaWRwOiBmaXggcG9zc2libGUgbWlnaHQgc2xlZXAgZXJyb3IgaW4gDQo+IGhpZHBfc2Vzc2lv
bl90aHJlYWQ6IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTU3MDkzMS8NCj4N
Cj4gV2UgZmFjZWQgYSBzaW1pbGFyIGlzc3VlIGFuZCB0aGlzIHBhdGNoIHNlZW1zIHRvIGZpeCB0
aGUgcHJvYmxlbSBpbiBvdXIgcHJlbGltaW5hcnkgdGVzdC4NCj4gSSBhbSB0cnlpbmcgdG8gY2hl
Y2sgaWYgdGhlcmUgd2FzIGEgcmVhc29uIHRoaXMgd2Fzbid0IG1lcmdlZCBlYXJsaWVyID8NCg0K
aG1tLCBpJ20gbm90IHN1cmUgd2h5LCBidXQgcGxlYXNlIGZlZWwgZnJlZSB0byBhZGQgeW91ciB0
ZXN0LWJ5fg0KPg0KPiBUaGFua3MsDQo+IFJvaGl0DQo+DQo+IG52cHVibGljDQo+DQo+DQo+DQoN
Cg0K

Re: Bluetooth: might sleep error in hidp_session_thread

[jeffy]

Hi Rohit,

On 06/24/2017 02:00 AM, Rohit Vaswani wrote:
> I don't have a way to reply back to the older message; but you can use by tested-by for the below patch and re-send:
>
ok, i've resent it, thanks for your test by~

and for replying to an old message, i've figured it out when i tried to 
do that recently:

1/ download the mbox file from the patchwork 
link(https://patchwork.kernel.org/patch/***)
2/ rename it to .mbox
3/ import into thunerbird(using ImportExportTools)

hope that helps ;)

> For patch: [v4,3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread
>
> Tested-by: Rohit Vaswani <rvaswani@nvidia.com>
>
> -Rohit
>
> -----Original Message-----
> From: jeffy [mailto:jeffy.chen@rock-chips.com]
> Sent: Friday, June 23, 2017 05:39
> To: Rohit Vaswani; linux-bluetooth@vger.kernel.org
> Cc: Brian Norris; Douglas Anderson; Johan Hedberg; Peter Hurley; Johan Hedberg; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller; Marcel Holtmann; Gustavo Padovan
> Subject: Re: Bluetooth: might sleep error in hidp_session_thread
>
> Hi Rohit,
>
> Thanx for your reply, and sorry to the delay, somehow your mail was marked as spam by the mail server :(
>
> On 06/13/2017 02:31 AM, Rohit Vaswani wrote:
>> Hi Jeffy,
>>
>> I was looking into the patch from Jeffy Chen from February 14 2017  :
>>    [v4,3/3] Bluetooth: hidp: fix possible might sleep error in
>> hidp_session_thread: https://patchwork.kernel.org/patch/9570931/
>>
>> We faced a similar issue and this patch seems to fix the problem in our preliminary test.
>> I am trying to check if there was a reason this wasn't merged earlier ?
>
> hmm, i'm not sure why, but please feel free to add your test-by~
>>
>> Thanks,
>> Rohit
>>
>> nvpublic
>>
>>
>>
>
>

Re: Bluetooth: might sleep error in hidp_session_thread

[jeffy]

Hi Rohit,

On 06/24/2017 02:00 AM, Rohit Vaswani wrote:
> I don't have a way to reply back to the older message; but you can use by tested-by for the below patch and re-send:
>
ok, i've resent it, thanks for your test by~

and for replying to an old message, i've figured it out when i tried to 
do that recently:

1/ download the mbox file from the patchwork 
link(https://patchwork.kernel.org/patch/***)
2/ rename it to .mbox
3/ import into thunerbird(using ImportExportTools)

hope that helps ;)

> For patch: [v4,3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread
>
> Tested-by: Rohit Vaswani <rvaswani-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> -Rohit
>
> -----Original Message-----
> From: jeffy [mailto:jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org]
> Sent: Friday, June 23, 2017 05:39
> To: Rohit Vaswani; linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Brian Norris; Douglas Anderson; Johan Hedberg; Peter Hurley; Johan Hedberg; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; David S. Miller; Marcel Holtmann; Gustavo Padovan
> Subject: Re: Bluetooth: might sleep error in hidp_session_thread
>
> Hi Rohit,
>
> Thanx for your reply, and sorry to the delay, somehow your mail was marked as spam by the mail server :(
>
> On 06/13/2017 02:31 AM, Rohit Vaswani wrote:
>> Hi Jeffy,
>>
>> I was looking into the patch from Jeffy Chen from February 14 2017  :
>>    [v4,3/3] Bluetooth: hidp: fix possible might sleep error in
>> hidp_session_thread: https://patchwork.kernel.org/patch/9570931/
>>
>> We faced a similar issue and this patch seems to fix the problem in our preliminary test.
>> I am trying to check if there was a reason this wasn't merged earlier ?
>
> hmm, i'm not sure why, but please feel free to add your test-by~
>>
>> Thanks,
>> Rohit
>>
>> nvpublic
>>
>>
>>
>
>