* ALC236 recording issue
@ 2021-10-05 6:55 Kailang
2021-10-05 8:11 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Kailang @ 2021-10-05 6:55 UTC (permalink / raw)
To: Takashi Iwai (tiwai@suse.de); +Cc: (alsa-devel@alsa-project.org)
[-- Attachment #1: Type: text/plain, Size: 112 bytes --]
Hi Takashi,
Attach patch will solve alc236 recording issue for HP platform.
Many Thanks.
BR,
Kailang
[-- Attachment #2: 0000-alc236-headset-mic-delay.patch --]
[-- Type: application/octet-stream, Size: 1435 bytes --]
From 0a51c04b79f4baf7c368b9682aca211d67886cba Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Tue, 5 Oct 2021 14:35:14 +0800
Subject: [PATCH] ALSA: hda/realtek - ALC236 headset MIC recording issue
In power save mode, the recording voice from headset mic will 2s more delay.
Add this patch will solve this issue.
Signed-off-by: Kailang Yang <kailang@realtek.com>
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0331fae5525e..12208bdfd2df 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -526,6 +526,8 @@ static void alc_shutup_pins(struct hda_codec *codec)
struct alc_spec *spec = codec->spec;
switch (codec->core.vendor_id) {
+ case 0x10ec0236:
+ case 0x10ec0256:
case 0x10ec0283:
case 0x10ec0286:
case 0x10ec0288:
@@ -3529,8 +3531,9 @@ static void alc256_shutup(struct hda_codec *codec)
/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
* when booting with headset plugged. So skip setting it for the codec alc257
*/
- if (codec->core.vendor_id != 0x10ec0257)
- alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
+ if (spec->codec_variant != ALC269_TYPE_ALC257 &&
+ spec->codec_variant != ALC269_TYPE_ALC256)
+ alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
if (!spec->no_shutup_pins)
snd_hda_codec_write(codec, hp_pin, 0,
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: ALC236 recording issue
2021-10-05 6:55 ALC236 recording issue Kailang
@ 2021-10-05 8:11 ` Takashi Iwai
2021-10-06 9:14 ` Kailang
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2021-10-05 8:11 UTC (permalink / raw)
To: Kailang; +Cc: (alsa-devel@alsa-project.org)
On Tue, 05 Oct 2021 08:55:14 +0200,
Kailang wrote:
>
> Hi Takashi,
>
> Attach patch will solve alc236 recording issue for HP platform.
>
> Many Thanks.
>
> BR,
> Kailang
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: ALC236 recording issue
2021-10-05 8:11 ` Takashi Iwai
@ 2021-10-06 9:14 ` Kailang
2021-10-06 10:44 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Kailang @ 2021-10-06 9:14 UTC (permalink / raw)
To: Takashi Iwai; +Cc: (alsa-devel@alsa-project.org)
Hi Takashi,
I couldn't find this apply record on git.kernel.org.
HP guy want me to provide the patch URL.
BR,
Kailang
> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Tuesday, October 5, 2021 4:12 PM
> To: Kailang <kailang@realtek.com>
> Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> Subject: Re: ALC236 recording issue
>
> On Tue, 05 Oct 2021 08:55:14 +0200,
> Kailang wrote:
> >
> > Hi Takashi,
> >
> > Attach patch will solve alc236 recording issue for HP platform.
> >
> > Many Thanks.
> >
> > BR,
> > Kailang
>
> Applied now. Thanks.
>
>
> Takashi
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ALC236 recording issue
2021-10-06 9:14 ` Kailang
@ 2021-10-06 10:44 ` Takashi Iwai
2021-10-07 6:15 ` Kailang
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2021-10-06 10:44 UTC (permalink / raw)
To: Kailang; +Cc: (alsa-devel@alsa-project.org)
On Wed, 06 Oct 2021 11:14:40 +0200,
Kailang wrote:
>
> Hi Takashi,
>
> I couldn't find this apply record on git.kernel.org.
> HP guy want me to provide the patch URL.
It wasn't pushed out properly, sorry. Now it's public, found in the
commit 5aec98913095ed3b4424ed6c5fdeb6964e9734da.
Takashi
>
> BR,
> Kailang
>
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Tuesday, October 5, 2021 4:12 PM
> > To: Kailang <kailang@realtek.com>
> > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > Subject: Re: ALC236 recording issue
> >
> > On Tue, 05 Oct 2021 08:55:14 +0200,
> > Kailang wrote:
> > >
> > > Hi Takashi,
> > >
> > > Attach patch will solve alc236 recording issue for HP platform.
> > >
> > > Many Thanks.
> > >
> > > BR,
> > > Kailang
> >
> > Applied now. Thanks.
> >
> >
> > Takashi
> > ------Please consider the environment before printing this e-mail.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: ALC236 recording issue
2021-10-06 10:44 ` Takashi Iwai
@ 2021-10-07 6:15 ` Kailang
0 siblings, 0 replies; 5+ messages in thread
From: Kailang @ 2021-10-07 6:15 UTC (permalink / raw)
To: Takashi Iwai; +Cc: (alsa-devel@alsa-project.org)
Many Thanks. ^^
> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Wednesday, October 6, 2021 6:44 PM
> To: Kailang <kailang@realtek.com>
> Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> Subject: Re: ALC236 recording issue
>
> On Wed, 06 Oct 2021 11:14:40 +0200,
> Kailang wrote:
> >
> > Hi Takashi,
> >
> > I couldn't find this apply record on git.kernel.org.
> > HP guy want me to provide the patch URL.
>
> It wasn't pushed out properly, sorry. Now it's public, found in the commit
> 5aec98913095ed3b4424ed6c5fdeb6964e9734da.
>
>
> Takashi
>
> >
> > BR,
> > Kailang
> >
> > > -----Original Message-----
> > > From: Takashi Iwai <tiwai@suse.de>
> > > Sent: Tuesday, October 5, 2021 4:12 PM
> > > To: Kailang <kailang@realtek.com>
> > > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > > Subject: Re: ALC236 recording issue
> > >
> > > On Tue, 05 Oct 2021 08:55:14 +0200,
> > > Kailang wrote:
> > > >
> > > > Hi Takashi,
> > > >
> > > > Attach patch will solve alc236 recording issue for HP platform.
> > > >
> > > > Many Thanks.
> > > >
> > > > BR,
> > > > Kailang
> > >
> > > Applied now. Thanks.
> > >
> > >
> > > Takashi
> > > ------Please consider the environment before printing this e-mail.
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-07 6:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-05 6:55 ALC236 recording issue Kailang
2021-10-05 8:11 ` Takashi Iwai
2021-10-06 9:14 ` Kailang
2021-10-06 10:44 ` Takashi Iwai
2021-10-07 6:15 ` Kailang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.