* [PATCH 1/3] drm/msm/dpu: Remove set but unused variables
@ 2022-02-10 11:41 ` Vinod Koul
0 siblings, 0 replies; 18+ messages in thread
From: Vinod Koul @ 2022-02-10 11:41 UTC (permalink / raw)
To: Rob Clark
Cc: Kalyan Thota, freedreno, linux-kernel, David Airlie,
linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel,
Bjorn Andersson, Vinod Koul, Dmitry Baryshkov, Stephen Boyd,
Sean Paul, Guenter Roeck, Mark Yacoub
We get warning:
In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33:
warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
1145 | struct msm_drm_private *priv;
In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1182:33:
warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
1182 | struct msm_drm_private *priv;
Remove these unused but set variables
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 1e648db439f9..132844801e92 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -1142,14 +1142,12 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
{
struct dpu_encoder_virt *dpu_enc = NULL;
int ret = 0;
- struct msm_drm_private *priv;
struct drm_display_mode *cur_mode = NULL;
dpu_enc = to_dpu_encoder_virt(drm_enc);
mutex_lock(&dpu_enc->enc_lock);
cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
- priv = drm_enc->dev->dev_private;
trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
cur_mode->vdisplay);
@@ -1179,7 +1177,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
{
struct dpu_encoder_virt *dpu_enc = NULL;
- struct msm_drm_private *priv;
int i = 0;
dpu_enc = to_dpu_encoder_virt(drm_enc);
@@ -1188,8 +1185,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
mutex_lock(&dpu_enc->enc_lock);
dpu_enc->enabled = false;
- priv = drm_enc->dev->dev_private;
-
trace_dpu_enc_disable(DRMID(drm_enc));
/* wait for idle */
--
2.31.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 2/3] drm/msm/dpu: Update the comment style
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-10 11:41 ` Vinod Koul
-1 siblings, 0 replies; 18+ messages in thread
From: Vinod Koul @ 2022-02-10 11:41 UTC (permalink / raw)
To: Rob Clark
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Sean Paul,
Abhinav Kumar, David Airlie, Daniel Vetter, Dmitry Baryshkov,
Stephen Boyd, Kuogee Hsieh, Guenter Roeck, Kalyan Thota,
Mark Yacoub, dri-devel, freedreno
The multi line comment style is wrongly used as kernel-doc comment. This
gives a warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17:
warning: This comment starts with '/**', but isn't a kernel-doc comment.
Refer Documentation/doc-guide/kernel-doc.rst
Update the style to fix this.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
index a77a5eaa78ad..9341c88a336f 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
@@ -13,7 +13,7 @@
#include "dpu_hw_mdss.h"
#include "dpu_trace.h"
-/**
+/*
* Register offsets in MDSS register file for the interrupt registers
* w.r.t. to the MDP base
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/3] drm/msm/dpu: Update the comment style
@ 2022-02-10 11:41 ` Vinod Koul
0 siblings, 0 replies; 18+ messages in thread
From: Vinod Koul @ 2022-02-10 11:41 UTC (permalink / raw)
To: Rob Clark
Cc: Kalyan Thota, freedreno, David Airlie, linux-arm-msm,
Kuogee Hsieh, Abhinav Kumar, dri-devel, Bjorn Andersson,
Vinod Koul, Dmitry Baryshkov, Stephen Boyd, Sean Paul,
Guenter Roeck, Mark Yacoub
The multi line comment style is wrongly used as kernel-doc comment. This
gives a warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17:
warning: This comment starts with '/**', but isn't a kernel-doc comment.
Refer Documentation/doc-guide/kernel-doc.rst
Update the style to fix this.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
index a77a5eaa78ad..9341c88a336f 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
@@ -13,7 +13,7 @@
#include "dpu_hw_mdss.h"
#include "dpu_trace.h"
-/**
+/*
* Register offsets in MDSS register file for the interrupt registers
* w.r.t. to the MDP base
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] drm/msm/dpu: Update the comment style
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-11 1:58 ` Dmitry Baryshkov
-1 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2022-02-11 1:58 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: linux-arm-msm, Bjorn Andersson, Sean Paul, Abhinav Kumar,
David Airlie, Daniel Vetter, Stephen Boyd, Kuogee Hsieh,
Guenter Roeck, Kalyan Thota, Mark Yacoub, dri-devel, freedreno
On 10/02/2022 14:41, Vinod Koul wrote:
> The multi line comment style is wrongly used as kernel-doc comment. This
> gives a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17:
> warning: This comment starts with '/**', but isn't a kernel-doc comment.
> Refer Documentation/doc-guide/kernel-doc.rst
>
> Update the style to fix this.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index a77a5eaa78ad..9341c88a336f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -13,7 +13,7 @@
> #include "dpu_hw_mdss.h"
> #include "dpu_trace.h"
>
> -/**
> +/*
> * Register offsets in MDSS register file for the interrupt registers
> * w.r.t. to the MDP base
> */
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] drm/msm/dpu: Update the comment style
@ 2022-02-11 1:58 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2022-02-11 1:58 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: Kalyan Thota, freedreno, David Airlie, linux-arm-msm,
Kuogee Hsieh, Abhinav Kumar, dri-devel, Bjorn Andersson,
Stephen Boyd, Sean Paul, Guenter Roeck, Mark Yacoub
On 10/02/2022 14:41, Vinod Koul wrote:
> The multi line comment style is wrongly used as kernel-doc comment. This
> gives a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17:
> warning: This comment starts with '/**', but isn't a kernel-doc comment.
> Refer Documentation/doc-guide/kernel-doc.rst
>
> Update the style to fix this.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index a77a5eaa78ad..9341c88a336f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -13,7 +13,7 @@
> #include "dpu_hw_mdss.h"
> #include "dpu_trace.h"
>
> -/**
> +/*
> * Register offsets in MDSS register file for the interrupt registers
> * w.r.t. to the MDP base
> */
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] drm/msm/dpu: Update the comment style
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-11 2:26 ` Abhinav Kumar
-1 siblings, 0 replies; 18+ messages in thread
From: Abhinav Kumar @ 2022-02-11 2:26 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: linux-arm-msm, Bjorn Andersson, Sean Paul, David Airlie,
Daniel Vetter, Dmitry Baryshkov, Stephen Boyd, Kuogee Hsieh,
Guenter Roeck, Kalyan Thota, Mark Yacoub, dri-devel, freedreno
On 2/10/2022 3:41 AM, Vinod Koul wrote:
> The multi line comment style is wrongly used as kernel-doc comment. This
> gives a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17:
> warning: This comment starts with '/**', but isn't a kernel-doc comment.
> Refer Documentation/doc-guide/kernel-doc.rst
>
> Update the style to fix this.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index a77a5eaa78ad..9341c88a336f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -13,7 +13,7 @@
> #include "dpu_hw_mdss.h"
> #include "dpu_trace.h"
>
> -/**
> +/*
> * Register offsets in MDSS register file for the interrupt registers
> * w.r.t. to the MDP base
> */
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] drm/msm/dpu: Update the comment style
@ 2022-02-11 2:26 ` Abhinav Kumar
0 siblings, 0 replies; 18+ messages in thread
From: Abhinav Kumar @ 2022-02-11 2:26 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: Kalyan Thota, freedreno, David Airlie, linux-arm-msm,
Kuogee Hsieh, dri-devel, Bjorn Andersson, Dmitry Baryshkov,
Stephen Boyd, Sean Paul, Guenter Roeck, Mark Yacoub
On 2/10/2022 3:41 AM, Vinod Koul wrote:
> The multi line comment style is wrongly used as kernel-doc comment. This
> gives a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17:
> warning: This comment starts with '/**', but isn't a kernel-doc comment.
> Refer Documentation/doc-guide/kernel-doc.rst
>
> Update the style to fix this.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index a77a5eaa78ad..9341c88a336f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -13,7 +13,7 @@
> #include "dpu_hw_mdss.h"
> #include "dpu_trace.h"
>
> -/**
> +/*
> * Register offsets in MDSS register file for the interrupt registers
> * w.r.t. to the MDP base
> */
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 3/3] drm/msm/dpu: Update function parameter documentation
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-10 11:41 ` Vinod Koul
-1 siblings, 0 replies; 18+ messages in thread
From: Vinod Koul @ 2022-02-10 11:41 UTC (permalink / raw)
To: Rob Clark
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Sean Paul,
Abhinav Kumar, David Airlie, Daniel Vetter, Dmitry Baryshkov,
Stephen Boyd, Kuogee Hsieh, Guenter Roeck, Kalyan Thota,
Mark Yacoub, dri-devel, freedreno
dpu_core_irq_callback_handler() function comments seem to have become
stale and emit a warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler'
Fix by updating the documentation
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
index 9341c88a336f..27073fd49fee 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
@@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
/**
* dpu_core_irq_callback_handler - dispatch core interrupts
- * @arg: private data of callback handler
+ * @dpu_kms: Pointer to DPU's KMS structure
* @irq_idx: interrupt index
*/
static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
--
2.31.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 3/3] drm/msm/dpu: Update function parameter documentation
@ 2022-02-10 11:41 ` Vinod Koul
0 siblings, 0 replies; 18+ messages in thread
From: Vinod Koul @ 2022-02-10 11:41 UTC (permalink / raw)
To: Rob Clark
Cc: Kalyan Thota, freedreno, David Airlie, linux-arm-msm,
Kuogee Hsieh, Abhinav Kumar, dri-devel, Bjorn Andersson,
Vinod Koul, Dmitry Baryshkov, Stephen Boyd, Sean Paul,
Guenter Roeck, Mark Yacoub
dpu_core_irq_callback_handler() function comments seem to have become
stale and emit a warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler'
Fix by updating the documentation
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
index 9341c88a336f..27073fd49fee 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
@@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
/**
* dpu_core_irq_callback_handler - dispatch core interrupts
- * @arg: private data of callback handler
+ * @dpu_kms: Pointer to DPU's KMS structure
* @irq_idx: interrupt index
*/
static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
--
2.31.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 3/3] drm/msm/dpu: Update function parameter documentation
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-11 1:58 ` Dmitry Baryshkov
-1 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2022-02-11 1:58 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: linux-arm-msm, Bjorn Andersson, Sean Paul, Abhinav Kumar,
David Airlie, Daniel Vetter, Stephen Boyd, Kuogee Hsieh,
Guenter Roeck, Kalyan Thota, Mark Yacoub, dri-devel, freedreno
On 10/02/2022 14:41, Vinod Koul wrote:
> dpu_core_irq_callback_handler() function comments seem to have become
> stale and emit a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler'
>
> Fix by updating the documentation
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index 9341c88a336f..27073fd49fee 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
>
> /**
> * dpu_core_irq_callback_handler - dispatch core interrupts
> - * @arg: private data of callback handler
> + * @dpu_kms: Pointer to DPU's KMS structure
> * @irq_idx: interrupt index
> */
> static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 3/3] drm/msm/dpu: Update function parameter documentation
@ 2022-02-11 1:58 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2022-02-11 1:58 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: Kalyan Thota, freedreno, David Airlie, linux-arm-msm,
Kuogee Hsieh, Abhinav Kumar, dri-devel, Bjorn Andersson,
Stephen Boyd, Sean Paul, Guenter Roeck, Mark Yacoub
On 10/02/2022 14:41, Vinod Koul wrote:
> dpu_core_irq_callback_handler() function comments seem to have become
> stale and emit a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler'
>
> Fix by updating the documentation
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index 9341c88a336f..27073fd49fee 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
>
> /**
> * dpu_core_irq_callback_handler - dispatch core interrupts
> - * @arg: private data of callback handler
> + * @dpu_kms: Pointer to DPU's KMS structure
> * @irq_idx: interrupt index
> */
> static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 3/3] drm/msm/dpu: Update function parameter documentation
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-11 2:26 ` Abhinav Kumar
-1 siblings, 0 replies; 18+ messages in thread
From: Abhinav Kumar @ 2022-02-11 2:26 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: linux-arm-msm, Bjorn Andersson, Sean Paul, David Airlie,
Daniel Vetter, Dmitry Baryshkov, Stephen Boyd, Kuogee Hsieh,
Guenter Roeck, Kalyan Thota, Mark Yacoub, dri-devel, freedreno
On 2/10/2022 3:41 AM, Vinod Koul wrote:
> dpu_core_irq_callback_handler() function comments seem to have become
> stale and emit a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler'
>
> Fix by updating the documentation
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index 9341c88a336f..27073fd49fee 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
>
> /**
> * dpu_core_irq_callback_handler - dispatch core interrupts
> - * @arg: private data of callback handler
> + * @dpu_kms: Pointer to DPU's KMS structure
> * @irq_idx: interrupt index
> */
> static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 3/3] drm/msm/dpu: Update function parameter documentation
@ 2022-02-11 2:26 ` Abhinav Kumar
0 siblings, 0 replies; 18+ messages in thread
From: Abhinav Kumar @ 2022-02-11 2:26 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: Kalyan Thota, freedreno, David Airlie, linux-arm-msm,
Kuogee Hsieh, dri-devel, Bjorn Andersson, Dmitry Baryshkov,
Stephen Boyd, Sean Paul, Guenter Roeck, Mark Yacoub
On 2/10/2022 3:41 AM, Vinod Koul wrote:
> dpu_core_irq_callback_handler() function comments seem to have become
> stale and emit a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147:
> warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler'
>
> Fix by updating the documentation
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index 9341c88a336f..27073fd49fee 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = {
>
> /**
> * dpu_core_irq_callback_handler - dispatch core interrupts
> - * @arg: private data of callback handler
> + * @dpu_kms: Pointer to DPU's KMS structure
> * @irq_idx: interrupt index
> */
> static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] drm/msm/dpu: Remove set but unused variables
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-11 1:58 ` Dmitry Baryshkov
-1 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2022-02-11 1:58 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: linux-arm-msm, Bjorn Andersson, Sean Paul, Abhinav Kumar,
David Airlie, Daniel Vetter, Stephen Boyd, Kuogee Hsieh,
Guenter Roeck, Kalyan Thota, Mark Yacoub, dri-devel, freedreno,
linux-kernel
On 10/02/2022 14:41, Vinod Koul wrote:
> We get warning:
>
> In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1145 | struct msm_drm_private *priv;
>
> In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1182:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1182 | struct msm_drm_private *priv;
>
> Remove these unused but set variables
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 1e648db439f9..132844801e92 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1142,14 +1142,12 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> int ret = 0;
> - struct msm_drm_private *priv;
> struct drm_display_mode *cur_mode = NULL;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
>
> mutex_lock(&dpu_enc->enc_lock);
> cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
> - priv = drm_enc->dev->dev_private;
>
> trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
> cur_mode->vdisplay);
> @@ -1179,7 +1177,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> - struct msm_drm_private *priv;
> int i = 0;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
> @@ -1188,8 +1185,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> mutex_lock(&dpu_enc->enc_lock);
> dpu_enc->enabled = false;
>
> - priv = drm_enc->dev->dev_private;
> -
> trace_dpu_enc_disable(DRMID(drm_enc));
>
> /* wait for idle */
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/3] drm/msm/dpu: Remove set but unused variables
@ 2022-02-11 1:58 ` Dmitry Baryshkov
0 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2022-02-11 1:58 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: Kalyan Thota, freedreno, linux-kernel, David Airlie,
linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel,
Bjorn Andersson, Stephen Boyd, Sean Paul, Guenter Roeck,
Mark Yacoub
On 10/02/2022 14:41, Vinod Koul wrote:
> We get warning:
>
> In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1145 | struct msm_drm_private *priv;
>
> In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1182:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1182 | struct msm_drm_private *priv;
>
> Remove these unused but set variables
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 1e648db439f9..132844801e92 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1142,14 +1142,12 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> int ret = 0;
> - struct msm_drm_private *priv;
> struct drm_display_mode *cur_mode = NULL;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
>
> mutex_lock(&dpu_enc->enc_lock);
> cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
> - priv = drm_enc->dev->dev_private;
>
> trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
> cur_mode->vdisplay);
> @@ -1179,7 +1177,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> - struct msm_drm_private *priv;
> int i = 0;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
> @@ -1188,8 +1185,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> mutex_lock(&dpu_enc->enc_lock);
> dpu_enc->enabled = false;
>
> - priv = drm_enc->dev->dev_private;
> -
> trace_dpu_enc_disable(DRMID(drm_enc));
>
> /* wait for idle */
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Remove set but unused variables
2022-02-10 11:41 ` Vinod Koul
@ 2022-02-11 2:24 ` Abhinav Kumar
-1 siblings, 0 replies; 18+ messages in thread
From: Abhinav Kumar @ 2022-02-11 2:24 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: Kalyan Thota, freedreno, linux-kernel, David Airlie,
linux-arm-msm, Kuogee Hsieh, dri-devel, Bjorn Andersson,
Daniel Vetter, Dmitry Baryshkov, Stephen Boyd, Sean Paul,
Guenter Roeck, Mark Yacoub
On 2/10/2022 3:41 AM, Vinod Koul wrote:
> We get warning:
>
> In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1145 | struct msm_drm_private *priv;
>
> In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1182:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1182 | struct msm_drm_private *priv;
>
> Remove these unused but set variables
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 1e648db439f9..132844801e92 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1142,14 +1142,12 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> int ret = 0;
> - struct msm_drm_private *priv;
> struct drm_display_mode *cur_mode = NULL;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
>
> mutex_lock(&dpu_enc->enc_lock);
> cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
> - priv = drm_enc->dev->dev_private;
>
> trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
> cur_mode->vdisplay);
> @@ -1179,7 +1177,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> - struct msm_drm_private *priv;
> int i = 0;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
> @@ -1188,8 +1185,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> mutex_lock(&dpu_enc->enc_lock);
> dpu_enc->enabled = false;
>
> - priv = drm_enc->dev->dev_private;
> -
> trace_dpu_enc_disable(DRMID(drm_enc));
>
> /* wait for idle */
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Remove set but unused variables
@ 2022-02-11 2:24 ` Abhinav Kumar
0 siblings, 0 replies; 18+ messages in thread
From: Abhinav Kumar @ 2022-02-11 2:24 UTC (permalink / raw)
To: Vinod Koul, Rob Clark
Cc: Kalyan Thota, David Airlie, linux-arm-msm, Stephen Boyd,
linux-kernel, dri-devel, Kuogee Hsieh, Sean Paul,
Dmitry Baryshkov, Bjorn Andersson, freedreno, Guenter Roeck,
Mark Yacoub
On 2/10/2022 3:41 AM, Vinod Koul wrote:
> We get warning:
>
> In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1145 | struct msm_drm_private *priv;
>
> In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1182:33:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 1182 | struct msm_drm_private *priv;
>
> Remove these unused but set variables
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 1e648db439f9..132844801e92 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1142,14 +1142,12 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> int ret = 0;
> - struct msm_drm_private *priv;
> struct drm_display_mode *cur_mode = NULL;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
>
> mutex_lock(&dpu_enc->enc_lock);
> cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
> - priv = drm_enc->dev->dev_private;
>
> trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
> cur_mode->vdisplay);
> @@ -1179,7 +1177,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
> static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = NULL;
> - struct msm_drm_private *priv;
> int i = 0;
>
> dpu_enc = to_dpu_encoder_virt(drm_enc);
> @@ -1188,8 +1185,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
> mutex_lock(&dpu_enc->enc_lock);
> dpu_enc->enabled = false;
>
> - priv = drm_enc->dev->dev_private;
> -
> trace_dpu_enc_disable(DRMID(drm_enc));
>
> /* wait for idle */
^ permalink raw reply [flat|nested] 18+ messages in thread