All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-pm@vger.kernel.org
Cc: Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] power: supply: max77976: add Maxim MAX77976 charger driver
Date: Tue, 5 Oct 2021 15:15:37 +0200	[thread overview]
Message-ID: <cce10251-c092-c06b-dbc4-d257bb7aa305@lucaceresoli.net> (raw)
In-Reply-To: <a6ea9a21-e9df-b596-eb80-4df4b8d8115e@infradead.org>

Hi Randy,

On 04/10/21 17:28, Randy Dunlap wrote:
> On 10/4/21 6:07 AM, Luca Ceresoli wrote:
>> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
>> index ad93b3550d6d..622d690c883a 100644
>> --- a/drivers/power/supply/Kconfig
>> +++ b/drivers/power/supply/Kconfig
>> @@ -557,6 +557,17 @@ config CHARGER_MAX77693
>>       help
>>         Say Y to enable support for the Maxim MAX77693 battery charger.
>>   +config CHARGER_MAX77976
>> +    tristate "Maxim MAX77976 battery charger driver"
>> +    depends on REGMAP_I2C
>> +    help
>> +      The Maxim MAX77976 is a 19 Vin, 5.5A 1-Cell Li+ Battery Charger
>> +      USB OTG support. It has an I2C interface for configuration.
>> +
>> +      Say Y to enable support for the Maxim MAX77976 battery charger.
>> +      This driver can also be built as a module. If so, the module
>> will be
>> +      called max77976_charger.
> 
> REGMAP_I2C is not a user-settable config option, so drivers should not
> "depend on" it. This should be more like:
> 
>     depends on I2C
>     select REGMAP_I2C

Ouch, thanks for spotting, will fix in v2.

-- 
Luca

  reply	other threads:[~2021-10-05 13:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 13:07 [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger Luca Ceresoli
2021-10-04 13:07 ` [PATCH 2/2] power: supply: max77976: add Maxim MAX77976 charger driver Luca Ceresoli
2021-10-04 15:28   ` Randy Dunlap
2021-10-05 13:15     ` Luca Ceresoli [this message]
2021-10-25 22:02   ` Sebastian Reichel
2021-10-26 11:50     ` Luca Ceresoli
2021-10-06 16:15 ` [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger Sebastian Reichel
2021-10-26 11:53   ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cce10251-c092-c06b-dbc4-d257bb7aa305@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.