All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: linux-pm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger
Date: Tue, 26 Oct 2021 13:53:23 +0200	[thread overview]
Message-ID: <fdc20f96-c407-b0e9-365d-264655a74844@lucaceresoli.net> (raw)
In-Reply-To: <20211006161548.ary3mijxlcz6mdob@earth.universe>

Hi Sebastian,

On 06/10/21 18:15, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Oct 04, 2021 at 03:07:31PM +0200, Luca Ceresoli wrote:
>> Add bindings for the Maxim MAX77976 I2C-controlled battery charger.
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> ---
>>  .../bindings/power/supply/maxim,max77976.yaml | 41 +++++++++++++++++++
>>  MAINTAINERS                                   |  5 +++
>>  2 files changed, 46 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
>> new file mode 100644
>> index 000000000000..b508d9cc04a0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
>> @@ -0,0 +1,41 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/power/supply/maxim,max77976.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Maxim Integrated MAX77976 Battery charger
>> +
>> +maintainers:
>> +  - Luca Ceresoli <luca@lucaceresoli.net>
>> +
>> +description: |
>> +  The Maxim MAX77976 is a 19Vin / 5.5A, 1-Cell Li+ battery charger
>> +  configured via I2C.
>> +
>> +properties:
>> +  compatible:
>> +    const: maxim,max77976
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
> 
> Add
> 
> allOf:
>   - $ref: power-supply.yaml#
> 
> and replace additionalProperties with unevaluatedProperties, so that
> the power-supplies property is also valid.

OK, will fix.

-- 
Luca

      reply	other threads:[~2021-10-26 11:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 13:07 [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger Luca Ceresoli
2021-10-04 13:07 ` [PATCH 2/2] power: supply: max77976: add Maxim MAX77976 charger driver Luca Ceresoli
2021-10-04 15:28   ` Randy Dunlap
2021-10-05 13:15     ` Luca Ceresoli
2021-10-25 22:02   ` Sebastian Reichel
2021-10-26 11:50     ` Luca Ceresoli
2021-10-06 16:15 ` [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger Sebastian Reichel
2021-10-26 11:53   ` Luca Ceresoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdc20f96-c407-b0e9-365d-264655a74844@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.