From: Joe Perches <joe@perches.com>
To: Carlos Bilbao <bilbao@vt.edu>, davem@davemloft.net
Cc: kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch,
gregkh@linuxfoundation.org
Subject: Re: [PATCH net-next v2] drivers: net: Follow the indentation coding standard on printks
Date: Thu, 08 Jul 2021 10:38:26 -0700 [thread overview]
Message-ID: <ccf9f07a72c911652d24ceb6c6e925f834f1d338.camel@perches.com> (raw)
In-Reply-To: <5183009.Sb9uPGUboI@iron-maiden>
On Thu, 2021-07-08 at 13:33 -0400, Carlos Bilbao wrote:
> Fix indentation of printks that start at the beginning of the line. Change this
> for the right number of space characters, or tabs if the file uses them.
You are touching 2 different drivers and this should really be
2 separate patches.
> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c.rej b/drivers/net/ethernet/dec/tulip/de4x5.c.rej
[]
> +++ b/drivers/net/ethernet/dec/tulip/de4x5.c.rej
> @@ -0,0 +1,11 @@
> +--- drivers/net/ethernet/dec/tulip/de4x5.c
> ++++ drivers/net/ethernet/dec/tulip/de4x5.c
> +@@ -3169,7 +3169,7 @@ dc2114x_autoconf(struct net_device *dev)
> +
> + default:
> + lp->tcount++;
> +-printk("Huh?: media:%02x\n", lp->media);
> ++ printk("Huh?: media:%02x\n", lp->media);
> + lp->media = INIT;
> + break;
> + }
This is an interdiff that should not be part of this change.
next prev parent reply other threads:[~2021-07-08 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 15:23 [PATCH] drivers: net: Follow the indentation coding standard on printks Carlos Bilbao
2021-07-08 16:40 ` Joe Perches
2021-07-08 17:33 ` [PATCH net-next v2] " Carlos Bilbao
2021-07-08 17:38 ` Joe Perches [this message]
2021-07-08 17:43 ` Carlos Bilbao
2021-07-08 17:48 ` [PATCH net-next v2] drivers: ethernet: tulip: Fix indentation of printk Carlos Bilbao
2021-07-08 17:59 ` Andrew Lunn
2021-07-08 17:53 ` [PATCH net-next v2] drivers: net: Remove undefined XXXDEBUG on driver sb1000 Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccf9f07a72c911652d24ceb6c6e925f834f1d338.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@lunn.ch \
--cc=bilbao@vt.edu \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.