From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Huazhong Tan <tanhuazhong@huawei.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, linuxarm@huawei.com,
salil.mehta@huawei.com, yisen.zhuang@huawei.com,
lipeng321@huawei.com, linyunsheng@huawei.com
Subject: Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring()
Date: Sun, 28 Oct 2018 11:09:03 +0300 [thread overview]
Message-ID: <cd3e9a2a-e6ef-ceb0-6863-85eaf36841ee@cogentembedded.com> (raw)
In-Reply-To: <1540697651-22993-6-git-send-email-tanhuazhong@huawei.com>
Hello!
On 28.10.2018 6:34, Huazhong Tan wrote:
> It is not necessary to reset the queue in the hns3_uninit_all_ring(),
> since the queue is stopped in the down operation, and will be reset
> in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING
Operation.
> flag in the hclge_reset_tqp() is not correct, because we need to reset
> tqp during pf reset, otherwise it may cause queue not be reset to
Not being reset?
> working state problem.
>
> Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-10-28 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 3:34 [Patch V3 net 00/11] Bugfix for the HNS3 driver Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data() Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 02/11] net: hns3: add error handler for hns3_get_ring_config/hns3_queue_to_ring Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 03/11] net: hns3: bugfix for reporting unknown vector0 interrupt repeatly problem Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 04/11] net: hns3: bugfix for the initialization of command queue's spin lock Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring() Huazhong Tan
2018-10-28 8:09 ` Sergei Shtylyov [this message]
2018-10-29 0:54 ` tanhuazhong
2018-10-28 3:34 ` [Patch V3 net 06/11] net: hns3: bugfix for is_valid_csq_clean_head() Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 07/11] net: hns3: bugfix for hclge_mdio_write and hclge_mdio_read Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 08/11] net: hns3: fix incorrect return value/type of some functions Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 09/11] net: hns3: bugfix for handling mailbox while the command queue reinitialized Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 10/11] net: hns3: bugfix for rtnl_lock's range in the hclge_reset() Huazhong Tan
2018-10-28 3:34 ` [Patch V3 net 11/11] net: hns3: bugfix for rtnl_lock's range in the hclgevf_reset() Huazhong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd3e9a2a-e6ef-ceb0-6863-85eaf36841ee@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.