[PATCH] drm/radeon: drop confusing message about backlight control

[PATCH] drm/radeon: drop confusing message about backlight control

[Alex Deucher]

The message is harmless and confusing.  On PX systems,
there is one ATIF method, but potentially multiple GPUs
leading to an error on the GPU with no backlight control.

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=115011
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Hans de Goede <jwrdegoede@fedoraproject.org>
---
 drivers/gpu/drm/radeon/radeon_acpi.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_acpi.c b/drivers/gpu/drm/radeon/radeon_acpi.c
index 59acd0e..31c9a92 100644
--- a/drivers/gpu/drm/radeon/radeon_acpi.c
+++ b/drivers/gpu/drm/radeon/radeon_acpi.c
@@ -741,13 +741,6 @@ int radeon_acpi_init(struct radeon_device *rdev)
 		}
 
 		atif->encoder_for_bl = target;
-		if (!target) {
-			/* Brightness change notification is enabled, but we
-			 * didn't find a backlight controller, this should
-			 * never happen.
-			 */
-			DRM_ERROR("Cannot find a backlight controller\n");
-		}
 	}
 
 	if (atif->functions.sbios_requests && !atif->functions.system_params) {
-- 
2.5.5

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/radeon: drop confusing message about backlight control

[Alexandre Demers]

Reviewed-by: Alexandre Demers <alexandre.f.demers@gmail.com>

Alexandre Demers

On 2016-07-27 16:44, Alex Deucher wrote:
> The message is harmless and confusing.  On PX systems,
> there is one ATIF method, but potentially multiple GPUs
> leading to an error on the GPU with no backlight control.
>
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=115011
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Hans de Goede <jwrdegoede@fedoraproject.org>
> ---
>   drivers/gpu/drm/radeon/radeon_acpi.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_acpi.c b/drivers/gpu/drm/radeon/radeon_acpi.c
> index 59acd0e..31c9a92 100644
> --- a/drivers/gpu/drm/radeon/radeon_acpi.c
> +++ b/drivers/gpu/drm/radeon/radeon_acpi.c
> @@ -741,13 +741,6 @@ int radeon_acpi_init(struct radeon_device *rdev)
>   		}
>   
>   		atif->encoder_for_bl = target;
> -		if (!target) {
> -			/* Brightness change notification is enabled, but we
> -			 * didn't find a backlight controller, this should
> -			 * never happen.
> -			 */
> -			DRM_ERROR("Cannot find a backlight controller\n");
> -		}
>   	}
>   
>   	if (atif->functions.sbios_requests && !atif->functions.system_params) {

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx