From: jbrunet@baylibre.com
To: Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Yixun Lan <yixun.lan@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Liang Yang <liang.yang@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] clk: meson: add sub MMC clock controller driver
Date: Fri, 02 Nov 2018 14:05:14 +0100 [thread overview]
Message-ID: <ce0a3e6bf6ef438987f3ad390c2aa1bccc75f5ea.camel@baylibre.com> (raw)
In-Reply-To: <1541089855-19356-4-git-send-email-jianxin.pan@amlogic.com>
On Fri, 2018-11-02 at 00:30 +0800, Jianxin Pan wrote:
> +struct meson_sclk_div_data mmc_clkc_div_data = {
> + .div = {
> + .reg_off = SD_EMMC_CLOCK,
> + .shift = (0),
> + .width = (6),
> + },
> + .hi = {
> + .reg_off = 0,
> + .shift = 0,
> + .width = 0,
> + },
> +};
Jianxin,
When replying to v5: https://patchwork.kernel.org/patch/10646723/#22288117
I think I have clearly explained that:
a. sclk needs some change you want to use it for the eMMC (not done )
b. you can't declare sclk statically like that since there is cached data in
it and this would forbib multiple instance of the controller which is not
acceptable for this pariticular controller
This is just not adressed in your series.
Also some comments from Martin about useless definition were already given on
past version.
Seeing this, I did not review the rest of series.
Please make sure you have addressed all the comments of past reviews before
reposting. It is OK to ask questions if things are unclear.
Jerome
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (jbrunet at baylibre.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/3] clk: meson: add sub MMC clock controller driver
Date: Fri, 02 Nov 2018 14:05:14 +0100 [thread overview]
Message-ID: <ce0a3e6bf6ef438987f3ad390c2aa1bccc75f5ea.camel@baylibre.com> (raw)
In-Reply-To: <1541089855-19356-4-git-send-email-jianxin.pan@amlogic.com>
On Fri, 2018-11-02 at 00:30 +0800, Jianxin Pan wrote:
> +struct meson_sclk_div_data mmc_clkc_div_data = {
> + .div = {
> + .reg_off = SD_EMMC_CLOCK,
> + .shift = (0),
> + .width = (6),
> + },
> + .hi = {
> + .reg_off = 0,
> + .shift = 0,
> + .width = 0,
> + },
> +};
Jianxin,
When replying to v5: https://patchwork.kernel.org/patch/10646723/#22288117
I think I have clearly explained that:
a. sclk needs some change you want to use it for the eMMC (not done )
b. you can't declare sclk statically like that since there is cached data in
it and this would forbib multiple instance of the controller which is not
acceptable for this pariticular controller
This is just not adressed in your series.
Also some comments from Martin about useless definition were already given on
past version.
Seeing this, I did not review the rest of series.
Please make sure you have addressed all the comments of past reviews before
reposting. It is OK to ask questions if things are unclear.
Jerome
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (jbrunet at baylibre.com)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v6 3/3] clk: meson: add sub MMC clock controller driver
Date: Fri, 02 Nov 2018 14:05:14 +0100 [thread overview]
Message-ID: <ce0a3e6bf6ef438987f3ad390c2aa1bccc75f5ea.camel@baylibre.com> (raw)
In-Reply-To: <1541089855-19356-4-git-send-email-jianxin.pan@amlogic.com>
On Fri, 2018-11-02 at 00:30 +0800, Jianxin Pan wrote:
> +struct meson_sclk_div_data mmc_clkc_div_data = {
> + .div = {
> + .reg_off = SD_EMMC_CLOCK,
> + .shift = (0),
> + .width = (6),
> + },
> + .hi = {
> + .reg_off = 0,
> + .shift = 0,
> + .width = 0,
> + },
> +};
Jianxin,
When replying to v5: https://patchwork.kernel.org/patch/10646723/#22288117
I think I have clearly explained that:
a. sclk needs some change you want to use it for the eMMC (not done )
b. you can't declare sclk statically like that since there is cached data in
it and this would forbib multiple instance of the controller which is not
acceptable for this pariticular controller
This is just not adressed in your series.
Also some comments from Martin about useless definition were already given on
past version.
Seeing this, I did not review the rest of series.
Please make sure you have addressed all the comments of past reviews before
reposting. It is OK to ask questions if things are unclear.
Jerome
next prev parent reply other threads:[~2018-11-02 13:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 16:30 [PATCH v6 0/3] clk: meson: add a sub EMMC clock controller support Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` [PATCH v6 1/3] clk: meson: add emmc sub clock phase delay driver Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-04 3:02 ` Stephen Boyd
2018-11-04 3:02 ` Stephen Boyd
2018-11-04 3:02 ` Stephen Boyd
2018-11-04 3:02 ` Stephen Boyd
2018-11-04 15:12 ` Jianxin Pan
2018-11-04 15:12 ` Jianxin Pan
2018-11-04 15:12 ` Jianxin Pan
2018-11-04 15:12 ` Jianxin Pan
2018-11-01 16:30 ` [PATCH v6 2/3] clk: meson: add DT documentation for emmc clock controller Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` [PATCH v6 3/3] clk: meson: add sub MMC clock controller driver Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 16:30 ` Jianxin Pan
2018-11-01 18:16 ` Martin Blumenstingl
2018-11-01 18:16 ` Martin Blumenstingl
2018-11-01 18:16 ` Martin Blumenstingl
2018-11-03 7:29 ` Jianxin Pan
2018-11-03 7:29 ` Jianxin Pan
2018-11-03 7:29 ` Jianxin Pan
2018-11-02 13:05 ` jbrunet [this message]
2018-11-02 13:05 ` jbrunet at baylibre.com
2018-11-02 13:05 ` jbrunet at baylibre.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0a3e6bf6ef438987f3ad390c2aa1bccc75f5ea.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=boris.brezillon@bootlin.com \
--cc=carlo@caione.org \
--cc=hanjie.lin@amlogic.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=victor.wan@amlogic.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.