* [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error
@ 2020-08-06 15:54 Randy Dunlap
2020-08-06 17:37 ` J, KEERTHY
2020-08-21 7:57 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-08-06 15:54 UTC (permalink / raw)
To: LKML, Linux Crypto Mailing List, Herbert Xu, David Miller
Cc: Tero Kristo, Keerthy
From: Randy Dunlap <rdunlap@infradead.org>
sa2ul.c uses sha{1,256,512}_zero_message_hash, so select the
Kconfig symbols that provide those, like other crypto drivers do.
Fixes this build error:
ld: drivers/crypto/sa2ul.o: in function `sa_sha_digest':
sa2ul.c:(.text+0x2b25): undefined reference to `sha512_zero_message_hash'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org> # 2020-07-29
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Keerthy <j-keerthy@ti.com>
---
drivers/crypto/Kconfig | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20200806.orig/drivers/crypto/Kconfig
+++ linux-next-20200806/drivers/crypto/Kconfig
@@ -873,6 +873,9 @@ config CRYPTO_DEV_SA2UL
select CRYPTO_AES
select CRYPTO_AES_ARM64
select CRYPTO_ALGAPI
+ select CRYPTO_SHA1
+ select CRYPTO_SHA256
+ select CRYPTO_SHA512
select HW_RANDOM
select SG_SPLIT
help
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error
2020-08-06 15:54 [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error Randy Dunlap
@ 2020-08-06 17:37 ` J, KEERTHY
2020-08-21 7:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: J, KEERTHY @ 2020-08-06 17:37 UTC (permalink / raw)
To: Randy Dunlap, LKML, Linux Crypto Mailing List, Herbert Xu, David Miller
Cc: Tero Kristo
On 8/6/2020 9:24 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> sa2ul.c uses sha{1,256,512}_zero_message_hash, so select the
> Kconfig symbols that provide those, like other crypto drivers do.
>
> Fixes this build error:
>
> ld: drivers/crypto/sa2ul.o: in function `sa_sha_digest':
> sa2ul.c:(.text+0x2b25): undefined reference to `sha512_zero_message_hash'
Thanks for catching this.
Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Randy Dunlap <rdunlap@infradead.org> # 2020-07-29
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Keerthy <j-keerthy@ti.com>
> ---
> drivers/crypto/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20200806.orig/drivers/crypto/Kconfig
> +++ linux-next-20200806/drivers/crypto/Kconfig
> @@ -873,6 +873,9 @@ config CRYPTO_DEV_SA2UL
> select CRYPTO_AES
> select CRYPTO_AES_ARM64
> select CRYPTO_ALGAPI
> + select CRYPTO_SHA1
> + select CRYPTO_SHA256
> + select CRYPTO_SHA512
> select HW_RANDOM
> select SG_SPLIT
> help
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error
2020-08-06 15:54 [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error Randy Dunlap
2020-08-06 17:37 ` J, KEERTHY
@ 2020-08-21 7:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-08-21 7:57 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Linux Crypto Mailing List, David Miller, Tero Kristo, Keerthy
On Thu, Aug 06, 2020 at 08:54:48AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> sa2ul.c uses sha{1,256,512}_zero_message_hash, so select the
> Kconfig symbols that provide those, like other crypto drivers do.
>
> Fixes this build error:
>
> ld: drivers/crypto/sa2ul.o: in function `sa_sha_digest':
> sa2ul.c:(.text+0x2b25): undefined reference to `sha512_zero_message_hash'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Randy Dunlap <rdunlap@infradead.org> # 2020-07-29
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Keerthy <j-keerthy@ti.com>
> ---
> drivers/crypto/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-21 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 15:54 [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error Randy Dunlap
2020-08-06 17:37 ` J, KEERTHY
2020-08-21 7:57 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.