All of lore.kernel.org
 help / color / mirror / Atom feed
* Check for irqs_disabled in evtchn_fifo_unmask
@ 2017-06-01 17:01 Anoob Soman
  2017-06-02 15:08 ` Juergen Gross
  0 siblings, 1 reply; 2+ messages in thread
From: Anoob Soman @ 2017-06-01 17:01 UTC (permalink / raw)
  To: xen-devel; +Cc: jgross, Boris Ostrovsky

Hi,

Can someone explain, why evtchn_fifo_unmask() requires irqs_disabled(). 
What happens, if irqs are not disabled ?

Thanks,

Anoob.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Check for irqs_disabled in evtchn_fifo_unmask
  2017-06-01 17:01 Check for irqs_disabled in evtchn_fifo_unmask Anoob Soman
@ 2017-06-02 15:08 ` Juergen Gross
  0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2017-06-02 15:08 UTC (permalink / raw)
  To: Anoob Soman, xen-devel; +Cc: Boris Ostrovsky

On 01/06/17 19:01, Anoob Soman wrote:
> Hi,
> 
> Can someone explain, why evtchn_fifo_unmask() requires irqs_disabled().
> What happens, if irqs are not disabled ?

evtchn_fifo_unmask() seems to be not critical, but evtchn_2l_unmask()
might be racy if another event is coming in in the middle. The
BUG_ON() in evtchn_fifo_unmask() just makes sure adding a new caller
not obeying the restriction of evtchn_2l_unmask() won't be unnoticed.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-02 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-01 17:01 Check for irqs_disabled in evtchn_fifo_unmask Anoob Soman
2017-06-02 15:08 ` Juergen Gross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.