From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, atar4qemu@gmail.com,
david@gibson.dropbear.id.au
Subject: Re: [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device
Date: Sat, 26 Sep 2020 11:23:51 +0100 [thread overview]
Message-ID: <ce58576b-68c0-2460-7d47-4e515ba53075@ilande.co.uk> (raw)
In-Reply-To: <b7e58136-925d-efb3-34e3-652c9dbd71c3@ilande.co.uk>
On 21/09/2020 18:14, Mark Cave-Ayland wrote:
> On 21/09/2020 18:03, Mark Cave-Ayland wrote:
>
>> The lance and esp devices are embedded within ledma and espdma devices respectively,
>> but are actually sysbus devices because they can be used by other machines. I'm not
>> sure if lance is used anywhere else, but esp certainly is. Hence they are mapped
>> after the dma device is realised as it feels odd to attach devices to sysbus outside
>> of a machine init function.
>
> Actually I have a better idea for this: use sysbus_mmio_get_region() within the
> sparc32-dma device to attach the lance and esp memory regions to its own container
> memory region: then the single sysbus_mmio_map() for the sparc32-dma device will just
> work on its own.
(goes and looks)
Ah now I remember - the DMA control registers and the lance/ESP devices are mapped to
2 different memory locations. So I think the current solution is the best one here.
ATB,
Mark.
next prev parent reply other threads:[~2020-09-26 10:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 8:20 [PATCH 0/6] QOM minor fixes Mark Cave-Ayland
2020-09-20 8:20 ` [PATCH 1/6] sparc32-dma: use object_initialize_child() for espdma and ledma child objects Mark Cave-Ayland
2020-09-20 10:49 ` Philippe Mathieu-Daudé
2020-09-20 8:20 ` [PATCH 2/6] sparc32-ledma: use object_initialize_child() for lance child object Mark Cave-Ayland
2020-09-20 10:49 ` Philippe Mathieu-Daudé
2020-09-20 8:20 ` [PATCH 3/6] sparc32-espdma: use object_initialize_child() for esp " Mark Cave-Ayland
2020-09-20 10:49 ` Philippe Mathieu-Daudé
2020-09-20 8:20 ` [PATCH 4/6] sparc32-ledma: don't reference nd_table directly within the device Mark Cave-Ayland
2020-09-21 9:25 ` Markus Armbruster
2020-09-21 17:03 ` Mark Cave-Ayland
2020-09-21 17:14 ` Mark Cave-Ayland
2020-09-26 10:23 ` Mark Cave-Ayland [this message]
2020-09-21 9:57 ` Philippe Mathieu-Daudé
2020-09-21 17:08 ` Mark Cave-Ayland
2020-09-21 17:58 ` Philippe Mathieu-Daudé
2020-09-26 10:29 ` Mark Cave-Ayland
2020-09-20 8:20 ` [PATCH 5/6] macio: don't reference serial_hd() " Mark Cave-Ayland
2020-09-20 10:52 ` BALATON Zoltan via
2020-09-20 17:59 ` Mark Cave-Ayland
2020-09-20 8:20 ` [PATCH 6/6] sabre: don't call sysbus_mmio_map() in sabre_realize() Mark Cave-Ayland
2020-09-20 10:48 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce58576b-68c0-2460-7d47-4e515ba53075@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.