All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH] Kconfig: hide options not intended for users in arch/Kconfig
Date: Wed, 18 May 2022 17:12:13 +0200	[thread overview]
Message-ID: <ce5f4cd0-d393-5529-a80c-3234959e798d@gmail.com> (raw)
In-Reply-To: <20220518121849.GV3901321@bill-the-cat>



On 18.05.22 14:18, Tom Rini wrote:
> On Tue, May 17, 2022 at 10:53:53PM +0200, Daniel Schwierzeck wrote:
>> Those options show up in menuconfig when selecting ARM or MIPS which
>> is dangerous if a user accidently sets them. This also clutters up the
>> menuconfig top-level screen. Because those options should only be set
>> by SoC specific or board specific configs, make them invisible.
>>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>>
>> ---
>>
>>   arch/Kconfig | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index 12de8a1165..e3e28d0628 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -365,7 +365,7 @@ config SYS_DISABLE_DCACHE_OPS
>>   	 this functionality.
>>   
>>   config SYS_IMMR
>> -	hex "Address for the Internal Memory-Mapped Registers (IMMR) window"
>> +	hex
>>   	depends on PPC || FSL_LSCH2 || FSL_LSCH3 || ARCH_LS1021A
>>   	default 0xFF000000 if MPC8xx
>>   	default 0xF0000000 if ARCH_MPC8313
> 
> But now these aren't user selectable on the right platforms either.
> Maybe we need more menu organization, and so can have sub-menus depend
> on PPC, or whatever, and so things aren't cluttered on other
> architectures?
> 

my main concern was with SKIP_LOWLEVEL_INIT which definitely should not 
be selectable by the user. Maybe I was to overambitious with changing 
the SYS_IMMR option too, I could revert that part ;)

BTW: SYS_IMMR seems to be specific for PPC. Maybe it could be moved to 
arch/powerpc/Kconfig?

-- 
- Daniel

  reply	other threads:[~2022-05-18 15:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 20:53 [PATCH] Kconfig: hide options not intended for users in arch/Kconfig Daniel Schwierzeck
2022-05-18 12:18 ` Tom Rini
2022-05-18 15:12   ` Daniel Schwierzeck [this message]
2022-05-18 15:22     ` Tom Rini
2022-05-18 15:52       ` Daniel Schwierzeck
2022-05-18 15:57         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce5f4cd0-d393-5529-a80c-3234959e798d@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.