All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] src/p2p.c: fix build with uclibc
@ 2020-06-20 13:19 Fabrice Fontaine
  2020-06-22 15:25 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2020-06-20 13:19 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

explicit_bzero is used in src/p2p.c since commit
1675c765a3d66f3c626a1581a7bf514e1859b064 but src/missing.h is not
included, as a result build with uclibc fails on:

/home/naourr/work/instance-0/output-1/per-package/iwd/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/../../../../mips64el-buildroot-linux-uclibc/bin/ld: src/p2p.o: in function `p2p_connection_reset':
p2p.c:(.text+0x2cf4): undefined reference to `explicit_bzero'
/home/naourr/work/instance-0/output-1/per-package/iwd/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/../../../../mips64el-buildroot-linux-uclibc/bin/ld: p2p.c:(.text+0x2cfc): undefined reference to `explicit_bzero'

Fixes:
 - http://autobuild.buildroot.org/results/8bbf7e1d0929d0883c0c2445990f62f5a1d54163

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 src/p2p.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/p2p.c b/src/p2p.c
index dc78b887..a759df5c 100644
--- a/src/p2p.c
+++ b/src/p2p.c
@@ -37,6 +37,7 @@
 
 #include "linux/nl80211.h"
 
+#include "src/missing.h"
 #include "src/iwd.h"
 #include "src/wiphy.h"
 #include "src/scan.h"
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] src/p2p.c: fix build with uclibc
  2020-06-20 13:19 [PATCH] src/p2p.c: fix build with uclibc Fabrice Fontaine
@ 2020-06-22 15:25 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2020-06-22 15:25 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Hi Fabrice,

On 6/20/20 8:19 AM, Fabrice Fontaine wrote:
> explicit_bzero is used in src/p2p.c since commit
> 1675c765a3d66f3c626a1581a7bf514e1859b064 but src/missing.h is not
> included, as a result build with uclibc fails on:
> 
> /home/naourr/work/instance-0/output-1/per-package/iwd/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/../../../../mips64el-buildroot-linux-uclibc/bin/ld: src/p2p.o: in function `p2p_connection_reset':
> p2p.c:(.text+0x2cf4): undefined reference to `explicit_bzero'
> /home/naourr/work/instance-0/output-1/per-package/iwd/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/../../../../mips64el-buildroot-linux-uclibc/bin/ld: p2p.c:(.text+0x2cfc): undefined reference to `explicit_bzero'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/8bbf7e1d0929d0883c0c2445990f62f5a1d54163
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

No signed-off-by please.  iwd doesn't use these.

> ---
>   src/p2p.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Applied after minor commit description modifications.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-22 15:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-20 13:19 [PATCH] src/p2p.c: fix build with uclibc Fabrice Fontaine
2020-06-22 15:25 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.