* [PATCH][next] net: qed_hsi.h: Avoid the use of one-element array
@ 2020-07-22 18:58 Gustavo A. R. Silva
2020-07-23 1:13 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-22 18:58 UTC (permalink / raw)
To: Ariel Elior, David S. Miller, Jakub Kicinski
Cc: GR-everest-linux-l2, netdev, linux-kernel, Gustavo A. R. Silva
One-element arrays are being deprecated[1]. Replace the one-element
array with a simple value type '__le32 reserved1'[2], once it seems
this is just a placeholder for alignment.
[1] https://github.com/KSPP/linux/issues/79
[2] https://github.com/KSPP/linux/issues/86
Tested-by: kernel test robot <lkp@intel.com>
Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/qed_hsi-20200718.md
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/qlogic/qed/qed_hsi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_hsi.h b/drivers/net/ethernet/qlogic/qed/qed_hsi.h
index 1af3f65ab862..559df9f4d656 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_hsi.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_hsi.h
@@ -361,7 +361,7 @@ struct core_tx_update_ramrod_data {
u8 update_qm_pq_id_flg;
u8 reserved0;
__le16 qm_pq_id;
- __le32 reserved1[1];
+ __le32 reserved1;
};
/* Enum flag for what type of dcb data to update */
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: qed_hsi.h: Avoid the use of one-element array
2020-07-22 18:58 [PATCH][next] net: qed_hsi.h: Avoid the use of one-element array Gustavo A. R. Silva
@ 2020-07-23 1:13 ` David Miller
2020-07-23 1:23 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2020-07-23 1:13 UTC (permalink / raw)
To: gustavoars; +Cc: aelior, kuba, GR-everest-linux-l2, netdev, linux-kernel
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: Wed, 22 Jul 2020 13:58:52 -0500
> One-element arrays are being deprecated[1]. Replace the one-element
> array with a simple value type '__le32 reserved1'[2], once it seems
> this is just a placeholder for alignment.
>
> [1] https://github.com/KSPP/linux/issues/79
> [2] https://github.com/KSPP/linux/issues/86
>
> Tested-by: kernel test robot <lkp@intel.com>
> Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/qed_hsi-20200718.md
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: qed_hsi.h: Avoid the use of one-element array
2020-07-23 1:13 ` David Miller
@ 2020-07-23 1:23 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-23 1:23 UTC (permalink / raw)
To: David Miller, gustavoars
Cc: aelior, kuba, GR-everest-linux-l2, netdev, linux-kernel
On 7/22/20 20:13, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Date: Wed, 22 Jul 2020 13:58:52 -0500
>
>> One-element arrays are being deprecated[1]. Replace the one-element
>> array with a simple value type '__le32 reserved1'[2], once it seems
>> this is just a placeholder for alignment.
>>
>> [1] https://github.com/KSPP/linux/issues/79
>> [2] https://github.com/KSPP/linux/issues/86
>>
>> Tested-by: kernel test robot <lkp@intel.com>
>> Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/qed_hsi-20200718.md
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Applied.
>
Thanks, Dave.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-23 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 18:58 [PATCH][next] net: qed_hsi.h: Avoid the use of one-element array Gustavo A. R. Silva
2020-07-23 1:13 ` David Miller
2020-07-23 1:23 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.