* [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next
@ 2022-06-19 11:19 ` Maccraft123
0 siblings, 0 replies; 5+ messages in thread
From: Maccraft123 @ 2022-06-19 11:19 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter
Cc: Hans de Goede, Maya Matuszczyk, dri-devel, linux-kernel
From: Maya Matuszczyk <maccraft123mc@gmail.com>
The device is identified by "NEXT" in board name, however there are
different versions of it, "Next Advance" and "Next Pro", that have
different DMI board names.
Due to a production error a batch or two have their board names prefixed
by "AYANEO", this makes it 6 different DMI board names. To save some
space in final kernel image DMI_MATCH is used instead of
DMI_EXACT_MATCH.
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
---
Changes from v1:
- Changed it to use only one entry, with less exact match, as requested
by Hans de Goede
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 4e853acfd1e8..df87ba99a87c 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -152,6 +152,12 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
},
.driver_data = (void *)&lcd800x1280_rightside_up,
+ }, { /* AYA NEO NEXT */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+ DMI_MATCH(DMI_BOARD_NAME, "NEXT"),
+ },
+ .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Chuwi HiBook (CWI514) */
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
--
2.36.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next
@ 2022-06-19 11:19 ` Maccraft123
0 siblings, 0 replies; 5+ messages in thread
From: Maccraft123 @ 2022-06-19 11:19 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter
Cc: Hans de Goede, linux-kernel, dri-devel, Maya Matuszczyk
From: Maya Matuszczyk <maccraft123mc@gmail.com>
The device is identified by "NEXT" in board name, however there are
different versions of it, "Next Advance" and "Next Pro", that have
different DMI board names.
Due to a production error a batch or two have their board names prefixed
by "AYANEO", this makes it 6 different DMI board names. To save some
space in final kernel image DMI_MATCH is used instead of
DMI_EXACT_MATCH.
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
---
Changes from v1:
- Changed it to use only one entry, with less exact match, as requested
by Hans de Goede
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 4e853acfd1e8..df87ba99a87c 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -152,6 +152,12 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
},
.driver_data = (void *)&lcd800x1280_rightside_up,
+ }, { /* AYA NEO NEXT */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+ DMI_MATCH(DMI_BOARD_NAME, "NEXT"),
+ },
+ .driver_data = (void *)&lcd800x1280_rightside_up,
}, { /* Chuwi HiBook (CWI514) */
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
--
2.36.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next
2022-06-19 11:19 ` Maccraft123
(?)
@ 2022-06-19 11:46 ` Javier Martinez Canillas
2022-06-19 14:57 ` Hans de Goede
-1 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2022-06-19 11:46 UTC (permalink / raw)
To: Maccraft123, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter
Cc: Hans de Goede, linux-kernel, dri-devel
Hello Maya,
On 6/19/22 13:19, Maccraft123 wrote:
> From: Maya Matuszczyk <maccraft123mc@gmail.com>
>
> The device is identified by "NEXT" in board name, however there are
> different versions of it, "Next Advance" and "Next Pro", that have
> different DMI board names.
> Due to a production error a batch or two have their board names prefixed
> by "AYANEO", this makes it 6 different DMI board names. To save some
> space in final kernel image DMI_MATCH is used instead of
> DMI_EXACT_MATCH.
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next
2022-06-19 11:46 ` Javier Martinez Canillas
@ 2022-06-19 14:57 ` Hans de Goede
2022-06-19 15:59 ` Javier Martinez Canillas
0 siblings, 1 reply; 5+ messages in thread
From: Hans de Goede @ 2022-06-19 14:57 UTC (permalink / raw)
To: Javier Martinez Canillas, Maccraft123, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: linux-kernel, dri-devel
Hi,
On 6/19/22 13:46, Javier Martinez Canillas wrote:
> Hello Maya,
>
> On 6/19/22 13:19, Maccraft123 wrote:
>> From: Maya Matuszczyk <maccraft123mc@gmail.com>
>>
>> The device is identified by "NEXT" in board name, however there are
>> different versions of it, "Next Advance" and "Next Pro", that have
>> different DMI board names.
>> Due to a production error a batch or two have their board names prefixed
>> by "AYANEO", this makes it 6 different DMI board names. To save some
>> space in final kernel image DMI_MATCH is used instead of
>> DMI_EXACT_MATCH.
>>
>> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>>
>
> Patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
New version looks good to me too:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
I've some upcoming travel, so it would be good if someone
else can push this to drm-misc-fixes.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next
2022-06-19 14:57 ` Hans de Goede
@ 2022-06-19 15:59 ` Javier Martinez Canillas
0 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2022-06-19 15:59 UTC (permalink / raw)
To: Hans de Goede, Maccraft123, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: linux-kernel, dri-devel
Hello Hans,
On 6/19/22 16:57, Hans de Goede wrote:
> Hi,
>
> On 6/19/22 13:46, Javier Martinez Canillas wrote:
>> Hello Maya,
>>
>> On 6/19/22 13:19, Maccraft123 wrote:
>>> From: Maya Matuszczyk <maccraft123mc@gmail.com>
>>>
>>> The device is identified by "NEXT" in board name, however there are
>>> different versions of it, "Next Advance" and "Next Pro", that have
>>> different DMI board names.
>>> Due to a production error a batch or two have their board names prefixed
>>> by "AYANEO", this makes it 6 different DMI board names. To save some
>>> space in final kernel image DMI_MATCH is used instead of
>>> DMI_EXACT_MATCH.
>>>
>>> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>>>
>>
>> Patch looks good to me.
>>
>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>
> New version looks good to me too:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> I've some upcoming travel, so it would be good if someone
> else can push this to drm-misc-fixes.
>
Sure, I've pushed to drm-misc-fixes now. Thanks!
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-19 15:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-19 11:19 [PATCH v2] drm: panel-orientation-quirks: Add quirk for Aya Neo Next Maccraft123
2022-06-19 11:19 ` Maccraft123
2022-06-19 11:46 ` Javier Martinez Canillas
2022-06-19 14:57 ` Hans de Goede
2022-06-19 15:59 ` Javier Martinez Canillas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.