All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	"Michel Dänzer" <michel@daenzer.net>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"David Airlie" <airlied@linux.ie>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows
Date: Wed, 4 Jul 2018 14:05:18 -0400	[thread overview]
Message-ID: <ced95410-1b3c-8344-fe62-7f22f310c86d@amd.com> (raw)
In-Reply-To: <ab3d5e10-e25b-46a1-d3ab-da3619d8c5b4@embeddedor.com>

On 2018-07-04 01:54 PM, Gustavo A. R. Silva wrote:
> 
> 
> On 07/04/2018 12:51 PM, Harry Wentland wrote:
> [..]
>>>>  
>>>> @@ -145,8 +145,8 @@ static bool calculate_fb_and_fractional_fb_divider(
>>>>   * of fractional feedback decimal point and the fractional FB Divider precision
>>>>   * is 2 then the equation becomes (ullfeedbackDivider + 5*100) / (10*100))*/
>>>>  
>>>> -	feedback_divider += (uint64_t)
>>>> -			(5 * calc_pll_cs->fract_fb_divider_precision_factor);
>>>> +	feedback_divider += 5UL *
>>>> +			    calc_pll_cs->fract_fb_divider_precision_factor;
>>>
>>> This should be 5ULL, as the commit log says, otherwise it's still only
>>> 32 bits on 32-bit platforms.
>>>
>>
>> Agreed.
>>
>> Otherwise this looks good.
>>
>> With that fixed this patch is
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>>
> 
> Hi Harry,
> 
> I already sent v2: https://patchwork.kernel.org/patch/10506897/
> 

Thanks. Merged.

Harry

> Thanks
> --
> Gustavo
> 

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
To: "Gustavo A. R. Silva"
	<gustavo-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>,
	"Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
	"Alex Deucher" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
	"David (ChunMing) Zhou"
	<David1.Zhou-5C7GfCeVMHo@public.gmane.org>,
	"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows
Date: Wed, 4 Jul 2018 14:05:18 -0400	[thread overview]
Message-ID: <ced95410-1b3c-8344-fe62-7f22f310c86d@amd.com> (raw)
In-Reply-To: <ab3d5e10-e25b-46a1-d3ab-da3619d8c5b4-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>

On 2018-07-04 01:54 PM, Gustavo A. R. Silva wrote:
> 
> 
> On 07/04/2018 12:51 PM, Harry Wentland wrote:
> [..]
>>>>  
>>>> @@ -145,8 +145,8 @@ static bool calculate_fb_and_fractional_fb_divider(
>>>>   * of fractional feedback decimal point and the fractional FB Divider precision
>>>>   * is 2 then the equation becomes (ullfeedbackDivider + 5*100) / (10*100))*/
>>>>  
>>>> -	feedback_divider += (uint64_t)
>>>> -			(5 * calc_pll_cs->fract_fb_divider_precision_factor);
>>>> +	feedback_divider += 5UL *
>>>> +			    calc_pll_cs->fract_fb_divider_precision_factor;
>>>
>>> This should be 5ULL, as the commit log says, otherwise it's still only
>>> 32 bits on 32-bit platforms.
>>>
>>
>> Agreed.
>>
>> Otherwise this looks good.
>>
>> With that fixed this patch is
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>>
> 
> Hi Harry,
> 
> I already sent v2: https://patchwork.kernel.org/patch/10506897/
> 

Thanks. Merged.

Harry

> Thanks
> --
> Gustavo
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2018-07-04 18:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04  1:13 [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows Gustavo A. R. Silva
2018-07-04  7:38 ` Michel Dänzer
2018-07-04  7:38   ` Michel Dänzer
2018-07-04 12:51   ` Gustavo A. R. Silva
2018-07-04 17:51   ` Harry Wentland
2018-07-04 17:51     ` Harry Wentland
2018-07-04 17:54     ` Gustavo A. R. Silva
2018-07-04 18:05       ` Harry Wentland [this message]
2018-07-04 18:05         ` Harry Wentland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced95410-1b3c-8344-fe62-7f22f310c86d@amd.com \
    --to=harry.wentland@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.