Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn char device driver

["Zhao, Yakui" <yakui.zhao@intel.com>]

On 2019年08月16日 15:05, Greg KH wrote:
> On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote:
>> ACRN hypervisor service module is the important middle layer that allows
>> the Linux kernel to communicate with the ACRN hypervisor. It includes
>> the management of virtualized CPU/memory/device/interrupt for other ACRN
>> guest. The user-space applications can use the provided ACRN ioctls to
>> interact with ACRN hypervisor through different hypercalls.
>>
>> Add one basic framework firstly and the following patches will
>> add the corresponding implementations, which includes the management of
>> virtualized CPU/memory/interrupt and the emulation of MMIO/IO/PCI access.
>> The device file of /dev/acrn_hsm can be accessed in user-space to
>> communicate with ACRN module.
>>
>> Co-developed-by: Jason Chen CJ <jason.cj.chen@intel.com>
>> Signed-off-by: Jason Chen CJ <jason.cj.chen@intel.com>
>> Co-developed-by: Jack Ren <jack.ren@intel.com>
>> Signed-off-by: Jack Ren <jack.ren@intel.com>
>> Co-developed-by: Mingqiang Chi <mingqiang.chi@intel.com>
>> Signed-off-by: Mingqiang Chi <mingqiang.chi@intel.com>
>> Co-developed-by: Liu Shuo <shuo.a.liu@intel.com>
>> Signed-off-by: Liu Shuo <shuo.a.liu@intel.com>
>> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
>> ---
>>   drivers/staging/Kconfig         |   2 +
> 
> Also, your subject line for all of these patches are wrong, it is not
> drivers/acrn :(

Thanks for the pointing out it.

It will be fixed.

> 
> And you forgot to cc: the staging maintainer :(

Do you mean that the maintainer of staging subsystem is also added in 
the patch commit log?


> 
> As I have said with NUMEROUS Intel patches in the past, I now refuse to
> take patches from you all WITHOUT having it signed-off-by someone from
> the Intel "OTC" group (or whatever the Intel Linux group is called these
> days).  They are a resource you can not ignore, and if you do, you just
> end up making the rest of the kernel community grumpy by having us do
> their work for them :(
> 
> Please work with them.

OK. I will work with some peoples in OTC group to prepare the better 
ACRN driver.

> 
> greg k-h
>