* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-20 18:01 ` Suman Anna
0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2017-09-20 18:01 UTC (permalink / raw)
To: Sekhar Nori
Cc: Bartosz Golaszewski, David Lechner, linux-arm-kernel,
linux-kernel, Suman Anna
Enable the CMA and DMA_CMA Kconfig options by default for
Davinci platforms. Davinci remoteproc driver is one of the
modules that depends on these options, and this allows the
driver to be made visible for selection with menuconfig.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
Hi Sekhar,
Here's the patch that enables CMA as per your request. Patch based
on your v4.15/defconfig branch.
regards
Suman
arch/arm/configs/davinci_all_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
index 4d432cf1ee79..bd0cf22f9ceb 100644
--- a/arch/arm/configs/davinci_all_defconfig
+++ b/arch/arm/configs/davinci_all_defconfig
@@ -34,6 +34,7 @@ CONFIG_DAVINCI_MUX_WARNINGS=y
CONFIG_DAVINCI_RESET_CLOCKS=y
CONFIG_PREEMPT=y
CONFIG_AEABI=y
+CONFIG_CMA=y
CONFIG_SECCOMP=y
CONFIG_ZBOOT_ROM_TEXT=0x0
CONFIG_ZBOOT_ROM_BSS=0x0
@@ -56,6 +57,7 @@ CONFIG_NETFILTER=y
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
# CONFIG_FW_LOADER is not set
+CONFIG_DMA_CMA=y
CONFIG_DA8XX_MSTPRI=y
CONFIG_MTD=m
CONFIG_MTD_TESTS=m
--
2.13.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-20 18:01 ` Suman Anna
0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2017-09-20 18:01 UTC (permalink / raw)
To: linux-arm-kernel
Enable the CMA and DMA_CMA Kconfig options by default for
Davinci platforms. Davinci remoteproc driver is one of the
modules that depends on these options, and this allows the
driver to be made visible for selection with menuconfig.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
Hi Sekhar,
Here's the patch that enables CMA as per your request. Patch based
on your v4.15/defconfig branch.
regards
Suman
arch/arm/configs/davinci_all_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
index 4d432cf1ee79..bd0cf22f9ceb 100644
--- a/arch/arm/configs/davinci_all_defconfig
+++ b/arch/arm/configs/davinci_all_defconfig
@@ -34,6 +34,7 @@ CONFIG_DAVINCI_MUX_WARNINGS=y
CONFIG_DAVINCI_RESET_CLOCKS=y
CONFIG_PREEMPT=y
CONFIG_AEABI=y
+CONFIG_CMA=y
CONFIG_SECCOMP=y
CONFIG_ZBOOT_ROM_TEXT=0x0
CONFIG_ZBOOT_ROM_BSS=0x0
@@ -56,6 +57,7 @@ CONFIG_NETFILTER=y
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
# CONFIG_FW_LOADER is not set
+CONFIG_DMA_CMA=y
CONFIG_DA8XX_MSTPRI=y
CONFIG_MTD=m
CONFIG_MTD_TESTS=m
--
2.13.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-20 18:01 ` Suman Anna
@ 2017-09-21 14:43 ` Sekhar Nori
-1 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-21 14:43 UTC (permalink / raw)
To: Suman Anna
Cc: Bartosz Golaszewski, David Lechner, linux-arm-kernel, linux-kernel
On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
> Enable the CMA and DMA_CMA Kconfig options by default for
> Davinci platforms. Davinci remoteproc driver is one of the
> modules that depends on these options, and this allows the
> driver to be made visible for selection with menuconfig.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Sekhar,
>
> Here's the patch that enables CMA as per your request. Patch based
> on your v4.15/defconfig branch.
Applied! I guess you will be sending another patch enabling the
remoteproc driver itself?
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-21 14:43 ` Sekhar Nori
0 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-21 14:43 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
> Enable the CMA and DMA_CMA Kconfig options by default for
> Davinci platforms. Davinci remoteproc driver is one of the
> modules that depends on these options, and this allows the
> driver to be made visible for selection with menuconfig.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Sekhar,
>
> Here's the patch that enables CMA as per your request. Patch based
> on your v4.15/defconfig branch.
Applied! I guess you will be sending another patch enabling the
remoteproc driver itself?
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-21 14:43 ` Sekhar Nori
@ 2017-09-21 15:11 ` Suman Anna
-1 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2017-09-21 15:11 UTC (permalink / raw)
To: Sekhar Nori
Cc: Bartosz Golaszewski, David Lechner, linux-arm-kernel, linux-kernel
On 09/21/2017 09:43 AM, Sekhar Nori wrote:
> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>> Enable the CMA and DMA_CMA Kconfig options by default for
>> Davinci platforms. Davinci remoteproc driver is one of the
>> modules that depends on these options, and this allows the
>> driver to be made visible for selection with menuconfig.
>>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> Hi Sekhar,
>>
>> Here's the patch that enables CMA as per your request. Patch based
>> on your v4.15/defconfig branch.
>
> Applied! I guess you will be sending another patch enabling the
> remoteproc driver itself?
Thanks. Well, one always needs a firmware image in their filesystem
without which enabling the driver is meaningless (it would fail). So was
not planning to enable it by default.
regards
Suman
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-21 15:11 ` Suman Anna
0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2017-09-21 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On 09/21/2017 09:43 AM, Sekhar Nori wrote:
> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>> Enable the CMA and DMA_CMA Kconfig options by default for
>> Davinci platforms. Davinci remoteproc driver is one of the
>> modules that depends on these options, and this allows the
>> driver to be made visible for selection with menuconfig.
>>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> Hi Sekhar,
>>
>> Here's the patch that enables CMA as per your request. Patch based
>> on your v4.15/defconfig branch.
>
> Applied! I guess you will be sending another patch enabling the
> remoteproc driver itself?
Thanks. Well, one always needs a firmware image in their filesystem
without which enabling the driver is meaningless (it would fail). So was
not planning to enable it by default.
regards
Suman
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-21 15:11 ` Suman Anna
@ 2017-09-22 9:12 ` Sekhar Nori
-1 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-22 9:12 UTC (permalink / raw)
To: Suman Anna
Cc: Bartosz Golaszewski, David Lechner, linux-arm-kernel, linux-kernel
Hi Suman,
On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>> Davinci platforms. Davinci remoteproc driver is one of the
>>> modules that depends on these options, and this allows the
>>> driver to be made visible for selection with menuconfig.
>>>
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>> ---
>>> Hi Sekhar,
>>>
>>> Here's the patch that enables CMA as per your request. Patch based
>>> on your v4.15/defconfig branch.
>>
>> Applied! I guess you will be sending another patch enabling the
>> remoteproc driver itself?
>
> Thanks. Well, one always needs a firmware image in their filesystem
> without which enabling the driver is meaningless (it would fail). So was
> not planning to enable it by default.
But the errors will show up only on DA850 LCDK where we have enabled the
DSP by default in DT because its an important usecase there. I think it
is important for users to see those errors.
(besides the usual benefits of having the module enabled to catch build
and runtime issues easily).
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-22 9:12 ` Sekhar Nori
0 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-22 9:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Suman,
On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>> Davinci platforms. Davinci remoteproc driver is one of the
>>> modules that depends on these options, and this allows the
>>> driver to be made visible for selection with menuconfig.
>>>
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>> ---
>>> Hi Sekhar,
>>>
>>> Here's the patch that enables CMA as per your request. Patch based
>>> on your v4.15/defconfig branch.
>>
>> Applied! I guess you will be sending another patch enabling the
>> remoteproc driver itself?
>
> Thanks. Well, one always needs a firmware image in their filesystem
> without which enabling the driver is meaningless (it would fail). So was
> not planning to enable it by default.
But the errors will show up only on DA850 LCDK where we have enabled the
DSP by default in DT because its an important usecase there. I think it
is important for users to see those errors.
(besides the usual benefits of having the module enabled to catch build
and runtime issues easily).
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-22 9:12 ` Sekhar Nori
@ 2017-09-22 16:24 ` Suman Anna
-1 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2017-09-22 16:24 UTC (permalink / raw)
To: Sekhar Nori
Cc: Bartosz Golaszewski, David Lechner, linux-arm-kernel, linux-kernel
Hi Sekhar,
>
> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>> modules that depends on these options, and this allows the
>>>> driver to be made visible for selection with menuconfig.
>>>>
>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>> ---
>>>> Hi Sekhar,
>>>>
>>>> Here's the patch that enables CMA as per your request. Patch based
>>>> on your v4.15/defconfig branch.
>>>
>>> Applied! I guess you will be sending another patch enabling the
>>> remoteproc driver itself?
>>
>> Thanks. Well, one always needs a firmware image in their filesystem
>> without which enabling the driver is meaningless (it would fail). So was
>> not planning to enable it by default.
>
> But the errors will show up only on DA850 LCDK where we have enabled the
> DSP by default in DT because its an important usecase there. I think it
> is important for users to see those errors.
> (besides the usual benefits of having the module enabled to catch build
> and runtime issues easily).
Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
boards, but I believe there are boards still using legacy boot, and it
shows up on those platforms as well. FYI, we do not have any rpmsg
drivers other than the kernel sample to make real usage of a booted
remoteproc. Anycase, if you still prefer this to be added, I don't mind.
regards
Suman
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-22 16:24 ` Suman Anna
0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2017-09-22 16:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sekhar,
>
> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>> modules that depends on these options, and this allows the
>>>> driver to be made visible for selection with menuconfig.
>>>>
>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>> ---
>>>> Hi Sekhar,
>>>>
>>>> Here's the patch that enables CMA as per your request. Patch based
>>>> on your v4.15/defconfig branch.
>>>
>>> Applied! I guess you will be sending another patch enabling the
>>> remoteproc driver itself?
>>
>> Thanks. Well, one always needs a firmware image in their filesystem
>> without which enabling the driver is meaningless (it would fail). So was
>> not planning to enable it by default.
>
> But the errors will show up only on DA850 LCDK where we have enabled the
> DSP by default in DT because its an important usecase there. I think it
> is important for users to see those errors.
> (besides the usual benefits of having the module enabled to catch build
> and runtime issues easily).
Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
boards, but I believe there are boards still using legacy boot, and it
shows up on those platforms as well. FYI, we do not have any rpmsg
drivers other than the kernel sample to make real usage of a booted
remoteproc. Anycase, if you still prefer this to be added, I don't mind.
regards
Suman
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-22 16:24 ` Suman Anna
@ 2017-09-22 16:43 ` David Lechner
-1 siblings, 0 replies; 18+ messages in thread
From: David Lechner @ 2017-09-22 16:43 UTC (permalink / raw)
To: Suman Anna, Sekhar Nori
Cc: Bartosz Golaszewski, linux-arm-kernel, linux-kernel
On 09/22/2017 11:24 AM, Suman Anna wrote:
> Hi Sekhar,
>
>>
>> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>>> modules that depends on these options, and this allows the
>>>>> driver to be made visible for selection with menuconfig.
>>>>>
>>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>>> ---
>>>>> Hi Sekhar,
>>>>>
>>>>> Here's the patch that enables CMA as per your request. Patch based
>>>>> on your v4.15/defconfig branch.
>>>>
>>>> Applied! I guess you will be sending another patch enabling the
>>>> remoteproc driver itself?
>>>
>>> Thanks. Well, one always needs a firmware image in their filesystem
>>> without which enabling the driver is meaningless (it would fail). So was
>>> not planning to enable it by default.
>>
>> But the errors will show up only on DA850 LCDK where we have enabled the
>> DSP by default in DT because its an important usecase there. I think it
>> is important for users to see those errors.
>> (besides the usual benefits of having the module enabled to catch build
>> and runtime issues easily).
>
> Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
> boards, but I believe there are boards still using legacy boot, and it
> shows up on those platforms as well. FYI, we do not have any rpmsg
> drivers other than the kernel sample to make real usage of a booted
> remoteproc. Anycase, if you still prefer this to be added, I don't mind.
>
> regards
> Suman
>
I am interested in using remoteproc on LEGO MINDSTORMS EV3 to implement
I2C and UART in the PRU.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-22 16:43 ` David Lechner
0 siblings, 0 replies; 18+ messages in thread
From: David Lechner @ 2017-09-22 16:43 UTC (permalink / raw)
To: linux-arm-kernel
On 09/22/2017 11:24 AM, Suman Anna wrote:
> Hi Sekhar,
>
>>
>> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>>> modules that depends on these options, and this allows the
>>>>> driver to be made visible for selection with menuconfig.
>>>>>
>>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>>> ---
>>>>> Hi Sekhar,
>>>>>
>>>>> Here's the patch that enables CMA as per your request. Patch based
>>>>> on your v4.15/defconfig branch.
>>>>
>>>> Applied! I guess you will be sending another patch enabling the
>>>> remoteproc driver itself?
>>>
>>> Thanks. Well, one always needs a firmware image in their filesystem
>>> without which enabling the driver is meaningless (it would fail). So was
>>> not planning to enable it by default.
>>
>> But the errors will show up only on DA850 LCDK where we have enabled the
>> DSP by default in DT because its an important usecase there. I think it
>> is important for users to see those errors.
>> (besides the usual benefits of having the module enabled to catch build
>> and runtime issues easily).
>
> Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
> boards, but I believe there are boards still using legacy boot, and it
> shows up on those platforms as well. FYI, we do not have any rpmsg
> drivers other than the kernel sample to make real usage of a booted
> remoteproc. Anycase, if you still prefer this to be added, I don't mind.
>
> regards
> Suman
>
I am interested in using remoteproc on LEGO MINDSTORMS EV3 to implement
I2C and UART in the PRU.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-22 16:24 ` Suman Anna
@ 2017-09-26 9:50 ` Sekhar Nori
-1 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-26 9:50 UTC (permalink / raw)
To: Suman Anna
Cc: Bartosz Golaszewski, David Lechner, linux-arm-kernel, linux-kernel
On Friday 22 September 2017 09:54 PM, Suman Anna wrote:
> Hi Sekhar,
>
>>
>> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>>> modules that depends on these options, and this allows the
>>>>> driver to be made visible for selection with menuconfig.
>>>>>
>>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>>> ---
>>>>> Hi Sekhar,
>>>>>
>>>>> Here's the patch that enables CMA as per your request. Patch based
>>>>> on your v4.15/defconfig branch.
>>>>
>>>> Applied! I guess you will be sending another patch enabling the
>>>> remoteproc driver itself?
>>>
>>> Thanks. Well, one always needs a firmware image in their filesystem
>>> without which enabling the driver is meaningless (it would fail). So was
>>> not planning to enable it by default.
>>
>> But the errors will show up only on DA850 LCDK where we have enabled the
>> DSP by default in DT because its an important usecase there. I think it
>> is important for users to see those errors.
>> (besides the usual benefits of having the module enabled to catch build
>> and runtime issues easily).
>
> Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
> boards, but I believe there are boards still using legacy boot, and it
> shows up on those platforms as well. FYI, we do not have any rpmsg
Thats right. Even there, my thinking is if a board is registering a
platform device, its because it wants to use it. And so the driver
should be enabled.
> drivers other than the kernel sample to make real usage of a booted
> remoteproc. Anycase, if you still prefer this to be added, I don't mind.
I think its better to enable the driver too. Please submit a patch. Thanks!
Regards,
Sekhar
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-26 9:50 ` Sekhar Nori
0 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-26 9:50 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 22 September 2017 09:54 PM, Suman Anna wrote:
> Hi Sekhar,
>
>>
>> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>>> modules that depends on these options, and this allows the
>>>>> driver to be made visible for selection with menuconfig.
>>>>>
>>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>>> ---
>>>>> Hi Sekhar,
>>>>>
>>>>> Here's the patch that enables CMA as per your request. Patch based
>>>>> on your v4.15/defconfig branch.
>>>>
>>>> Applied! I guess you will be sending another patch enabling the
>>>> remoteproc driver itself?
>>>
>>> Thanks. Well, one always needs a firmware image in their filesystem
>>> without which enabling the driver is meaningless (it would fail). So was
>>> not planning to enable it by default.
>>
>> But the errors will show up only on DA850 LCDK where we have enabled the
>> DSP by default in DT because its an important usecase there. I think it
>> is important for users to see those errors.
>> (besides the usual benefits of having the module enabled to catch build
>> and runtime issues easily).
>
> Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
> boards, but I believe there are boards still using legacy boot, and it
> shows up on those platforms as well. FYI, we do not have any rpmsg
Thats right. Even there, my thinking is if a board is registering a
platform device, its because it wants to use it. And so the driver
should be enabled.
> drivers other than the kernel sample to make real usage of a booted
> remoteproc. Anycase, if you still prefer this to be added, I don't mind.
I think its better to enable the driver too. Please submit a patch. Thanks!
Regards,
Sekhar
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-22 16:43 ` David Lechner
@ 2017-09-26 9:56 ` Sekhar Nori
-1 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-26 9:56 UTC (permalink / raw)
To: David Lechner, Suman Anna
Cc: Bartosz Golaszewski, linux-arm-kernel, linux-kernel
Hi David,
On Friday 22 September 2017 10:13 PM, David Lechner wrote:
> On 09/22/2017 11:24 AM, Suman Anna wrote:
>> Hi Sekhar,
>>
>>>
>>> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>>>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>>>> modules that depends on these options, and this allows the
>>>>>> driver to be made visible for selection with menuconfig.
>>>>>>
>>>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>>>> ---
>>>>>> Hi Sekhar,
>>>>>>
>>>>>> Here's the patch that enables CMA as per your request. Patch based
>>>>>> on your v4.15/defconfig branch.
>>>>>
>>>>> Applied! I guess you will be sending another patch enabling the
>>>>> remoteproc driver itself?
>>>>
>>>> Thanks. Well, one always needs a firmware image in their filesystem
>>>> without which enabling the driver is meaningless (it would fail). So
>>>> was
>>>> not planning to enable it by default.
>>>
>>> But the errors will show up only on DA850 LCDK where we have enabled the
>>> DSP by default in DT because its an important usecase there. I think it
>>> is important for users to see those errors.
>>> (besides the usual benefits of having the module enabled to catch build
>>> and runtime issues easily).
>>
>> Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
>> boards, but I believe there are boards still using legacy boot, and it
>> shows up on those platforms as well. FYI, we do not have any rpmsg
>> drivers other than the kernel sample to make real usage of a booted
>> remoteproc. Anycase, if you still prefer this to be added, I don't mind.
>>
>> regards
>> Suman
>>
>
> I am interested in using remoteproc on LEGO MINDSTORMS EV3 to implement
> I2C and UART in the PRU.
Do note that the remoteproc driver being discussed here is the DSP
remoteproc driver. TI releases have a remoteproc driver that talks to
PRUSS[1], but that has not been used to talk to PRUSS on OMAP-L138. And
AFAIK, there is no one working towards that in TI as well.
Thanks,
Sekhar
[1]
http://git.ti.com/cgit/cgit.cgi/ti-linux-kernel/ti-linux-kernel.git/tree/drivers/remoteproc/pru_rproc.c?h=ti-linux-4.9.y
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-26 9:56 ` Sekhar Nori
0 siblings, 0 replies; 18+ messages in thread
From: Sekhar Nori @ 2017-09-26 9:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi David,
On Friday 22 September 2017 10:13 PM, David Lechner wrote:
> On 09/22/2017 11:24 AM, Suman Anna wrote:
>> Hi Sekhar,
>>
>>>
>>> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>>>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>>>> modules that depends on these options, and this allows the
>>>>>> driver to be made visible for selection with menuconfig.
>>>>>>
>>>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>>>> ---
>>>>>> Hi Sekhar,
>>>>>>
>>>>>> Here's the patch that enables CMA as per your request. Patch based
>>>>>> on your v4.15/defconfig branch.
>>>>>
>>>>> Applied! I guess you will be sending another patch enabling the
>>>>> remoteproc driver itself?
>>>>
>>>> Thanks. Well, one always needs a firmware image in their filesystem
>>>> without which enabling the driver is meaningless (it would fail). So
>>>> was
>>>> not planning to enable it by default.
>>>
>>> But the errors will show up only on DA850 LCDK where we have enabled the
>>> DSP by default in DT because its an important usecase there. I think it
>>> is important for users to see those errors.
>>> (besides the usual benefits of having the module enabled to catch build
>>> and runtime issues easily).
>>
>> Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
>> boards, but I believe there are boards still using legacy boot, and it
>> shows up on those platforms as well. FYI, we do not have any rpmsg
>> drivers other than the kernel sample to make real usage of a booted
>> remoteproc. Anycase, if you still prefer this to be added, I don't mind.
>>
>> regards
>> Suman
>>
>
> I am interested in using remoteproc on LEGO MINDSTORMS EV3 to implement
> I2C and UART in the PRU.
Do note that the remoteproc driver being discussed here is the DSP
remoteproc driver. TI releases have a remoteproc driver that talks to
PRUSS[1], but that has not been used to talk to PRUSS on OMAP-L138. And
AFAIK, there is no one working towards that in TI as well.
Thanks,
Sekhar
[1]
http://git.ti.com/cgit/cgit.cgi/ti-linux-kernel/ti-linux-kernel.git/tree/drivers/remoteproc/pru_rproc.c?h=ti-linux-4.9.y
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options
2017-09-26 9:56 ` Sekhar Nori
@ 2017-09-26 16:28 ` David Lechner
-1 siblings, 0 replies; 18+ messages in thread
From: David Lechner @ 2017-09-26 16:28 UTC (permalink / raw)
To: Sekhar Nori, Suman Anna
Cc: Bartosz Golaszewski, linux-arm-kernel, linux-kernel
On 09/26/2017 04:56 AM, Sekhar Nori wrote:
> Hi David,
>
>>
>> I am interested in using remoteproc on LEGO MINDSTORMS EV3 to implement
>> I2C and UART in the PRU.
>
> Do note that the remoteproc driver being discussed here is the DSP
> remoteproc driver. TI releases have a remoteproc driver that talks to
> PRUSS[1], but that has not been used to talk to PRUSS on OMAP-L138. And
> AFAIK, there is no one working towards that in TI as well.
>
> Thanks,
> Sekhar
>
> [1]
> http://git.ti.com/cgit/cgit.cgi/ti-linux-kernel/ti-linux-kernel.git/tree/drivers/remoteproc/pru_rproc.c?h=ti-linux-4.9.y
>
Darn. I've used pru_rproc on the BeagleBone. One more thing for the EV3
list ;-).
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: davinci_all_defconfig: enable CMA options
@ 2017-09-26 16:28 ` David Lechner
0 siblings, 0 replies; 18+ messages in thread
From: David Lechner @ 2017-09-26 16:28 UTC (permalink / raw)
To: linux-arm-kernel
On 09/26/2017 04:56 AM, Sekhar Nori wrote:
> Hi David,
>
>>
>> I am interested in using remoteproc on LEGO MINDSTORMS EV3 to implement
>> I2C and UART in the PRU.
>
> Do note that the remoteproc driver being discussed here is the DSP
> remoteproc driver. TI releases have a remoteproc driver that talks to
> PRUSS[1], but that has not been used to talk to PRUSS on OMAP-L138. And
> AFAIK, there is no one working towards that in TI as well.
>
> Thanks,
> Sekhar
>
> [1]
> http://git.ti.com/cgit/cgit.cgi/ti-linux-kernel/ti-linux-kernel.git/tree/drivers/remoteproc/pru_rproc.c?h=ti-linux-4.9.y
>
Darn. I've used pru_rproc on the BeagleBone. One more thing for the EV3
list ;-).
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2017-09-26 16:28 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 18:01 [PATCH] ARM: davinci_all_defconfig: enable CMA options Suman Anna
2017-09-20 18:01 ` Suman Anna
2017-09-21 14:43 ` Sekhar Nori
2017-09-21 14:43 ` Sekhar Nori
2017-09-21 15:11 ` Suman Anna
2017-09-21 15:11 ` Suman Anna
2017-09-22 9:12 ` Sekhar Nori
2017-09-22 9:12 ` Sekhar Nori
2017-09-22 16:24 ` Suman Anna
2017-09-22 16:24 ` Suman Anna
2017-09-22 16:43 ` David Lechner
2017-09-22 16:43 ` David Lechner
2017-09-26 9:56 ` Sekhar Nori
2017-09-26 9:56 ` Sekhar Nori
2017-09-26 16:28 ` David Lechner
2017-09-26 16:28 ` David Lechner
2017-09-26 9:50 ` Sekhar Nori
2017-09-26 9:50 ` Sekhar Nori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.