* [PATCH 1/1] selftests/powerpc: fix TARGETS in powerpc selftests makefile
@ 2014-06-25 5:18 Sam Bobroff
2014-06-26 8:21 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Sam Bobroff @ 2014-06-25 5:18 UTC (permalink / raw)
To: linuxppc-dev
This patch changes the name of a make variable (TARGETS) to prevent it
from colliding with a value set by the user on the command line (as
they are recommended to do by tools/testing/selftests/README.txt).
Before this patch, "make -C tools/testing/selftests TARGETS=powerpc"
would fail.
Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
---
tools/testing/selftests/powerpc/Makefile | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/powerpc/Makefile b/tools/testing/selftests/powerpc/Makefile
index 54833a7..84795c0 100644
--- a/tools/testing/selftests/powerpc/Makefile
+++ b/tools/testing/selftests/powerpc/Makefile
@@ -13,22 +13,22 @@ CFLAGS := -Wall -O2 -flto -Wall -Werror -DGIT_VERSION='"$(GIT_VERSION)"' -I$(CUR
export CC CFLAGS
-TARGETS = pmu copyloops mm tm
+SUB_TARGETS = pmu copyloops mm tm
endif
all:
- @for TARGET in $(TARGETS); do \
+ @for TARGET in $(SUB_TARGETS); do \
$(MAKE) -C $$TARGET all; \
done;
run_tests: all
- @for TARGET in $(TARGETS); do \
+ @for TARGET in $(SUB_TARGETS); do \
$(MAKE) -C $$TARGET run_tests; \
done;
clean:
- @for TARGET in $(TARGETS); do \
+ @for TARGET in $(SUB_TARGETS); do \
$(MAKE) -C $$TARGET clean; \
done;
rm -f tags
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] selftests/powerpc: fix TARGETS in powerpc selftests makefile
2014-06-25 5:18 [PATCH 1/1] selftests/powerpc: fix TARGETS in powerpc selftests makefile Sam Bobroff
@ 2014-06-26 8:21 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2014-06-26 8:21 UTC (permalink / raw)
To: Sam Bobroff; +Cc: linuxppc-dev
On Wed, 2014-06-25 at 15:18 +1000, Sam Bobroff wrote:
> This patch changes the name of a make variable (TARGETS) to prevent it
> from colliding with a value set by the user on the command line (as
> they are recommended to do by tools/testing/selftests/README.txt).
>
> Before this patch, "make -C tools/testing/selftests TARGETS=powerpc"
> would fail.
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-26 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-25 5:18 [PATCH 1/1] selftests/powerpc: fix TARGETS in powerpc selftests makefile Sam Bobroff
2014-06-26 8:21 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.