[PATCH] imx8mq_evk: Update the required ATF branch

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

Following the README instructions leads to a non-booting
U-Boot:

U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
PMIC:  PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
Normal Boot
Trying to boot from MMC2

(It hangs here)

Use the "imx_4.19.35_1.0.0" ATF branch instead, which
fixes such problem and allow the boot to complete again.

Suggested-by: Adam Ford <aford173@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 board/freescale/imx8mq_evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/freescale/imx8mq_evk/README b/board/freescale/imx8mq_evk/README
index c1d400bcf9..4f671b069c 100644
--- a/board/freescale/imx8mq_evk/README
+++ b/board/freescale/imx8mq_evk/README
@@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
 ======================================
 Note: srctree is U-Boot source directory
 Get ATF from: https://source.codeaurora.org/external/imx/imx-atf
-branch: imx_4.14.62_1.0.0_beta
+branch: imx_4.19.35_1.0.0
 $ make PLAT=imx8mq bl31
 $ cp build/imx8mq/release/bl31.bin $(srctree)
 
-- 
2.17.1

[PATCH] imx8mq_evk: Update the required ATF branch

[Adam Ford]

On Wed, Dec 11, 2019 at 7:49 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Following the README instructions leads to a non-booting
> U-Boot:
>
> U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
> PMIC:  PFUZE100 ID=0x10
> DDRINFO: start DRAM init
> DDRINFO:ddrphy calibration done
> DDRINFO: ddrmix config done
> Normal Boot
> Trying to boot from MMC2
>
> (It hangs here)
>
> Use the "imx_4.19.35_1.0.0" ATF branch instead, which
> fixes such problem and allow the boot to complete again.

Shouldn't we address the mix-match of the firmware-imx  versions as well?

I just increasing numbers over and over, and I was able to use
firmware 8.5 which.

The readme lists both 7.9 and 8.0.  There is also a typo on the line
that reads "./firmware-imx-8.0" which should have a .bin appended to
it.

It would nice to know what the differences are between the versions.

adam
>
> Suggested-by: Adam Ford <aford173@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  board/freescale/imx8mq_evk/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/imx8mq_evk/README b/board/freescale/imx8mq_evk/README
> index c1d400bcf9..4f671b069c 100644
> --- a/board/freescale/imx8mq_evk/README
> +++ b/board/freescale/imx8mq_evk/README
> @@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
>  ======================================
>  Note: srctree is U-Boot source directory
>  Get ATF from: https://source.codeaurora.org/external/imx/imx-atf
> -branch: imx_4.14.62_1.0.0_beta
> +branch: imx_4.19.35_1.0.0
>  $ make PLAT=imx8mq bl31
>  $ cp build/imx8mq/release/bl31.bin $(srctree)
>
> --
> 2.17.1
>

[PATCH] imx8mq_evk: Update the required ATF branch

[Peng Fan]

> Subject: Re: [PATCH] imx8mq_evk: Update the required ATF branch
> 
> On Wed, Dec 11, 2019 at 7:49 AM Fabio Estevam <festevam@gmail.com>
> wrote:
> >
> > Following the README instructions leads to a non-booting
> > U-Boot:
> >
> > U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24
> > -0300)
> > PMIC:  PFUZE100 ID=0x10
> > DDRINFO: start DRAM init
> > DDRINFO:ddrphy calibration done
> > DDRINFO: ddrmix config done
> > Normal Boot
> > Trying to boot from MMC2
> >
> > (It hangs here)
> >
> > Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such
> > problem and allow the boot to complete again.

We might need to switch upstream ATF, or stick to NXP vendor release one?
> 
> Shouldn't we address the mix-match of the firmware-imx  versions as well?
> 
> I just increasing numbers over and over, and I was able to use firmware 8.5
> which.
> 
> The readme lists both 7.9 and 8.0.  There is also a typo on the line that reads
> "./firmware-imx-8.0" which should have a .bin appended to it.
> 
> It would nice to know what the differences are between the versions.

The version should already be in yocto release. I just use the new one when I
upstream code.

Thanks,
Peng.

> 
> adam
> >
> > Suggested-by: Adam Ford <aford173@gmail.com>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> >  board/freescale/imx8mq_evk/README | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/board/freescale/imx8mq_evk/README
> > b/board/freescale/imx8mq_evk/README
> > index c1d400bcf9..4f671b069c 100644
> > --- a/board/freescale/imx8mq_evk/README
> > +++ b/board/freescale/imx8mq_evk/README
> > @@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
> > ======================================
> >  Note: srctree is U-Boot source directory  Get ATF from:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
> >
> ce.codeaurora.org%2Fexternal%2Fimx%2Fimx-atf&amp;data=02%7C01%7Cp
> eng.f
> >
> an%40nxp.com%7C56fbd5d0b17c4949cc1708d77e41f5c5%7C686ea1d3bc2b
> 4c6fa92c
> >
> d99c5c301635%7C0%7C0%7C637116694069333717&amp;sdata=PxZh7ldsxb
> %2FxZK7c
> > J5OpJxblskZJkHZHuXvMqGQC5H4%3D&amp;reserved=0
> > -branch: imx_4.14.62_1.0.0_beta
> > +branch: imx_4.19.35_1.0.0
> >  $ make PLAT=imx8mq bl31
> >  $ cp build/imx8mq/release/bl31.bin $(srctree)
> >
> > --
> > 2.17.1
> >

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

Hi Adam,

On Wed, Dec 11, 2019 at 10:56 AM Adam Ford <aford173@gmail.com> wrote:

> Shouldn't we address the mix-match of the firmware-imx  versions as well?
>
> I just increasing numbers over and over, and I was able to use
> firmware 8.5 which.
>
> The readme lists both 7.9 and 8.0.  There is also a typo on the line
> that reads "./firmware-imx-8.0" which should have a .bin appended to
> it.

This error comes from the imx8mm-evk README. I am patching imx8mq-evk
README instead.

> It would nice to know what the differences are between the versions.

Yes, it is becoming painful to find the exact combination that works.

[PATCH] imx8mq_evk: Update the required ATF branch

[Adam Ford]

On Wed, Dec 11, 2019 at 8:00 AM Peng Fan <peng.fan@nxp.com> wrote:
>
> > Subject: Re: [PATCH] imx8mq_evk: Update the required ATF branch
> >
> > On Wed, Dec 11, 2019 at 7:49 AM Fabio Estevam <festevam@gmail.com>
> > wrote:
> > >
> > > Following the README instructions leads to a non-booting
> > > U-Boot:
> > >
> > > U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24
> > > -0300)
> > > PMIC:  PFUZE100 ID=0x10
> > > DDRINFO: start DRAM init
> > > DDRINFO:ddrphy calibration done
> > > DDRINFO: ddrmix config done
> > > Normal Boot
> > > Trying to boot from MMC2
> > >
> > > (It hangs here)
> > >
> > > Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such
> > > problem and allow the boot to complete again.
>
> We might need to switch upstream ATF, or stick to NXP vendor release one?
> >
> > Shouldn't we address the mix-match of the firmware-imx  versions as well?
> >
> > I just increasing numbers over and over, and I was able to use firmware 8.5
> > which.
> >
> > The readme lists both 7.9 and 8.0.  There is also a typo on the line that reads
> > "./firmware-imx-8.0" which should have a .bin appended to it.
> >
> > It would nice to know what the differences are between the versions.
>
> The version should already be in yocto release. I just use the new one when I
> upstream code.

Either way, the README file is currently wrong as it sits because it's
pulling one version of firmware and using a different version.

Is there a way to point to the release notes in a static location that
doesn't change with each release?  I don't use Yocto, so I don't
always notice when newer versions are available.

adam
>
> Thanks,
> Peng.
>
> >
> > adam
> > >
> > > Suggested-by: Adam Ford <aford173@gmail.com>
> > > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > > ---
> > >  board/freescale/imx8mq_evk/README | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/board/freescale/imx8mq_evk/README
> > > b/board/freescale/imx8mq_evk/README
> > > index c1d400bcf9..4f671b069c 100644
> > > --- a/board/freescale/imx8mq_evk/README
> > > +++ b/board/freescale/imx8mq_evk/README
> > > @@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
> > > ======================================
> > >  Note: srctree is U-Boot source directory  Get ATF from:
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
> > >
> > ce.codeaurora.org%2Fexternal%2Fimx%2Fimx-atf&amp;data=02%7C01%7Cp
> > eng.f
> > >
> > an%40nxp.com%7C56fbd5d0b17c4949cc1708d77e41f5c5%7C686ea1d3bc2b
> > 4c6fa92c
> > >
> > d99c5c301635%7C0%7C0%7C637116694069333717&amp;sdata=PxZh7ldsxb
> > %2FxZK7c
> > > J5OpJxblskZJkHZHuXvMqGQC5H4%3D&amp;reserved=0
> > > -branch: imx_4.14.62_1.0.0_beta
> > > +branch: imx_4.19.35_1.0.0
> > >  $ make PLAT=imx8mq bl31
> > >  $ cp build/imx8mq/release/bl31.bin $(srctree)
> > >
> > > --
> > > 2.17.1
> > >

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

Hi Peng,

On Wed, Dec 11, 2019 at 11:00 AM Peng Fan <peng.fan@nxp.com> wrote:

> We might need to switch upstream ATF, or stick to NXP vendor release one?

I don't have much background about the ATF upstream status on i.MX8 to
provide an opinion.

Does upstream ATF allow booting a U-Boot and mainline kernel?

This patch is the minimum change needed for booting mainline U-Boot.
If someone thinks that ATF upstream is a good choice, then feel free
to send a patch updating the README.

> The version should already be in yocto release. I just use the new one when I
> upstream code.

Please keep in mind that not everyone uses Yocto.

How do we know what is the correct firmware version we need to use?

[PATCH] imx8mq_evk: Update the required ATF branch

[Peng Fan]

> Subject: Re: [PATCH] imx8mq_evk: Update the required ATF branch
> 
> Hi Peng,
> 
> On Wed, Dec 11, 2019 at 11:00 AM Peng Fan <peng.fan@nxp.com> wrote:
> 
> > We might need to switch upstream ATF, or stick to NXP vendor release one?
> 
> I don't have much background about the ATF upstream status on i.MX8 to
> provide an opinion.
> 
> Does upstream ATF allow booting a U-Boot and mainline kernel?

Not tried. Keep vendor version is fine for now.

> 
> This patch is the minimum change needed for booting mainline U-Boot.
> If someone thinks that ATF upstream is a good choice, then feel free to send a
> patch updating the README.
> 
> > The version should already be in yocto release. I just use the new one
> > when I upstream code.
> 
> Please keep in mind that not everyone uses Yocto.
> 
> How do we know what is the correct firmware version we need to use?

I need to check with Yocto team, then back.

Thanks,
Peng.

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

Hi Peng,

On Wed, Dec 11, 2019 at 11:09 AM Peng Fan <peng.fan@nxp.com> wrote:

> Not tried. Keep vendor version is fine for now.

If you are happy with this patch, could you please provide your Acked-by?

I would like to keep the README accurate for the upcoming 2020.01 release.

Thanks

[PATCH] imx8mq_evk: Update the required ATF branch

[Schrempf Frieder]

On 11.12.19 15:05, Fabio Estevam wrote:
> Hi Peng,
> 
> On Wed, Dec 11, 2019 at 11:00 AM Peng Fan <peng.fan@nxp.com> wrote:
> 
>> We might need to switch upstream ATF, or stick to NXP vendor release one?
> 
> I don't have much background about the ATF upstream status on i.MX8 to
> provide an opinion.
> 
> Does upstream ATF allow booting a U-Boot and mainline kernel?
> 
> This patch is the minimum change needed for booting mainline U-Boot.
> If someone thinks that ATF upstream is a good choice, then feel free
> to send a patch updating the README.

Just for the record: I am using upstream ATF for my custom i.MX8MM board 
with mainline U-Boot and it just works fine. I didn't run into any 
issues so far and I'm still on ATF revision 3441952f61a6 and haven't 
updated for quite a while.

> 
>> The version should already be in yocto release. I just use the new one when I
>> upstream code.
> 
> Please keep in mind that not everyone uses Yocto.
> 
> How do we know what is the correct firmware version we need to use?
> 

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

On Wed, Dec 11, 2019 at 11:14 AM Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:

> Just for the record: I am using upstream ATF for my custom i.MX8MM board
> with mainline U-Boot and it just works fine. I didn't run into any
> issues so far and I'm still on ATF revision 3441952f61a6 and haven't
> updated for quite a while.

Thanks for the feedback.

Perhaps we can consider moving to mainline ATF after 2020.01 is released.

[PATCH] imx8mq_evk: Update the required ATF branch

[Peter Robinson]

On Wed, Dec 11, 2019 at 4:02 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Wed, Dec 11, 2019 at 11:14 AM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>
> > Just for the record: I am using upstream ATF for my custom i.MX8MM board
> > with mainline U-Boot and it just works fine. I didn't run into any
> > issues so far and I'm still on ATF revision 3441952f61a6 and haven't
> > updated for quite a while.
>
> Thanks for the feedback.
>
> Perhaps we can consider moving to mainline ATF after 2020.01 is released.

It would be useful to test against the upstream releases and document
against those rather than random vendor forks, upstream has fairly
consistent 6 monthly releases around March/October with the last one
being 2.2.

Peter

[PATCH] imx8mq_evk: Update the required ATF branch

[Peng Fan]

> Subject: [PATCH] imx8mq_evk: Update the required ATF branch
> 
> Following the README instructions leads to a non-booting
> U-Boot:
> 
> U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
> PMIC:  PFUZE100 ID=0x10
> DDRINFO: start DRAM init
> DDRINFO:ddrphy calibration done
> DDRINFO: ddrmix config done
> Normal Boot
> Trying to boot from MMC2
> 
> (It hangs here)
> 
> Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such problem
> and allow the boot to complete again.
> 
> Suggested-by: Adam Ford <aford173@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Acked-by: Peng Fan <peng.fan@nxp.com>

> ---
>  board/freescale/imx8mq_evk/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/imx8mq_evk/README
> b/board/freescale/imx8mq_evk/README
> index c1d400bcf9..4f671b069c 100644
> --- a/board/freescale/imx8mq_evk/README
> +++ b/board/freescale/imx8mq_evk/README
> @@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
> ======================================
>  Note: srctree is U-Boot source directory  Get ATF from:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource
> .codeaurora.org%2Fexternal%2Fimx%2Fimx-atf&amp;data=02%7C01%7Cpen
> g.fan%40nxp.com%7C15caa498b49343fabede08d77e40facf%7C686ea1d3bc
> 2b4c6fa92cd99c5c301635%7C0%7C0%7C637116689861712196&amp;sdata
> =GNw4g1oDo9ceM1VIEB9A11716fQQF1GNzpJ4L3n8FTM%3D&amp;reserved
> =0
> -branch: imx_4.14.62_1.0.0_beta
> +branch: imx_4.19.35_1.0.0
>  $ make PLAT=imx8mq bl31
>  $ cp build/imx8mq/release/bl31.bin $(srctree)
> 
> --
> 2.17.1

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

Hi Peter,

On Wed, Dec 11, 2019 at 10:09 PM Peter Robinson <pbrobinson@gmail.com> wrote:

> It would be useful to test against the upstream releases and document
> against those rather than random vendor forks, upstream has fairly
> consistent 6 monthly releases around March/October with the last one
> being 2.2.

I agree.

I plan to test the NXP i.MX8 boards with upstream ATF.

As we are at rc4 at the moment, I prefer we go with the updated vendor
ATF version as proposed in this patch and then after 2020.01 I plan to
test and switch to mainline ATF, so that we can have more time for
testing.

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

On Wed, Dec 11, 2019 at 10:20 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Peter,
>
> On Wed, Dec 11, 2019 at 10:09 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> > It would be useful to test against the upstream releases and document
> > against those rather than random vendor forks, upstream has fairly
> > consistent 6 monthly releases around March/October with the last one
> > being 2.2.
>
> I agree.
>
> I plan to test the NXP i.MX8 boards with upstream ATF.
>
> As we are at rc4 at the moment, I prefer we go with the updated vendor
> ATF version as proposed in this patch and then after 2020.01 I plan to
> test and switch to mainline ATF, so that we can have more time for
> testing.

Just did a quick boot test on a imx8mq-evk with v2.2 upstream ATF and
it booted fine.

[PATCH] imx8mq_evk: Update the required ATF branch

[Fabio Estevam]

On Wed, Dec 11, 2019 at 10:57 PM Fabio Estevam <festevam@gmail.com> wrote:

> Just did a quick boot test on a imx8mq-evk with v2.2 upstream ATF and
> it booted fine.

Actually I do see some power domain issues when using upstream ATF and
booting mainline kernel:

[    1.573227] imx-pgc imx-pgc-domain.3: failed to command PGC

[    1.813816] imx-pgc imx-pgc-domain.3: failed to command PGC

[    1.931568] imx-pgc imx-pgc-domain.3: failed to command PGC

So it seems there are some more work to do on the i.MX8M ATF upstream front.

[PATCH] imx8mq_evk: Update the required ATF branch

[sbabic at denx.de]

> Following the README instructions leads to a non-booting
> U-Boot:
> U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
> PMIC:  PFUZE100 ID=0x10
> DDRINFO: start DRAM init
> DDRINFO:ddrphy calibration done
> DDRINFO: ddrmix config done
> Normal Boot
> Trying to boot from MMC2
> (It hangs here)
> Use the "imx_4.19.35_1.0.0" ATF branch instead, which
> fixes such problem and allow the boot to complete again.
> Suggested-by: Adam Ford <aford173@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Acked-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[PATCH] imx8mq_evk: Update the required ATF branch

[Angus Ainslie]

On 2019-12-11 18:14, Fabio Estevam wrote:
> On Wed, Dec 11, 2019 at 10:57 PM Fabio Estevam <festevam@gmail.com> 
> wrote:
> 
>> Just did a quick boot test on a imx8mq-evk with v2.2 upstream ATF and
>> it booted fine.
> 
> Actually I do see some power domain issues when using upstream ATF and
> booting mainline kernel:
> 
> [    1.573227] imx-pgc imx-pgc-domain.3: failed to command PGC
> 
> [    1.813816] imx-pgc imx-pgc-domain.3: failed to command PGC
> 
> [    1.931568] imx-pgc imx-pgc-domain.3: failed to command PGC
> 
> So it seems there are some more work to do on the i.MX8M ATF upstream 
> front.

I think mainline ATF is also still missing DDR frequency scaling

https://lore.kernel.org/linux-arm-kernel/cover.1573761527.git.leonard.crestez at nxp.com/T/#m2b7ce4204632cad49888745a89f833cc95a2ff32