Build of u-boot with gold is broken

Build of u-boot with gold is broken

[Andrew Goodbody]

Hi,

It looks like the recent change to meta/recipes-bsp/u-boot/u-boot.inc to enable out of tree builds for u-boot does not work with gold.
The sed at line 70 fails as it is being executed in an empty build directory and so there is no config.mk.

Andrew

Re: Build of u-boot with gold is broken

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

On 19 August 2016 at 10:33, Andrew Goodbody <andrew.goodbody@cambrionix.com>
wrote:

> The sed at line 70 fails as it is being executed in an empty build
> directory and so there is no config.mk.
>

For fame and glory, can you send a tested patch to fix this?

Ross

[-- Attachment #2: Type: text/html, Size: 741 bytes --]

Re: Build of u-boot with gold is broken

[Andrew Goodbody]

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

From: Burton, Ross <ross.burton@intel.com>
On 19 August 2016 at 10:33, Andrew Goodbody <andrew.goodbody@cambrionix.com<mailto:andrew.goodbody@cambrionix.com>> wrote:
The sed at line 70 fails as it is being executed in an empty build directory and so there is no config.mk<http://config.mk>.

For fame and glory, can you send a tested patch to fix this?

Ross

Sorry but I am not sure about the best way to fix this.

Andrew

PS This is a resend (with additions below) as I neglected to copy the list, sorry - I was out of the office at the time.
It would be possible to simply cd into the source directory, apply the sed, then cd back to the build directory. However this seems to go against the point of having a separate build directory in that you are attempting to leave the source tree alone, or so I assume.
In my local tree I simply revert

commit 36f110594506fbee5dc18de3a04981f019f2024d
Author: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
Date:   Tue Aug 9 10:15:07 2016 -0700

    u-boot.inc: Enable out-of-tree builds

    This patch enabled out-of-tree builds for u-boot. This also helps building
    u-boot using EXTERNALSRC flow

    Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
    Signed-off-by: Ross Burton <ross.burton@intel.com>

[-- Attachment #2: Type: text/html, Size: 6529 bytes --]

Re: Build of u-boot with gold is broken

[Manjukumar Harthikote Matha]

Hi All,

On 08/30/2016 02:57 AM, Andrew Goodbody wrote:
> *From:*Burton, Ross <ross.burton@intel.com>
>
> On 19 August 2016 at 10:33, Andrew Goodbody
> <andrew.goodbody@cambrionix.com <mailto:andrew.goodbody@cambrionix.com>>
> wrote:
>
>     The sed at line 70 fails as it is being executed in an empty build
>     directory and so there is no config.mk <http://config.mk>.
>
>
>
> For fame and glory, can you send a tested patch to fix this?
>
>
>
> Ross
>
>
> Sorry but I am not sure about the best way to fix this.
>
> Andrew
>
>
>
> PS This is a resend (with additions below) as I neglected to copy the
> list, sorry – I was out of the office at the time.
>
> It would be possible to simply cd into the source directory, apply the
> sed, then cd back to the build directory. However this seems to go
> against the point of having a separate build directory in that you are
> attempting to leave the source tree alone, or so I assume.
>
Can we do ${S}/config.mk ? Meaning
sed -i 's/$(CROSS_COMPILE)ld$/$(CROSS_COMPILE)ld.bfd/g' ${S}/config.mk
I dont have a setup for gold linker, If you can send the instructions I 
will give it a try

Thanks
Manju

Re: Build of u-boot with gold is broken

[Andrew Goodbody]

> From: Manjukumar Harthikote Matha [mailto:manjukumar.harthikote-
> matha@xilinx.com]
> 
> Can we do ${S}/config.mk ? Meaning
> sed -i 's/$(CROSS_COMPILE)ld$/$(CROSS_COMPILE)ld.bfd/g' ${S}/config.mk I
> dont have a setup for gold linker, If you can send the instructions I will give it
> a try
> 
> Thanks
> Manju

That works. I have sent a patch.

Andrew

Re: Build of u-boot with gold is broken

[Andrew Goodbody]

> > On Aug 18, 2016, at 6:44 AM, Andrew Goodbody
> <andrew.goodbody@cambrionix.com> wrote:
> >
> > Hi,
> >
> > It looks like the recent change to meta/recipes-bsp/u-boot/u-boot.inc to
> enable out of tree builds for u-boot does not work with gold.
> > The sed at line 70 fails as it is being executed in an empty build directory
> and so there is no config.mk.
> >
> 
> Send this to OE-core list you might need to add cd ${B} at beginning of
> do_compile

I wish it were that simple, but it does a cd ${B} before the call to do_compile, but ${B} is empty. Anyway I have resent this to oe-core, sorry for the noise.

Andrew

Re: Build of u-boot with gold is broken

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]


> On Aug 18, 2016, at 6:44 AM, Andrew Goodbody <andrew.goodbody@cambrionix.com> wrote:
> 
> Hi,
> 
> It looks like the recent change to meta/recipes-bsp/u-boot/u-boot.inc to enable out of tree builds for u-boot does not work with gold.
> The sed at line 70 fails as it is being executed in an empty build directory and so there is no config.mk.
> 

Send this to OE-core list you might need to add cd ${B} at beginning of do_compile


> Andrew
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Build of u-boot with gold is broken

[Andrew Goodbody]

Hi,

It looks like the recent change to meta/recipes-bsp/u-boot/u-boot.inc to enable out of tree builds for u-boot does not work with gold.
The sed at line 70 fails as it is being executed in an empty build directory and so there is no config.mk.

Andrew