* [PATCH] Updated locking documentation for journal_head
[not found] <9864e9792b56bce87b016582a8759890079f7766>
@ 2021-03-19 9:18 ` Alexander Lochmann
2021-03-19 10:37 ` Jan Kara
2021-03-19 10:47 ` [PATCH v2] " Alexander Lochmann
1 sibling, 1 reply; 4+ messages in thread
From: Alexander Lochmann @ 2021-03-19 9:18 UTC (permalink / raw)
To: jack; +Cc: Alexander Lochmann, Horst Schirmeier, linux-kernel
LockDoc's results show that t_list_lock has been
replaced by j_list_lock for b_next_transaction,
b_tnext, and b_tprev.
We, therefore, updated the documentation
accordingly.
Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
---
include/linux/journal-head.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
index 75bc56109031..d68ae72784eb 100644
--- a/include/linux/journal-head.h
+++ b/include/linux/journal-head.h
@@ -80,13 +80,13 @@ struct journal_head {
* Pointer to the running compound transaction which is currently
* modifying the buffer's metadata, if there was already a transaction
* committing it when the new transaction touched it.
- * [t_list_lock] [b_state_lock]
+ * [j_list_lock] [b_state_lock]
*/
transaction_t *b_next_transaction;
/*
* Doubly-linked list of buffers on a transaction's data, metadata or
- * forget queue. [t_list_lock] [b_state_lock]
+ * forget queue. [j_list_lock] [b_state_lock]
*/
struct journal_head *b_tnext, *b_tprev;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Updated locking documentation for journal_head
2021-03-19 9:18 ` [PATCH] Updated locking documentation for journal_head Alexander Lochmann
@ 2021-03-19 10:37 ` Jan Kara
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2021-03-19 10:37 UTC (permalink / raw)
To: Alexander Lochmann; +Cc: jack, Horst Schirmeier, linux-kernel
On Fri 19-03-21 10:18:17, Alexander Lochmann wrote:
> LockDoc's results show that t_list_lock has been
> replaced by j_list_lock for b_next_transaction,
> b_tnext, and b_tprev.
> We, therefore, updated the documentation
> accordingly.
>
> Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
> Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Yeah, I think that was a typo since the beginning. Thanks for the fix. Feel
free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/journal-head.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 75bc56109031..d68ae72784eb 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -80,13 +80,13 @@ struct journal_head {
> * Pointer to the running compound transaction which is currently
> * modifying the buffer's metadata, if there was already a transaction
> * committing it when the new transaction touched it.
> - * [t_list_lock] [b_state_lock]
> + * [j_list_lock] [b_state_lock]
> */
> transaction_t *b_next_transaction;
>
> /*
> * Doubly-linked list of buffers on a transaction's data, metadata or
> - * forget queue. [t_list_lock] [b_state_lock]
> + * forget queue. [j_list_lock] [b_state_lock]
> */
> struct journal_head *b_tnext, *b_tprev;
>
> --
> 2.20.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] Updated locking documentation for journal_head
[not found] <9864e9792b56bce87b016582a8759890079f7766>
2021-03-19 9:18 ` [PATCH] Updated locking documentation for journal_head Alexander Lochmann
@ 2021-03-19 10:47 ` Alexander Lochmann
2021-06-05 13:07 ` Alexander Lochmann
1 sibling, 1 reply; 4+ messages in thread
From: Alexander Lochmann @ 2021-03-19 10:47 UTC (permalink / raw)
To: jack; +Cc: Alexander Lochmann, Horst Schirmeier, linux-kernel
LockDoc's results show that t_list_lock has been
replaced by j_list_lock for b_next_transaction,
b_tnext, and b_tprev.
We, therefore, updated the documentation
accordingly.
Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Reviewed-by: Jan Kara <jack@suse.cz>
---
include/linux/journal-head.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
index 75bc56109031..d68ae72784eb 100644
--- a/include/linux/journal-head.h
+++ b/include/linux/journal-head.h
@@ -80,13 +80,13 @@ struct journal_head {
* Pointer to the running compound transaction which is currently
* modifying the buffer's metadata, if there was already a transaction
* committing it when the new transaction touched it.
- * [t_list_lock] [b_state_lock]
+ * [j_list_lock] [b_state_lock]
*/
transaction_t *b_next_transaction;
/*
* Doubly-linked list of buffers on a transaction's data, metadata or
- * forget queue. [t_list_lock] [b_state_lock]
+ * forget queue. [j_list_lock] [b_state_lock]
*/
struct journal_head *b_tnext, *b_tprev;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Updated locking documentation for journal_head
2021-03-19 10:47 ` [PATCH v2] " Alexander Lochmann
@ 2021-06-05 13:07 ` Alexander Lochmann
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Lochmann @ 2021-06-05 13:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Horst Schirmeier, Theodore Ts'o, Jan Kara
[-- Attachment #1.1: Type: text/plain, Size: 1748 bytes --]
Hi folks,
Have you had the chance to review my patch?
Does is look good to you?
Jan already approved it.
Regards,
Alex
On 19.03.21 11:47, Alexander Lochmann wrote:
> LockDoc's results show that t_list_lock has been
> replaced by j_list_lock for b_next_transaction,
> b_tnext, and b_tprev.
> We, therefore, updated the documentation
> accordingly.
>
> Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
> Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
> include/linux/journal-head.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 75bc56109031..d68ae72784eb 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -80,13 +80,13 @@ struct journal_head {
> * Pointer to the running compound transaction which is currently
> * modifying the buffer's metadata, if there was already a transaction
> * committing it when the new transaction touched it.
> - * [t_list_lock] [b_state_lock]
> + * [j_list_lock] [b_state_lock]
> */
> transaction_t *b_next_transaction;
>
> /*
> * Doubly-linked list of buffers on a transaction's data, metadata or
> - * forget queue. [t_list_lock] [b_state_lock]
> + * forget queue. [j_list_lock] [b_state_lock]
> */
> struct journal_head *b_tnext, *b_tprev;
>
>
--
Technische Universität Dortmund
Alexander Lochmann PGP key: 0xBC3EF6FD
Otto-Hahn-Str. 16 phone: +49.231.7556141
D-44227 Dortmund fax: +49.231.7556116
http://ess.cs.tu-dortmund.de/Staff/al
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-05 13:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <9864e9792b56bce87b016582a8759890079f7766>
2021-03-19 9:18 ` [PATCH] Updated locking documentation for journal_head Alexander Lochmann
2021-03-19 10:37 ` Jan Kara
2021-03-19 10:47 ` [PATCH v2] " Alexander Lochmann
2021-06-05 13:07 ` Alexander Lochmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.