From: <Eugen.Hristev@microchip.com> To: <linux@roeck-us.net> Cc: <wim@linux-watchdog.org>, <robh+dt@kernel.org>, <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <linux-watchdog@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 2/2] watchdog: sama5d4_wdt: addition of sam9x60 compatible watchdog Date: Thu, 7 Nov 2019 17:10:45 +0000 [thread overview] Message-ID: <cfa73eee-8ba9-89f2-b218-886ab226a6da@microchip.com> (raw) In-Reply-To: <20191107164104.GA7693@roeck-us.net> On 07.11.2019 18:41, Guenter Roeck wrote: > On Thu, Nov 07, 2019 at 12:51:15PM +0000, Eugen.Hristev@microchip.com wrote: >> >>>> >>>> - if ((wdt->mr & AT91_WDT_WDFIEN) && irq) { >>>> + irq = irq_of_parse_and_map(dev->of_node, 0); >>>> + if (!irq) { >>>> + dev_warn(dev, "failed to get IRQ from DT\n"); >>>> + wdt->need_irq = 0; >>> >>> Does it make sense to ignore that ? >> >> Hi Guenter, >> >> Can you detail what exactly is ignored ? >> > The missing interrupt. Hi, The interrupt is not mandatory for the work of the watchdog. So, if it's not available, we must act accordingly: just configure watchdog to reset the CPU. If we have an IRQ, we can then act in the 'software-style' watchdog: trigger an IRQ first and try to allow the system to a safe reboot. So , it's not ignoring, it's acting accordingly (later on, do not enable anything irq-related ) > >>>> +static struct sama5d4_wdt_data sama5d4_config; >>>> + >>>> +static struct sama5d4_wdt_data sam9x60_config = { >>>> + .sam9x60_support = 1, >>>> +}; >>> >>> Unless there is reason to believe that there will be other >>> configuration data, please just assign the flag value directly >>> to .data and add a variable to struct sama5d4_wdt to access it. >>> Please make that variable a bool. >> >> There will be more configuration data for future products, but not at >> this moment. Do the change or keep it this way ? >> > If not as part of this series, it is better to just assign > the flag directly. If there are changes coming at a later time > which indeed need a structure (with more than one object in it), > that structure can be added at that time. Ok, I will change it in next version. Thanks, Eugen > > Guenter > >
WARNING: multiple messages have this Message-ID (diff)
From: <Eugen.Hristev@microchip.com> To: <linux@roeck-us.net> Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, wim@linux-watchdog.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] watchdog: sama5d4_wdt: addition of sam9x60 compatible watchdog Date: Thu, 7 Nov 2019 17:10:45 +0000 [thread overview] Message-ID: <cfa73eee-8ba9-89f2-b218-886ab226a6da@microchip.com> (raw) In-Reply-To: <20191107164104.GA7693@roeck-us.net> On 07.11.2019 18:41, Guenter Roeck wrote: > On Thu, Nov 07, 2019 at 12:51:15PM +0000, Eugen.Hristev@microchip.com wrote: >> >>>> >>>> - if ((wdt->mr & AT91_WDT_WDFIEN) && irq) { >>>> + irq = irq_of_parse_and_map(dev->of_node, 0); >>>> + if (!irq) { >>>> + dev_warn(dev, "failed to get IRQ from DT\n"); >>>> + wdt->need_irq = 0; >>> >>> Does it make sense to ignore that ? >> >> Hi Guenter, >> >> Can you detail what exactly is ignored ? >> > The missing interrupt. Hi, The interrupt is not mandatory for the work of the watchdog. So, if it's not available, we must act accordingly: just configure watchdog to reset the CPU. If we have an IRQ, we can then act in the 'software-style' watchdog: trigger an IRQ first and try to allow the system to a safe reboot. So , it's not ignoring, it's acting accordingly (later on, do not enable anything irq-related ) > >>>> +static struct sama5d4_wdt_data sama5d4_config; >>>> + >>>> +static struct sama5d4_wdt_data sam9x60_config = { >>>> + .sam9x60_support = 1, >>>> +}; >>> >>> Unless there is reason to believe that there will be other >>> configuration data, please just assign the flag value directly >>> to .data and add a variable to struct sama5d4_wdt to access it. >>> Please make that variable a bool. >> >> There will be more configuration data for future products, but not at >> this moment. Do the change or keep it this way ? >> > If not as part of this series, it is better to just assign > the flag directly. If there are changes coming at a later time > which indeed need a structure (with more than one object in it), > that structure can be added at that time. Ok, I will change it in next version. Thanks, Eugen > > Guenter > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-07 17:10 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-21 9:14 [PATCH v2 1/2] dt-bindings: watchdog: sama5d4_wdt: add microchip,sam9x60-wdt compatible Eugen.Hristev 2019-10-21 9:14 ` Eugen.Hristev 2019-10-21 9:14 ` [PATCH v2 2/2] watchdog: sama5d4_wdt: addition of sam9x60 compatible watchdog Eugen.Hristev 2019-10-21 9:14 ` Eugen.Hristev 2019-10-29 13:28 ` Guenter Roeck 2019-10-29 13:28 ` Guenter Roeck 2019-11-07 12:51 ` Eugen.Hristev 2019-11-07 12:51 ` Eugen.Hristev 2019-11-07 16:41 ` Guenter Roeck 2019-11-07 16:41 ` Guenter Roeck 2019-11-07 17:10 ` Eugen.Hristev [this message] 2019-11-07 17:10 ` Eugen.Hristev 2019-10-25 21:33 ` [PATCH v2 1/2] dt-bindings: watchdog: sama5d4_wdt: add microchip,sam9x60-wdt compatible Rob Herring 2019-10-25 21:33 ` Rob Herring 2019-10-29 13:16 ` Guenter Roeck 2019-10-29 13:16 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cfa73eee-8ba9-89f2-b218-886ab226a6da@microchip.com \ --to=eugen.hristev@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=robh+dt@kernel.org \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.