* [PATCH v2] coreaudio: Notify error in coreaudio_init_out
@ 2022-02-26 11:59 Akihiko Odaki
2022-03-01 0:00 ` Philippe Mathieu-Daudé
2022-03-28 18:50 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Akihiko Odaki @ 2022-02-26 11:59 UTC (permalink / raw)
Cc: Christian Schoenebeck, qemu-devel, Akihiko Odaki, Gerd Hoffmann
Otherwise, the audio subsystem tries to use the voice and
eventually aborts due to the maximum number of samples in the
buffer is not set.
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
audio/coreaudio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index d8a21d3e507..d7cfdcc4fc4 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
coreaudio_playback_logerr(status,
"Could not remove voice property change listener\n");
}
+
+ return -1;
}
return 0;
--
2.32.0 (Apple Git-132)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] coreaudio: Notify error in coreaudio_init_out
2022-02-26 11:59 [PATCH v2] coreaudio: Notify error in coreaudio_init_out Akihiko Odaki
@ 2022-03-01 0:00 ` Philippe Mathieu-Daudé
2022-03-28 18:50 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-03-01 0:00 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: Christian Schoenebeck, qemu-devel, Gerd Hoffmann
On 26/2/22 12:59, Akihiko Odaki wrote:
> Otherwise, the audio subsystem tries to use the voice and
> eventually aborts due to the maximum number of samples in the
> buffer is not set.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
> audio/coreaudio.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] coreaudio: Notify error in coreaudio_init_out
2022-02-26 11:59 [PATCH v2] coreaudio: Notify error in coreaudio_init_out Akihiko Odaki
2022-03-01 0:00 ` Philippe Mathieu-Daudé
@ 2022-03-28 18:50 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-03-28 18:50 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: Christian Schoenebeck, qemu-devel, Gerd Hoffmann
On 26/2/22 12:59, Akihiko Odaki wrote:
> Otherwise, the audio subsystem tries to use the voice and
> eventually aborts due to the maximum number of samples in the
> buffer is not set.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
> audio/coreaudio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/audio/coreaudio.c b/audio/coreaudio.c
> index d8a21d3e507..d7cfdcc4fc4 100644
> --- a/audio/coreaudio.c
> +++ b/audio/coreaudio.c
> @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
> coreaudio_playback_logerr(status,
> "Could not remove voice property change listener\n");
> }
> +
> + return -1;
> }
>
> return 0;
Merged as commit bd7819de22.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-28 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-26 11:59 [PATCH v2] coreaudio: Notify error in coreaudio_init_out Akihiko Odaki
2022-03-01 0:00 ` Philippe Mathieu-Daudé
2022-03-28 18:50 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.