All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Maxime Ripard <maxime@cerno.tech>, Eric Anholt <eric@anholt.net>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 2/8] drm/vc4: dsi: Correct DSI register definition
Date: Tue, 8 Dec 2020 09:34:05 +0100	[thread overview]
Message-ID: <cfcfd349-e0fc-8bd0-4c9e-6cc33bf5f056@kontron.de> (raw)
In-Reply-To: <20201203132543.861591-3-maxime@cerno.tech>

Hi Maxime,

On 03.12.20 14:25, Maxime Ripard wrote:
> From: Dave Stevenson <dave.stevenson@raspberrypi.com>
> 
> The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register
> definitions were swapped, so trying to use more than a single data
> lane failed as lane 1 would get powered down.
> (In theory a 4 lane device would work as all lanes would remain
> powered).
> 
> Correct the definitions.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Wouldn't this deserve a "Fixes: ..." and "Cc: stable@vger.kernel.org" 
tag, as this bug is present in all stable releases since this driver was 
introduced? I think it would be really helpful to have it backported.

Thanks
Frieder

> ---
>   drivers/gpu/drm/vc4/vc4_dsi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index b1d8765795f1..bb316e6cc12b 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -306,11 +306,11 @@
>   # define DSI0_PHY_AFEC0_RESET			BIT(11)
>   # define DSI1_PHY_AFEC0_PD_BG			BIT(11)
>   # define DSI0_PHY_AFEC0_PD			BIT(10)
> -# define DSI1_PHY_AFEC0_PD_DLANE3		BIT(10)
> +# define DSI1_PHY_AFEC0_PD_DLANE1		BIT(10)
>   # define DSI0_PHY_AFEC0_PD_BG			BIT(9)
>   # define DSI1_PHY_AFEC0_PD_DLANE2		BIT(9)
>   # define DSI0_PHY_AFEC0_PD_DLANE1		BIT(8)
> -# define DSI1_PHY_AFEC0_PD_DLANE1		BIT(8)
> +# define DSI1_PHY_AFEC0_PD_DLANE3		BIT(8)
>   # define DSI_PHY_AFEC0_PTATADJ_MASK		VC4_MASK(7, 4)
>   # define DSI_PHY_AFEC0_PTATADJ_SHIFT		4
>   # define DSI_PHY_AFEC0_CTATADJ_MASK		VC4_MASK(3, 0)
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Maxime Ripard <maxime@cerno.tech>, Eric Anholt <eric@anholt.net>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 2/8] drm/vc4: dsi: Correct DSI register definition
Date: Tue, 8 Dec 2020 09:34:05 +0100	[thread overview]
Message-ID: <cfcfd349-e0fc-8bd0-4c9e-6cc33bf5f056@kontron.de> (raw)
In-Reply-To: <20201203132543.861591-3-maxime@cerno.tech>

Hi Maxime,

On 03.12.20 14:25, Maxime Ripard wrote:
> From: Dave Stevenson <dave.stevenson@raspberrypi.com>
> 
> The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register
> definitions were swapped, so trying to use more than a single data
> lane failed as lane 1 would get powered down.
> (In theory a 4 lane device would work as all lanes would remain
> powered).
> 
> Correct the definitions.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Wouldn't this deserve a "Fixes: ..." and "Cc: stable@vger.kernel.org" 
tag, as this bug is present in all stable releases since this driver was 
introduced? I think it would be really helpful to have it backported.

Thanks
Frieder

> ---
>   drivers/gpu/drm/vc4/vc4_dsi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index b1d8765795f1..bb316e6cc12b 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -306,11 +306,11 @@
>   # define DSI0_PHY_AFEC0_RESET			BIT(11)
>   # define DSI1_PHY_AFEC0_PD_BG			BIT(11)
>   # define DSI0_PHY_AFEC0_PD			BIT(10)
> -# define DSI1_PHY_AFEC0_PD_DLANE3		BIT(10)
> +# define DSI1_PHY_AFEC0_PD_DLANE1		BIT(10)
>   # define DSI0_PHY_AFEC0_PD_BG			BIT(9)
>   # define DSI1_PHY_AFEC0_PD_DLANE2		BIT(9)
>   # define DSI0_PHY_AFEC0_PD_DLANE1		BIT(8)
> -# define DSI1_PHY_AFEC0_PD_DLANE1		BIT(8)
> +# define DSI1_PHY_AFEC0_PD_DLANE3		BIT(8)
>   # define DSI_PHY_AFEC0_PTATADJ_MASK		VC4_MASK(7, 4)
>   # define DSI_PHY_AFEC0_PTATADJ_SHIFT		4
>   # define DSI_PHY_AFEC0_CTATADJ_MASK		VC4_MASK(3, 0)
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-12-08  8:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 13:25 [PATCH 0/8] drm/vc4: DSI improvements and BCM2711 support Maxime Ripard
2020-12-03 13:25 ` Maxime Ripard
2020-12-03 13:25 ` [PATCH 1/8] drm/vc4: drv: Remove the DSI pointer in vc4_drv Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-09 11:02   ` Nicolas Saenz Julienne
2020-12-09 11:02     ` Nicolas Saenz Julienne
2020-12-03 13:25 ` [PATCH 2/8] drm/vc4: dsi: Correct DSI register definition Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-08  8:34   ` Frieder Schrempf [this message]
2020-12-08  8:34     ` Frieder Schrempf
2020-12-09 11:04     ` Nicolas Saenz Julienne
2020-12-09 11:04       ` Nicolas Saenz Julienne
2020-12-11 10:17     ` Maxime Ripard
2020-12-11 10:17       ` Maxime Ripard
2020-12-03 13:25 ` [PATCH 3/8] drm/vc4: dsi: Use snprintf for the PHY clocks instead of an array Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-03 13:25 ` [PATCH 4/8] drm/vc4: dsi: Introduce a variant structure Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-03 13:25 ` [PATCH 5/8] drm/vc4: dsi: Add support for DSI0 Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-03 13:25 ` [PATCH 6/8] dt-bindings: Add compatible for BCM2711 DSI1 Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-03 13:25 ` [PATCH 7/8] drm/vc4: dsi: Add configuration " Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-03 13:25 ` [PATCH 8/8] ARM: dts: bcm2711: Use compatible string " Maxime Ripard
2020-12-03 13:25   ` Maxime Ripard
2020-12-21 12:18   ` Nicolas Saenz Julienne
2020-12-21 12:18     ` Nicolas Saenz Julienne
2020-12-03 15:19 ` [PATCH 0/8] drm/vc4: DSI improvements and BCM2711 support Dave Stevenson
2020-12-03 15:19   ` Dave Stevenson
2020-12-07  9:34   ` Maxime Ripard
2020-12-07  9:34     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfcfd349-e0fc-8bd0-4c9e-6cc33bf5f056@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=airlied@linux.ie \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=daniel.vetter@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime@cerno.tech \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.