All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/7] Microblaze target arch support
@ 2011-05-05 19:10 Adrian Alonso
  2011-05-05 19:10 ` [PATCH 1/7] insane: add micrblaze target info Adrian Alonso
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:10 UTC (permalink / raw)
  To: poky

* Microblaze big-endian soft-cpu support
* Only external-toolchain support using meta-xilinx layer
* meta-xilinx layer provides an initramfs-image descriptor
  so only a limited subset of packages can be built due to basic
  glibc support
* To use set in user local.conf
  POKYMODE = "xilinx-external"
  XILINX_TOOLCHAIN "Absolute path of prebuilt toolchain"
* Prebuilt toolchain can be found at:
  git://git.xilinx.com/xldk/microblaze_v2.0.git

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: aalonso/external-toolchain
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=aalonso/external-toolchain

Thanks,
    Adrian Alonso <aalonso@secretlab.ca>
---


Adrian Alonso (7):
  insane: add micrblaze target info
  kernel-arch: add microblaze to valid archs
  siteinfo: add microblaze target info
  linux-libc-headers: add microblaze ARCH definition
  image-mklibs: add microblaze arch support
  package_rpm: use target vendor information
  readline: update version

 meta/classes/image-mklibs.bbclass                  |    2 +-
 meta/classes/insane.bbclass                        |    4 +++-
 meta/classes/kernel-arch.bbclass                   |    3 ++-
 meta/classes/package_rpm.bbclass                   |    3 ++-
 meta/classes/siteinfo.bbclass                      |    1 +
 meta/recipes-core/readline/readline_6.2.bb         |    6 ++++++
 .../linux-libc-headers_2.6.37.2.bb                 |    3 ++-
 7 files changed, 17 insertions(+), 5 deletions(-)
 create mode 100644 meta/recipes-core/readline/readline_6.2.bb

-- 
1.7.4.4



^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/7] insane: add micrblaze target info
  2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
@ 2011-05-05 19:10 ` Adrian Alonso
  2011-05-08  6:14   ` Khem Raj
  2011-05-05 19:10 ` [PATCH 2/7] kernel-arch: add microblaze to valid archs Adrian Alonso
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:10 UTC (permalink / raw)
  To: poky

* package_qa_get_machine_dict
* Add microblaze dic entry for QA
* Prebuilt toolchain triplet microblaze-unknown-linux-gnu-
* TARGET_OS is linux-gnu for this toolchain

Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
 meta/classes/insane.bbclass |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 742be5e..e9d4bfa 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -85,7 +85,9 @@ def package_qa_get_machine_dict():
             "linux-uclibcspe" : {
                         "powerpc":    (20,     0,    0,          False,         32),
                       },
-
+            "linux-gnu" :       {
+                        "microblaze": (47787,  0,    0,          False,         32),
+                      },
        }
 
 
-- 
1.7.4.4



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/7] kernel-arch: add microblaze to valid archs
  2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
  2011-05-05 19:10 ` [PATCH 1/7] insane: add micrblaze target info Adrian Alonso
@ 2011-05-05 19:10 ` Adrian Alonso
  2011-05-05 19:10 ` [PATCH 3/7] siteinfo: add microblaze target info Adrian Alonso
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:10 UTC (permalink / raw)
  To: poky

* Add Microblaze target to valid arch list definition

Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
 meta/classes/kernel-arch.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/classes/kernel-arch.bbclass b/meta/classes/kernel-arch.bbclass
index d6ae2e7..692d4fb 100644
--- a/meta/classes/kernel-arch.bbclass
+++ b/meta/classes/kernel-arch.bbclass
@@ -12,7 +12,8 @@ valid_archs = "alpha cris ia64 \
                m32r mips \
 	       sh sh64 um h8300   \
 	       parisc s390  v850 \
-	       avr32 blackfin"
+	       avr32 blackfin \
+              microblaze"
 
 def map_kernel_arch(a, d):
 	import re
-- 
1.7.4.4



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 3/7] siteinfo: add microblaze target info
  2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
  2011-05-05 19:10 ` [PATCH 1/7] insane: add micrblaze target info Adrian Alonso
  2011-05-05 19:10 ` [PATCH 2/7] kernel-arch: add microblaze to valid archs Adrian Alonso
@ 2011-05-05 19:10 ` Adrian Alonso
  2011-05-05 19:11 ` [PATCH 4/7] linux-libc-headers: add microblaze ARCH definition Adrian Alonso
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:10 UTC (permalink / raw)
  To: poky

* Add microblaze target info
* Microblaze soft CPU can be configured as big-endian/little-endian
* Currently target info support for microblaze big endian, using prebuilt
  toolchains.

Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
 meta/classes/siteinfo.bbclass |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/classes/siteinfo.bbclass b/meta/classes/siteinfo.bbclass
index 892abc1..436bc39 100644
--- a/meta/classes/siteinfo.bbclass
+++ b/meta/classes/siteinfo.bbclass
@@ -40,6 +40,7 @@ def get_siteinfo_list(d):
                "i486-linux-uclibc":       "endian-little bit-32 common-uclibc ix86-common",\
                "i586-linux-uclibc":       "endian-little bit-32 common-uclibc ix86-common",\
                "i686-linux-uclibc":       "endian-little bit-32 common-uclibc ix86-common",\
+               "microblaze-linux-gnu":    "endian-big bit-32 common-glibc microblaze-common",\
                "mipsel-linux":            "endian-little bit-32 common-glibc mips-common",\
                "mipsel-linux-uclibc":     "endian-little bit-32 common-uclibc mips-common",\
                "mips-linux":              "endian-big bit-32 common-glibc mips-common",\
-- 
1.7.4.4



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 4/7] linux-libc-headers: add microblaze ARCH definition
  2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
                   ` (2 preceding siblings ...)
  2011-05-05 19:10 ` [PATCH 3/7] siteinfo: add microblaze target info Adrian Alonso
@ 2011-05-05 19:11 ` Adrian Alonso
  2011-05-05 19:11 ` [PATCH 5/7] image-mklibs: add microblaze arch support Adrian Alonso
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:11 UTC (permalink / raw)
  To: poky

* Add Microblaze ARCH definition
* Bump PR

Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
 .../linux-libc-headers_2.6.37.2.bb                 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_2.6.37.2.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_2.6.37.2.bb
index 888d9e4..51c4926 100644
--- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_2.6.37.2.bb
+++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_2.6.37.2.bb
@@ -2,7 +2,7 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r0"
+PR = "r1"
 
 SRC_URI += " file://connector-msg-size-fix.patch"
 
@@ -26,6 +26,7 @@ set_arch() {
 		x86_64*)  ARCH=x86_64 ;;
 		avr32*)   ARCH=avr32 ;;
 		bfin*)    ARCH=blackfin ;;
+		microblaze*) ARCH=microblaze ;;
 	esac
 }
 
-- 
1.7.4.4



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 5/7] image-mklibs: add microblaze arch support
  2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
                   ` (3 preceding siblings ...)
  2011-05-05 19:11 ` [PATCH 4/7] linux-libc-headers: add microblaze ARCH definition Adrian Alonso
@ 2011-05-05 19:11 ` Adrian Alonso
  2011-05-05 19:11 ` [PATCH 6/7] package_rpm: use target vendor information Adrian Alonso
  2011-05-05 19:11 ` [PATCH 7/7] readline: update version Adrian Alonso
  6 siblings, 0 replies; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:11 UTC (permalink / raw)
  To: poky

* In function mklibs_optimize_image_doit
* Add microblaze arch case for setting the dynamic_loader
  used by "mklibs" call

Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
 meta/classes/image-mklibs.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/image-mklibs.bbclass b/meta/classes/image-mklibs.bbclass
index 0e72b01..9f5a4ea 100644
--- a/meta/classes/image-mklibs.bbclass
+++ b/meta/classes/image-mklibs.bbclass
@@ -16,7 +16,7 @@ mklibs_optimize_image_doit() {
 		> ${WORKDIR}/mklibs/executables.list
 
 	case ${TARGET_ARCH} in
-		powerpc | mips )
+		powerpc | mips | microblaze )
 			dynamic_loader="/lib/ld.so.1"
 			;;
 		x86_64)
-- 
1.7.4.4



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 6/7] package_rpm: use target vendor information
  2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
                   ` (4 preceding siblings ...)
  2011-05-05 19:11 ` [PATCH 5/7] image-mklibs: add microblaze arch support Adrian Alonso
@ 2011-05-05 19:11 ` Adrian Alonso
  2011-05-06 17:19   ` Darren Hart
  2011-05-05 19:11 ` [PATCH 7/7] readline: update version Adrian Alonso
  6 siblings, 1 reply; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:11 UTC (permalink / raw)
  To: poky

* Instead of hardcoding target vendor string "-poky"
  use TARGET_VENDOR information in case of using external
  toolchains

Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
 meta/classes/package_rpm.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
index 70170d1..1cf9f79 100644
--- a/meta/classes/package_rpm.bbclass
+++ b/meta/classes/package_rpm.bbclass
@@ -761,13 +761,14 @@ python do_package_rpm () {
 	# Setup the rpmbuild arguments...
 	rpmbuild = bb.data.getVar('RPMBUILD', d, True)
 	targetsys = bb.data.getVar('TARGET_SYS', d, True)
+	targetvendor = bb.data.getVar('TARGET_VENDOR', d, True)
 	pkgwritedir = bb.data.expand('${PKGWRITEDIRRPM}/${PACKAGE_ARCH}', d)
 	pkgarch = bb.data.expand('${PACKAGE_ARCH}', d)
 	bb.mkdirhier(pkgwritedir)
 	os.chmod(pkgwritedir, 0755)
 
 	cmd = rpmbuild
-	cmd = cmd + " --nodeps --short-circuit --target " + pkgarch + "-poky-linux-gnu --buildroot " + pkgd
+	cmd = cmd + " --nodeps --short-circuit --target " + pkgarch + targetvendor + "-linux-gnu --buildroot " + pkgd
 	cmd = cmd + " --define '_topdir " + workdir + "' --define '_rpmdir " + pkgwritedir + "'"
 	cmd = cmd + " --define '_build_name_fmt %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm'"
 	cmd = cmd + " --define '_use_internal_dependency_generator 0'"
-- 
1.7.4.4



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 7/7] readline: update version
  2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
                   ` (5 preceding siblings ...)
  2011-05-05 19:11 ` [PATCH 6/7] package_rpm: use target vendor information Adrian Alonso
@ 2011-05-05 19:11 ` Adrian Alonso
  6 siblings, 0 replies; 14+ messages in thread
From: Adrian Alonso @ 2011-05-05 19:11 UTC (permalink / raw)
  To: poky

* Readline new recipe version 6.2

Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
 meta/recipes-core/readline/readline_6.2.bb |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-core/readline/readline_6.2.bb

diff --git a/meta/recipes-core/readline/readline_6.2.bb b/meta/recipes-core/readline/readline_6.2.bb
new file mode 100644
index 0000000..5e32bb5
--- /dev/null
+++ b/meta/recipes-core/readline/readline_6.2.bb
@@ -0,0 +1,6 @@
+require readline.inc
+
+PR = "r0"
+
+SRC_URI[md5sum] = "67948acb2ca081f23359d0256e9a271c"
+SRC_URI[sha256sum] = "79a696070a058c233c72dd6ac697021cc64abd5ed51e59db867d66d196a89381"
-- 
1.7.4.4



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH 6/7] package_rpm: use target vendor information
  2011-05-05 19:11 ` [PATCH 6/7] package_rpm: use target vendor information Adrian Alonso
@ 2011-05-06 17:19   ` Darren Hart
       [not found]     ` <BANLkTi=xgBnjob=1U7yaPFyT-y075odAvA@mail.gmail.com>
  2011-05-06 18:02     ` Mark Hatle
  0 siblings, 2 replies; 14+ messages in thread
From: Darren Hart @ 2011-05-06 17:19 UTC (permalink / raw)
  To: Adrian Alonso; +Cc: poky

Hi Adrian,

One issue below:

On 05/05/2011 12:11 PM, Adrian Alonso wrote:
> * Instead of hardcoding target vendor string "-poky"
>   use TARGET_VENDOR information in case of using external
>   toolchains
> 
> Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
> ---
>  meta/classes/package_rpm.bbclass |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
> index 70170d1..1cf9f79 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -761,13 +761,14 @@ python do_package_rpm () {
>  	# Setup the rpmbuild arguments...
>  	rpmbuild = bb.data.getVar('RPMBUILD', d, True)
>  	targetsys = bb.data.getVar('TARGET_SYS', d, True)
> +	targetvendor = bb.data.getVar('TARGET_VENDOR', d, True)
>  	pkgwritedir = bb.data.expand('${PKGWRITEDIRRPM}/${PACKAGE_ARCH}', d)
>  	pkgarch = bb.data.expand('${PACKAGE_ARCH}', d)
>  	bb.mkdirhier(pkgwritedir)
>  	os.chmod(pkgwritedir, 0755)
>  
>  	cmd = rpmbuild
> -	cmd = cmd + " --nodeps --short-circuit --target " + pkgarch + "-poky-linux-gnu --buildroot " + pkgd
> +	cmd = cmd + " --nodeps --short-circuit --target " + pkgarch + targetvendor + "-linux-gnu --buildroot " + pkgd

You need:
 + "-" + targetvendor

otherwise you'll merge pkgarch and targetvendor together without a delimiter.
Better yet, just format the string in one go and reduce the potential for error:

cmd = "%s --nodeps --short-circuit --target %s-%s-linux-gnu --buildroot %s" % \
      (rpmbuild, pkgarch, targetvendor, pkgd)

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 6/7] package_rpm: use target vendor information
       [not found]     ` <BANLkTi=xgBnjob=1U7yaPFyT-y075odAvA@mail.gmail.com>
@ 2011-05-06 17:58       ` Adrian Alonso
  2011-05-06 18:48         ` Darren Hart
  0 siblings, 1 reply; 14+ messages in thread
From: Adrian Alonso @ 2011-05-06 17:58 UTC (permalink / raw)
  To: poky

[-- Attachment #1: Type: text/plain, Size: 2563 bytes --]

Op forgot replay all

---------- Forwarded message ----------
From: Adrian Alonso <aalonso@secretlab.ca>
Date: Fri, May 6, 2011 at 12:49 PM
Subject: Re: [poky] [PATCH 6/7] package_rpm: use target vendor information
To: Darren Hart <dvhart@linux.intel.com>


Hi Darren,

In poky-default.inc target vendor is set as:

TARGET_VENDOR="-poky"

In xilinx-meta layer is set as

TARGET_VENDOR="-unknown"

So the result string is correct if TARGET_VENDOR assignment is consistent
as in poky-default.inc

Regards


On Fri, May 6, 2011 at 12:19 PM, Darren Hart <dvhart@linux.intel.com> wrote:

> Hi Adrian,
>
> One issue below:
>
> On 05/05/2011 12:11 PM, Adrian Alonso wrote:
> > * Instead of hardcoding target vendor string "-poky"
> >   use TARGET_VENDOR information in case of using external
> >   toolchains
> >
> > Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
> > ---
> >  meta/classes/package_rpm.bbclass |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/classes/package_rpm.bbclass
> b/meta/classes/package_rpm.bbclass
> > index 70170d1..1cf9f79 100644
> > --- a/meta/classes/package_rpm.bbclass
> > +++ b/meta/classes/package_rpm.bbclass
> > @@ -761,13 +761,14 @@ python do_package_rpm () {
> >       # Setup the rpmbuild arguments...
> >       rpmbuild = bb.data.getVar('RPMBUILD', d, True)
> >       targetsys = bb.data.getVar('TARGET_SYS', d, True)
> > +     targetvendor = bb.data.getVar('TARGET_VENDOR', d, True)
> >       pkgwritedir = bb.data.expand('${PKGWRITEDIRRPM}/${PACKAGE_ARCH}',
> d)
> >       pkgarch = bb.data.expand('${PACKAGE_ARCH}', d)
> >       bb.mkdirhier(pkgwritedir)
> >       os.chmod(pkgwritedir, 0755)
> >
> >       cmd = rpmbuild
> > -     cmd = cmd + " --nodeps --short-circuit --target " + pkgarch +
> "-poky-linux-gnu --buildroot " + pkgd
> > +     cmd = cmd + " --nodeps --short-circuit --target " + pkgarch +
> targetvendor + "-linux-gnu --buildroot " + pkgd
>
> You need:
>  + "-" + targetvendor
>
> otherwise you'll merge pkgarch and targetvendor together without a
> delimiter.
> Better yet, just format the string in one go and reduce the potential for
> error:
>
> cmd = "%s --nodeps --short-circuit --target %s-%s-linux-gnu --buildroot %s"
> % \
>      (rpmbuild, pkgarch, targetvendor, pkgd)
>
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
>



-- 
Adrian Alonso
Secret Lab Technologies Ltd.



-- 
Adrian Alonso
Secret Lab Technologies Ltd.

[-- Attachment #2: Type: text/html, Size: 3645 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 6/7] package_rpm: use target vendor information
  2011-05-06 17:19   ` Darren Hart
       [not found]     ` <BANLkTi=xgBnjob=1U7yaPFyT-y075odAvA@mail.gmail.com>
@ 2011-05-06 18:02     ` Mark Hatle
  1 sibling, 0 replies; 14+ messages in thread
From: Mark Hatle @ 2011-05-06 18:02 UTC (permalink / raw)
  To: poky

On 5/6/11 12:19 PM, Darren Hart wrote:
> Hi Adrian,

With the issue fixed below, this looks like a good change to me.

--Mark

> One issue below:
> 
> On 05/05/2011 12:11 PM, Adrian Alonso wrote:
>> * Instead of hardcoding target vendor string "-poky"
>>   use TARGET_VENDOR information in case of using external
>>   toolchains
>>
>> Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
>> ---
>>  meta/classes/package_rpm.bbclass |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
>> index 70170d1..1cf9f79 100644
>> --- a/meta/classes/package_rpm.bbclass
>> +++ b/meta/classes/package_rpm.bbclass
>> @@ -761,13 +761,14 @@ python do_package_rpm () {
>>  	# Setup the rpmbuild arguments...
>>  	rpmbuild = bb.data.getVar('RPMBUILD', d, True)
>>  	targetsys = bb.data.getVar('TARGET_SYS', d, True)
>> +	targetvendor = bb.data.getVar('TARGET_VENDOR', d, True)
>>  	pkgwritedir = bb.data.expand('${PKGWRITEDIRRPM}/${PACKAGE_ARCH}', d)
>>  	pkgarch = bb.data.expand('${PACKAGE_ARCH}', d)
>>  	bb.mkdirhier(pkgwritedir)
>>  	os.chmod(pkgwritedir, 0755)
>>  
>>  	cmd = rpmbuild
>> -	cmd = cmd + " --nodeps --short-circuit --target " + pkgarch + "-poky-linux-gnu --buildroot " + pkgd
>> +	cmd = cmd + " --nodeps --short-circuit --target " + pkgarch + targetvendor + "-linux-gnu --buildroot " + pkgd
> 
> You need:
>  + "-" + targetvendor
> 
> otherwise you'll merge pkgarch and targetvendor together without a delimiter.
> Better yet, just format the string in one go and reduce the potential for error:
> 
> cmd = "%s --nodeps --short-circuit --target %s-%s-linux-gnu --buildroot %s" % \
>       (rpmbuild, pkgarch, targetvendor, pkgd)
> 



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 6/7] package_rpm: use target vendor information
  2011-05-06 17:58       ` Adrian Alonso
@ 2011-05-06 18:48         ` Darren Hart
  0 siblings, 0 replies; 14+ messages in thread
From: Darren Hart @ 2011-05-06 18:48 UTC (permalink / raw)
  To: Adrian Alonso; +Cc: poky



On 05/06/2011 10:58 AM, Adrian Alonso wrote:
> Op forgot replay all
> 
> ---------- Forwarded message ----------
> From: *Adrian Alonso* <aalonso@secretlab.ca <mailto:aalonso@secretlab.ca>>
> Date: Fri, May 6, 2011 at 12:49 PM
> Subject: Re: [poky] [PATCH 6/7] package_rpm: use target vendor information
> To: Darren Hart <dvhart@linux.intel.com <mailto:dvhart@linux.intel.com>>
> 
> 
> Hi Darren,
> 
> In poky-default.inc target vendor is set as:
> 
> TARGET_VENDOR="-poky"
> 
> In xilinx-meta layer is set as
> 
> TARGET_VENDOR="-unknown"

ew... embedded delimiters.


> 
> So the result string is correct if TARGET_VENDOR assignment is consistent
> as in poky-default.inc

OK, works as it did before I suppose.

--
Darren


> 
> Regards
> 
> 
> On Fri, May 6, 2011 at 12:19 PM, Darren Hart <dvhart@linux.intel.com
> <mailto:dvhart@linux.intel.com>> wrote:
> 
>     Hi Adrian,
> 
>     One issue below:
> 
>     On 05/05/2011 12:11 PM, Adrian Alonso wrote:
>     > * Instead of hardcoding target vendor string "-poky"
>     >   use TARGET_VENDOR information in case of using external
>     >   toolchains
>     >
>     > Signed-off-by: Adrian Alonso <aalonso@secretlab.ca
>     <mailto:aalonso@secretlab.ca>>
>     > ---
>     >  meta/classes/package_rpm.bbclass |    3 ++-
>     >  1 files changed, 2 insertions(+), 1 deletions(-)
>     >
>     > diff --git a/meta/classes/package_rpm.bbclass
>     b/meta/classes/package_rpm.bbclass
>     > index 70170d1..1cf9f79 100644
>     > --- a/meta/classes/package_rpm.bbclass
>     > +++ b/meta/classes/package_rpm.bbclass
>     > @@ -761,13 +761,14 @@ python do_package_rpm () {
>     >       # Setup the rpmbuild arguments...
>     >       rpmbuild = bb.data.getVar('RPMBUILD', d, True)
>     >       targetsys = bb.data.getVar('TARGET_SYS', d, True)
>     > +     targetvendor = bb.data.getVar('TARGET_VENDOR', d, True)
>     >       pkgwritedir =
>     bb.data.expand('${PKGWRITEDIRRPM}/${PACKAGE_ARCH}', d)
>     >       pkgarch = bb.data.expand('${PACKAGE_ARCH}', d)
>     >       bb.mkdirhier(pkgwritedir)
>     >       os.chmod(pkgwritedir, 0755)
>     >
>     >       cmd = rpmbuild
>     > -     cmd = cmd + " --nodeps --short-circuit --target " + pkgarch
>     + "-poky-linux-gnu --buildroot " + pkgd
>     > +     cmd = cmd + " --nodeps --short-circuit --target " + pkgarch
>     + targetvendor + "-linux-gnu --buildroot " + pkgd
> 
>     You need:
>      + "-" + targetvendor
> 
>     otherwise you'll merge pkgarch and targetvendor together without a
>     delimiter.
>     Better yet, just format the string in one go and reduce the
>     potential for error:
> 
>     cmd = "%s --nodeps --short-circuit --target %s-%s-linux-gnu
>     --buildroot %s" % \
>          (rpmbuild, pkgarch, targetvendor, pkgd)
> 
>     --
>     Darren Hart
>     Intel Open Source Technology Center
>     Yocto Project - Linux Kernel
> 
> 
> 
> 
> -- 
> Adrian Alonso
> Secret Lab Technologies Ltd.
> 
> 
> 
> -- 
> Adrian Alonso
> Secret Lab Technologies Ltd.
> 
> 
> 
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/7] insane: add micrblaze target info
  2011-05-05 19:10 ` [PATCH 1/7] insane: add micrblaze target info Adrian Alonso
@ 2011-05-08  6:14   ` Khem Raj
  2011-05-09 14:24     ` Adrian Alonso
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2011-05-08  6:14 UTC (permalink / raw)
  To: poky

On 5/5/2011 12:10 PM, Adrian Alonso wrote:
> * package_qa_get_machine_dict
> * Add microblaze dic entry for QA
> * Prebuilt toolchain triplet microblaze-unknown-linux-gnu-
> * TARGET_OS is linux-gnu for this toolchain
>
> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
> ---
>   meta/classes/insane.bbclass |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 742be5e..e9d4bfa 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -85,7 +85,9 @@ def package_qa_get_machine_dict():
>               "linux-uclibcspe" : {
>                           "powerpc":    (20,     0,    0,          False,         32),
>                         },
> -
> +            "linux-gnu" :       {
> +                        "microblaze": (47787,  0,    0,          False,         32),
> +                      },


we generally use *-*-linux except for arm and ppc (with spe ) can 
microblaze just use the same triplet ?
>          }
>
>



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/7] insane: add micrblaze target info
  2011-05-08  6:14   ` Khem Raj
@ 2011-05-09 14:24     ` Adrian Alonso
  0 siblings, 0 replies; 14+ messages in thread
From: Adrian Alonso @ 2011-05-09 14:24 UTC (permalink / raw)
  To: Khem Raj; +Cc: poky

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

Hi,

I'm integrating a third party toolchain which triplet is:
microblaze-unknown-linux-gnu-
Setting
TARGET_OS = "linux-gnu"; TARGET_VENDOR = "-unknown" resolves
the toolchain triplet in bitbake.conf and I'm able to integrate the
toolchain without
messing around with the third party toolchain.

Let me work if I can override insane.bbclass to be less third party
toolchain specific.

Regards


On Sun, May 8, 2011 at 1:14 AM, Khem Raj <raj.khem@gmail.com> wrote:

> On 5/5/2011 12:10 PM, Adrian Alonso wrote:
>
>> * package_qa_get_machine_dict
>> * Add microblaze dic entry for QA
>> * Prebuilt toolchain triplet microblaze-unknown-linux-gnu-
>> * TARGET_OS is linux-gnu for this toolchain
>>
>> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
>> ---
>>  meta/classes/insane.bbclass |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index 742be5e..e9d4bfa 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -85,7 +85,9 @@ def package_qa_get_machine_dict():
>>              "linux-uclibcspe" : {
>>                          "powerpc":    (20,     0,    0,          False,
>>       32),
>>                        },
>> -
>> +            "linux-gnu" :       {
>> +                        "microblaze": (47787,  0,    0,          False,
>>       32),
>> +                      },
>>
>
>
> we generally use *-*-linux except for arm and ppc (with spe ) can
> microblaze just use the same triplet ?
>
>>         }
>>
>>
>>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>



-- 
Adrian Alonso
Secret Lab Technologies Ltd.

[-- Attachment #2: Type: text/html, Size: 2805 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2011-05-09 14:25 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-05 19:10 [PATCH 0/7] Microblaze target arch support Adrian Alonso
2011-05-05 19:10 ` [PATCH 1/7] insane: add micrblaze target info Adrian Alonso
2011-05-08  6:14   ` Khem Raj
2011-05-09 14:24     ` Adrian Alonso
2011-05-05 19:10 ` [PATCH 2/7] kernel-arch: add microblaze to valid archs Adrian Alonso
2011-05-05 19:10 ` [PATCH 3/7] siteinfo: add microblaze target info Adrian Alonso
2011-05-05 19:11 ` [PATCH 4/7] linux-libc-headers: add microblaze ARCH definition Adrian Alonso
2011-05-05 19:11 ` [PATCH 5/7] image-mklibs: add microblaze arch support Adrian Alonso
2011-05-05 19:11 ` [PATCH 6/7] package_rpm: use target vendor information Adrian Alonso
2011-05-06 17:19   ` Darren Hart
     [not found]     ` <BANLkTi=xgBnjob=1U7yaPFyT-y075odAvA@mail.gmail.com>
2011-05-06 17:58       ` Adrian Alonso
2011-05-06 18:48         ` Darren Hart
2011-05-06 18:02     ` Mark Hatle
2011-05-05 19:11 ` [PATCH 7/7] readline: update version Adrian Alonso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.